[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #39 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
https://bugzilla.redhat.com/show_bug.cgi?id=589867 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
https://bugzilla.redhat.com/show_bug.cgi?id=589867 Matthias Runge changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #38 from Matthias Runge --- Package Change Request == Package Name: logcheck New Branches: epel7 Owners: mrunge -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Fedora Update System changed: What|Removed |Added Fixed In Version|logcheck-1.3.13-2.fc14 |logcheck-1.3.13-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #37 from Fedora Update System 2011-09-24 17:55:50 EDT --- logcheck-1.3.13-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #36 from Fedora Update System 2011-08-17 08:23:47 EDT --- logcheck-1.3.13-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/logcheck-1.3.13-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #35 from ch...@chris-keane.co.uk 2010-10-13 11:46:09 EDT --- Thanks for the speedy attention. Sure - I thought about opening a new bug, but was just obeying the instruction in comment 30: "If problems still persist, please make note of it in this bug report." -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #34 from Matthias Runge 2010-10-13 06:06:10 EDT --- Thank you for your report. I'll take a deeper look into this later this day. Could you please open a new bug instead of reopening an existing one next time? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #33 from ch...@chris-keane.co.uk 2010-10-13 06:03:29 EDT --- In confirmation of the above: simply replacing the invocation of run-parts with /bin/ls in the cleanrules() function of logcheck fixes the problem. We don't want to do this, because it loses the benefits of run-parts (ignoring .rpmsave files, etc.) - but it does demonstrate that that's where the problem is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 ch...@chris-keane.co.uk changed: What|Removed |Added CC||ch...@chris-keane.co.uk --- Comment #32 from ch...@chris-keane.co.uk 2010-10-13 05:44:52 EDT --- Thanks very much for adding logcheck to the repository - great tool. But it doesn't seem to be working at all: it's not filtering any entries out on my system. I've tested using log messages from a few daemons with /usr/bin/logcheck-test, and the ignore rules are matching correctly, but a run of logcheck then spews out all those log messages without filtering any out. Here's what I think is happening: logcheck uses /usr/bin/run-parts to pick up the filter rule files from subdirectories of /etc/logcheck. run-parts looks for executables, and runs them. But that's not what logcheck wants it to do - logcheck wants it to spit out the names of matching files, not actually execute them. The Debian version of run-parts has a --list parameter, which does exactly this. When the logcheck package has been ported across to Fedora, the --list parameter has been removed from the invocation of run-parts (because our version of run-parts doesn't have that parameter), but that simply results in run-parts producing no output. Which means that logcheck thinks it has no filter rule files. Which means no log messages ever get filtered out. I'm surprised that this is the case, because the package should never have been pushed to stable with such a fundamental bug in it. But I'm fairly sure that's what's going on (on my system, at least - Fedora 13 with logcheck-1.3.13-2.fc13.noarch and crontabs-1.10-32.fc13.noarch). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Fedora Update System changed: What|Removed |Added Fixed In Version|logcheck-1.3.13-2.fc13 |logcheck-1.3.13-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #31 from Fedora Update System 2010-10-05 09:26:20 EDT --- logcheck-1.3.13-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #30 from Fedora Update System 2010-10-05 05:40:16 EDT --- logcheck-1.3.13-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||logcheck-1.3.13-2.fc13 Resolution||ERRATA Last Closed||2010-10-05 05:40:22 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #29 from Fedora Update System 2010-09-14 13:29:56 EDT --- logcheck-1.3.13-3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update logcheck'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/logcheck-1.3.13-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #28 from Fedora Update System 2010-09-14 05:10:29 EDT --- logcheck-1.3.13-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/logcheck-1.3.13-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #27 from Fedora Update System 2010-09-14 04:48:23 EDT --- logcheck-1.3.13-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/logcheck-1.3.13-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #26 from Fedora Update System 2010-09-14 04:46:51 EDT --- logcheck-1.3.13-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/logcheck-1.3.13-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System 2010-09-12 14:24:49 EDT --- logcheck-1.3.13-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update logcheck'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/logcheck-1.3.13-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #24 from Fedora Update System 2010-09-11 15:22:03 EDT --- logcheck-1.3.13-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/logcheck-1.3.13-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED Bug 589867 depends on bug 601115, which changed state. Bug 601115 Summary: Review Request: lockfile-progs - safely lock and unlock files https://bugzilla.redhat.com/show_bug.cgi?id=601115 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #22 from Fedora Update System 2010-09-11 15:19:24 EDT --- logcheck-1.3.13-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/logcheck-1.3.13-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #23 from Fedora Update System 2010-09-11 15:21:30 EDT --- logcheck-1.3.13-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/logcheck-1.3.13-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #21 from Kevin Fenzi 2010-09-10 14:47:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Matthias Runge changed: What|Removed |Added Flag||fedora-cvs? --- Comment #20 from Matthias Runge 2010-09-10 02:41:47 EDT --- Thank you Peter! New Package SCM Request === Package Name: logcheck Short Description: analyzes logfiles and sends email Owners: mrunge Branches: f13 f14 devel el5 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Peter Robinson changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #19 from Peter Robinson 2010-09-09 13:34:25 EDT --- Seems sane. APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #18 from Matthias Runge 2010-09-07 15:57:51 EDT --- Thanks for the review. Some of those errors resp. warnings are not so easy to fix. I decided to set the permissions more fedora-like. INSTALL-file says, logcheck-user should own the config-files. I cannot see a reason for this, or why root may not own them, esp. why those config files may not me read by other users. Information hiding does not work in most cases. mru...@sofja noarch]$ rpmlint logcheck-1.3.13-1.fc14.noarch.rpm logcheck.noarch: W: non-standard-uid /var/lib/logcheck logcheck logcheck.noarch: W: non-standard-gid /var/lib/logcheck logcheck logcheck.noarch: E: non-standard-dir-perm /var/lib/logcheck 0700L logcheck.noarch: W: manual-page-warning /usr/share/man/man8/logcheck.8.gz 1: warning: macro `\"' not defined logcheck.noarch: W: non-standard-uid /var/lock/logcheck logcheck logcheck.noarch: W: non-standard-gid /var/lock/logcheck logcheck logcheck.noarch: E: non-standard-dir-perm /var/lock/logcheck 0700L Adding a new user and group makes such messages. logcheck should own /var/lib/logcheck and /var/lock/logcheck. Those permissions are sane to me. Fixed files: SPEC: http://www.matthias-runge.de/fedora/logcheck.spec SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.13-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=589867
--- Comment #17 from Peter Robinson 2010-09-06 15:03:40
EDT ---
Sorry for the delay. There's a few issues that need to be addressed
+ rpmlint output
rpmlint logcheck*
logcheck.noarch: W: non-standard-uid /var/lib/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lib/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lib/logcheck 0700L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/cracking.d 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/violations.ignore.d
02750L
logcheck.noarch: E: non-readable /etc/logcheck/logcheck.logfiles 0640L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.server 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.paranoid
02750L
logcheck.noarch: E: non-readable /etc/logcheck/logcheck.conf 0640L
logcheck.noarch: W: non-standard-uid /var/lock/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lock/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lock/logcheck 0700L
logcheck.noarch: W: non-standard-gid /etc/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck 0750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.workstation
02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/violations.d 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/cracking.ignore.d
02750L
logcheck.noarch: W: manual-page-warning /usr/share/man/man1/Logcheck.8.gz 1:
warning: `\"' not defined
logcheck.noarch: W: no-manual-page-for-binary logcheck
logcheck.src: W: invalid-url Source0:
http://ftp.de.debian.org/debian/pool/main/l/logcheck/logcheck_1.3.11.tar.gz
HTTP Error 404: Not Found
logcheck.spec: W: invalid-url Source0:
http://ftp.de.debian.org/debian/pool/main/l/logcheck/logcheck_1.3.11.tar.gz
HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 12 errors, 9 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
- latest version packaged
version 1.3.13 is available
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
- upstream sources match sources in the srpm
packaged version doesn't seem to be available any longer
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ Package perserves timestamps on install
- Permissions on files must be set properly
rpmlint complains about a number of permissions
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
package built using koji scratch build
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
+ Package should have man files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #16 from Peter Robinson 2010-08-29 10:01:47 EDT --- (In reply to comment #15) > lockfile-progs (as last remaining dependency) is in -testing now. All other > dependencies are approved and hit the repositories. > > Can we proceed with the review now? Yes, I'll do it in the next day or two. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #15 from Matthias Runge 2010-08-28 17:59:15 EDT --- lockfile-progs (as last remaining dependency) is in -testing now. All other dependencies are approved and hit the repositories. Can we proceed with the review now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Peter Robinson changed: What|Removed |Added Status|NEW |ASSIGNED CC||pbrobin...@gmail.com AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Bug 589867 depends on bug 602587, which changed state. Bug 602587 Summary: Review Request: perl-IPC-Signal - Utility functions dealing with signals https://bugzilla.redhat.com/show_bug.cgi?id=602587 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #14 from Matthias Runge 2010-08-05 04:03:39 EDT --- I've updated from 1.3.8 to version 1.3.11. I took the hint from Paul and let install section create homedir for logcheck, the package owns homedir, too. To enhance readability, I substituted the two mini-patches by sed-invocations. Updated files: SPEC: http://www.matthias-runge.de/fedora/logcheck.spec SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.11-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #13 from Paul Howarth 2010-06-10 07:47:48 EDT --- (In reply to comment #12) > > I wouldn't use "logcheck" as the default group in %defattr as it will make > > it > > the default group for everything, including the binaries, documentation, > > cron > > scripts etc., which is probably not what you want. > > > > I would have your package create and own the /var/lib/logcheck directory > > rather > > than having useradd create it in %pre, so that the directory gets removed if > > the package is removed from the system. > > That's a little difficult. First of all, I fully agree with you, but what > happens with the "logcheck"-user when the package is removed. Created users > should be left on the system, afaik. When the user is left, why remove his > home > dir? The user would be left on the system, but wouldn't be actively used for anything - it would just own any files that may have been left around from the running of the program - if any. The absence of a home directory wouldn't matter for that purpose. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=589867
--- Comment #12 from Matthias Runge 2010-06-10
07:12:40 EDT ---
> %{_datadir}/logtail/
That suits me better.
>
>
> I wouldn't use "logcheck" as the default group in %defattr as it will make it
> the default group for everything, including the binaries, documentation, cron
> scripts etc., which is probably not what you want.
>
> I would have your package create and own the /var/lib/logcheck directory
> rather
> than having useradd create it in %pre, so that the directory gets removed if
> the package is removed from the system.
That's a little difficult. First of all, I fully agree with you, but what
happens with the "logcheck"-user when the package is removed. Created users
should be left on the system, afaik. When the user is left, why remove his home
dir?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=589867
Paul Howarth changed:
What|Removed |Added
CC||p...@city-fan.org
--- Comment #11 from Paul Howarth 2010-06-10 06:19:45 EDT
---
(In reply to comment #2)
> no need to list %dir %{_datadir}/logtail, just %{_datadir}/logtail/* is enough
Not quite. You actually need:
%{_datadir}/logtail/
This includes the directory and its contents. Using just %{_datadir}/logtail/*
would mean that the package did not own the directory itself, which would be
wrong since none of the package's dependencies own it either.
Similarly you should add:
%dir %{_sysconfdir}/%{name}/
for ownership of this directory. The %dir is needed here because you want to
mark the contents of the directory as %config(noreplace).
> replace
> %{_sbindir}/logcheck
> %{_sbindir}/logtail
> %{_sbindir}/logtail2
>
> with %{_sbindir}/*
That's a matter of style and I would personally prefer the original form.
I wouldn't use "logcheck" as the default group in %defattr as it will make it
the default group for everything, including the binaries, documentation, cron
scripts etc., which is probably not what you want.
I would have your package create and own the /var/lib/logcheck directory rather
than having useradd create it in %pre, so that the directory gets removed if
the package is removed from the system.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #10 from Matthias Runge 2010-06-10 05:41:45 EDT --- I've submitted all dependand packages for review, in total 5 dependant packages. As I already wrote in #c9 , those are really small and any help is grateful taken -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #9 from Matthias Runge 2010-06-10 05:22:09 EDT --- I see, it looks like much work to review logcheck or it's dependencies. Luckily those dependants are really small and any help is greately appreciated. Thanks anyway! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Matthias Runge changed: What|Removed |Added Depends on||602587 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) 2010-06-08 05:29:10 EDT --- Mohammed, no, I do not want take it form you! If you plan do it - please. Now I see it have long tail of dependencies instead I simple help you with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #7 from Mohammed Imran 2010-06-07 05:51:17 EDT --- Hi pavel, If you are interested, you can take the review ;).Im bit busy now,so wont be able to make the review till weekend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Till Maas changed: What|Removed |Added CC||opensou...@till.name Depends on||601115 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) 2010-06-07 05:35:41 EDT --- Mohammed Imran, do you plan make this review? No flag set there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #5 from Matthias Runge 2010-06-07 05:22:19 EDT --- Update: SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.8-5.fc13.src.rpm SPEC: http://www.matthias-runge.de/fedora/logcheck.spec Version 1.3.8-5 contains some fixes: - add lockfile-progs as requirement - debians run-parts accepts --list parameter, fedoras doesn't need it lockfile-progs is a new review request https://bugzilla.redhat.com/show_bug.cgi?id=601115 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #4 from Matthias Runge 2010-05-10 03:22:54 EDT --- Version 1.3.8-3 contains a modified list of logfiles to watch, since fedora does not use -/var/log/syslog -/var/log/auth.log Spec URL: http://www.matthias-runge.de/fedora/logcheck.spec SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.8-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #3 from Matthias Runge 2010-05-08 16:12:53 EDT --- Thank you for your review. I did not perform the install routine from debian, mainly because it creates lots of rpmlint warnings and some errors regarding wrong dir-permissions. I changed my mind about this. You'll find the corrected spec and srpm under the following urls. Spec URL: http://www.matthias-runge.de/fedora/logcheck.spec SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.8-2.fc13.src.rpm changelog * Sat May 8 2010 Matthias Runge 1.3.8-2 - install man page - clean up permissions and files section - user logcheck added Even if Fedora does not require the BuildRoot tag, I'll leave it there; I'd like to include logcheck in EPEL, too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=589867
Mohammed Imran changed:
What|Removed |Added
CC||imran...@gmail.com
--- Comment #2 from Mohammed Imran 2010-05-07 10:00:55 EDT
---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Rpmlint is silent
[x] Package is not relocatable.
[!] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
its not needed anymore, you can remove it
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:GPLv2
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:86ea9f35183f28f95deb0aba509efb61
MD5SUM upstream package:86ea9f35183f28f95deb0aba509efb61
[x] Package is not known to require ExcludeArch, OR:
[x] All build dependencies are listed in BuildRequires, except for any that
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[-] Package must own all directories that it creates.
[-] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[!] Permissions on files are set properly.
retain %config(noreplace) lines,remove %attr(0755,root,root) lines,also group
can be logcheck ?
your makefile handles all this
no need to list %dir %{_datadir}/logtail, just %{_datadir}/logtail/* is enough
replace
%{_sbindir}/logcheck
%{_sbindir}/logtail
%{_sbindir}/logtail2
with %{_sbindir}/*
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[!] Large documentation files are in a -doc subpackage, if required.
make -doc package,also there is man page which you need to install in man
directory
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
Needs to be Fixed
==
According to install instructins
#-Extract logcheck and run make install.
-Add an unpriviliged user for running logcheck. (typicallly named "logcheck")
-chown -R logcheck /etc/logcheck /var/lock/logcheck /var/lib/logcheck
-Be sure this user can access your log files
-Edit logcheck configuration files in /etc/logcheck. Most importantly
logcheck.conf. logcheck.logfiles contains a list of logfiles to be scanned.
-Install logcheck cron job. There is a sample in debian/logcheck.cron.d
where you are performing these steps ?
you may use use scriptlets
see http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
Please Fix the above issues
please do read
http://fedoraproject.org/wiki/Packaging/Guidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 --- Comment #1 from Matthias Runge 2010-05-07 03:17:26 EDT --- [mru...@mrungexp SPECS]$ rpmlint logcheck.spec ../RPMS/noarch/logcheck-1.3.8-1.fc13.noarch.rpm ../SRPMS/logcheck-1.3.8-1.fc13.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
