[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Fedora Update System changed: What|Removed |Added Fixed In Version||maven-license-plugin-1.8.0- ||2.fc14 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #16 from Fedora Update System 2010-11-14 16:37:12 EST --- maven-license-plugin-1.8.0-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #15 from Fedora Update System 2010-11-06 06:43:53 EDT --- maven-license-plugin-1.8.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/maven-license-plugin-1.8.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Guido Grazioli changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-11-06 06:28:18 --- Comment #14 from Guido Grazioli 2010-11-06 06:28:18 EDT --- Build in rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=201117 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #13 from Kevin Fenzi 2010-10-18 23:56:24 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Guido Grazioli changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Guido Grazioli 2010-10-18 04:14:09 EDT --- New Package SCM Request === Package Name: maven-license-plugin Short Description: Maven plugin to update header licenses of source files Owners: guidograzioli Branches: f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Alexander Kurtakov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Alexander Kurtakov 2010-10-18 01:35:24 EDT --- Thanks, This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #10 from Guido Grazioli 2010-10-17 16:41:23 EDT --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2539603 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #9 from Guido Grazioli 2010-10-17 16:34:41 EDT --- === Issues === 1. Please use %_mavenpomdir macro in install section. 2. Package is missing requires maven2 and xmltool. 3. Consider using maven-plugin-testing-harness instead of maven-shared-plugin-testing-harness in BRs. It has been moved to separate package. Thanks; fixed here: SPEC: http://guidograzioli.fedorapeople.org/packages/maven-license-plugin/maven-license-plugin.spec SRPM: http://guidograzioli.fedorapeople.org/packages/maven-license-plugin/maven-license-plugin-1.8.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590680
--- Comment #8 from Alexander Kurtakov 2010-10-13
15:51:05 EDT ---
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[X] Rpmlint output:
maven-license-plugin-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs
-> Java docs, Java-docs, Javanese
maven-license-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-license-plugin
Not a problem.
[X] Package is named according to the Package Naming Guidelines[1].
[X] Spec file name must match the base package name, in the format
%{name}.spec.
[X] Package meets the Packaging Guidelines[2].
[X] Package successfully compiles and builds into binary rpms.
[X] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[X] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[X] License field in the package spec file matches the actual license.
License type:
[X] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[X] All independent sub-packages have license of their own
[X] Spec file is legible and written in American English.
[-] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[X] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[X] Package must own all directories that it creates.
[X] Package requires other packages for directories it uses.
[X] Package does not contain duplicates in %files.
[X] Permissions on files are set properly.
[X] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[X] Package consistently uses macros.
[X] Package contains code, or permissable content.
[X] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[-] Package does not own files or directories owned by other packages.
[X] Javadoc documentation files are generated and included in -javadoc
subpackage
[X] Packages have proper BuildRequires/Requires on jpackage-utils
[X] Javadoc subpackages have Require: jpackage-utils
[-] Package uses %global not %define
[X] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[X] If source tarball includes bundled jar/class files these need to be
removed prior to building
[X] All filenames in rpm packages must be valid UTF-8.
=== Maven ===
[!] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
Used in files but not in install section
[X] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[X] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[X] Package uses %update_maven_depmap in %post/%postun
[X] Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)
=== Other suggestions ===
[X] If possible use upstream build method (maven/ant/javac)
[X] Javadocs are placed in %{_javadocdir}/%{name}-%{version} with
%{_javadocdir}/%{name} symlink
[X] Jar files are installed to %{_javadir}/%{name}-%{version}.jar with
%{_javadir}/%{name}.jar (unversioned) symlink
[X] If package contains pom.xml files install it (including depmaps) even when
building with ant
[X] Avoid having BuildRequires on exact NVR unless necessary
[X] Package has BuildArch: noarch (if possible)
[X] Latest version is packaged.
=== Issues ===
1. Please use %_mavenpomdir macro in install section.
2. Package is missing requires maven2 and xmltool.
3. Consider using maven-plugin-testing-harness instead of
maven-shared-plugin-testing-harness in BRs. It has been moved to separate
package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #7 from Guido Grazioli 2010-10-07 19:03:38 EDT --- I just uploaded new maven-license-plugin 1.8.0 package files here: http://guidograzioli.fedorapeople.org/packages/maven-license-plugin/ objenesis which depends on this package (well, its not a requirement, just a build plugin) needs updating as well before being ready to be reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #6 from Guido Grazioli 2010-09-08 13:43:14 EDT --- Sure, ill update maven-release first, this one will come next. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #5 from Alexander Kurtakov 2010-08-31 18:18:07 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #4 from Alexander Kurtakov 2010-08-25 12:03:10 EDT --- Guido, Are you still interested in getting this package in Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #3 from Alexander Kurtakov 2010-07-26 10:02:58 EDT --- maven-changes-plugin is available in rawhide but new version (1.7.0) of the license plugin is out. I prefer to see it updated to that version before reviewing. Let me know if you have a reason to need this version exactly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 --- Comment #2 from Alexander Kurtakov 2010-07-13 03:35:30 EDT --- There is no maven-changes-plugin and the old one maven2-plugin-changes is gone which effectively stops this review until this dependency is fixed somehow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov 2010-07-13 03:14:32 EDT --- I'll take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Alexander Kurtakov changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Bug 590680 depends on bug 590679, which changed state. Bug 590679 Summary: Review Request: xmltool - Tool to manage XML documents through a Fluent Interface https://bugzilla.redhat.com/show_bug.cgi?id=590679 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Bug 590680 depends on bug 588142, which changed state. Bug 588142 Summary: Review Request: maven-release - Release a project updating the POM and tagging in the SCM https://bugzilla.redhat.com/show_bug.cgi?id=588142 What|Old Value |New Value Status|ASSIGNED|NEW Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Guido Grazioli changed: What|Removed |Added Blocks||590681 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590680] Review Request: maven-license-plugin - Maven plugin to update header licenses of source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590680 Guido Grazioli changed: What|Removed |Added Depends on||588142, 590679 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
