[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 Alexander Kurtakov changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #12 from Alexander Kurtakov 2010-05-19 15:34:11 EDT --- Koji build: http://koji.fedoraproject.org/koji/buildinfo?buildID=174105 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Dennis Gilmore 2010-05-18 14:33:00 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 huwang changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 --- Comment #10 from huwang 2010-05-18 11:04:10 EDT --- New Package CVS Request === Package Name: spice-parent Short Description: Sonatype Spice Components Owners: huwang Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 Orcan 'oget' Ogetbil changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Orcan 'oget' Ogetbil 2010-05-18 06:57:36 EDT --- Great, I see that you just got sponsored, so my job is done here. Welcome to Fedora. Please don't forget to do package reviews! --- This package (spice-parent) is APPROVED by oget --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 --- Comment #8 from huwang 2010-05-18 05:52:08 EDT --- (In reply to comment #7) > Thanks, > > However, during reviews (and also after the reviews) when we make changes in > the package, we bump the Release tag and list our changes in the %changelog > with the latest change date. Please include these changes. Fixed. Spec URL: http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=spice-parent.spec&can=2&q=#makechanges SRPM URL: http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=spice-parent-15-2.src.rpm&can=2&q=#makechanges -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 huwang changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 --- Comment #7 from Orcan 'oget' Ogetbil 2010-05-17 06:38:13 EDT --- Thanks, However, during reviews (and also after the reviews) when we make changes in the package, we bump the Release tag and list our changes in the %changelog with the latest change date. Please include these changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 --- Comment #6 from huwang 2010-05-16 21:29:25 EDT --- Spec URL: http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=spice-parent.spec&can=2&q=#makechanges SRPM URL: http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=spice-parent-15-1.src.rpm&can=2&q=#makechanges -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 --- Comment #5 from Orcan 'oget' Ogetbil 2010-05-15 03:20:32 EDT --- @huwang: Thanks, can you upload the new fixed SPEC and SRPM files somewhere, so that we can take a look? @akurtakov: Sure, but it might take a couple days. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #4 from Alexander Kurtakov 2010-05-14 04:27:05 EDT --- Just for reference: https://bugzilla.redhat.com/show_bug.cgi?id=591857 Oget, you may want to take it too? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591454
--- Comment #3 from huwang 2010-05-14 03:37:34 EDT ---
(In reply to comment #2)
> I made a review. Since this is a quite simple package there is just a few
> minor
> things to go over.
>
> * rpmlint says
>spice-parent.src: W: invalid-url Source0: spice-parent-15.tar.gz
>
>We need to specify the sources, especially Source0, with full URL if
> possible. If there is absolutely no way to get a full URL for them, we
> indicate
> this as a comment in the specfile and give the directions to create the source
> (tar)ball.
>Also typically, we use %{name}-%{version} macros in Source0 (and in URL
> in your case). This saves us work when we update the package.
Fixed.
>
>spice-parent.noarch: W: spelling-error Summary(en_US) Sonatype -> Sonatina,
> Sonata, Resonate
>I think this is fine.
>spice-parent.noarch: W: no-documentation
>
>So this package source is one .pom file. That's it? No way to get a
> license file from upstream?
Yes,it is only a pom file. No document available.
>spice-parent.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/spice-parent
>This can be ignored for this package.
>
> ! some suggestions (these are not blockers, take them as you wish):
> 1- In %files, I find it better for legibility to avoid using * if there is
> only
> one
>file.
> 2- Please span the description to 80 columns as much as possible for
> consistency with other packages.
>
> * Latest version should be packaged. There is a spice-parent-16 over there. By
> the way, is there no proper webpage for this where we can track the versions?
>
As plexus-build-api needs this version and plexus-cipher can also build with
this version.
> ? Why are we skipping the mvn-jpp part of the maven guidelines?
>http://fedoraproject.org/wiki/Packaging/Java#maven
It's only a pom file, I think nothing to do for the pom in %build section.
>
> This is it about the package for now. I see that you need to be sponsored.
> Typically in Fedora, we ask the packagers to do some more work to show that
> they are proficient in following the guidelines. This can be done in a couple
> ways: Preferably, you can do some informal reviews on other people's packages.
> Or you can post some other package(s) for review. It would be good to try
> packaging or reviewing some other type of software than single .pom files.
> This
> will help sponsors to understand your proficiency.
I created another package's request. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591454
Orcan 'oget' Ogetbil changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #2 from Orcan 'oget' Ogetbil 2010-05-13
05:14:26 EDT ---
I made a review. Since this is a quite simple package there is just a few minor
things to go over.
* rpmlint says
spice-parent.src: W: invalid-url Source0: spice-parent-15.tar.gz
We need to specify the sources, especially Source0, with full URL if
possible. If there is absolutely no way to get a full URL for them, we indicate
this as a comment in the specfile and give the directions to create the source
(tar)ball.
Also typically, we use %{name}-%{version} macros in Source0 (and in URL
in your case). This saves us work when we update the package.
spice-parent.noarch: W: spelling-error Summary(en_US) Sonatype -> Sonatina,
Sonata, Resonate
I think this is fine.
spice-parent.noarch: W: no-documentation
So this package source is one .pom file. That's it? No way to get a
license file from upstream?
spice-parent.noarch: W: non-conffile-in-etc
/etc/maven/fragments/spice-parent
This can be ignored for this package.
! some suggestions (these are not blockers, take them as you wish):
1- In %files, I find it better for legibility to avoid using * if there is only
one
file.
2- Please span the description to 80 columns as much as possible for
consistency with other packages.
* Latest version should be packaged. There is a spice-parent-16 over there. By
the way, is there no proper webpage for this where we can track the versions?
? Why are we skipping the mvn-jpp part of the maven guidelines?
http://fedoraproject.org/wiki/Packaging/Java#maven
This is it about the package for now. I see that you need to be sponsored.
Typically in Fedora, we ask the packagers to do some more work to show that
they are proficient in following the guidelines. This can be done in a couple
ways: Preferably, you can do some informal reviews on other people's packages.
Or you can post some other package(s) for review. It would be good to try
packaging or reviewing some other type of software than single .pom files. This
will help sponsors to understand your proficiency.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 Orcan 'oget' Ogetbil changed: What|Removed |Added Status|NEW |ASSIGNED CC||oget.fed...@gmail.com AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com --- Comment #1 from Orcan 'oget' Ogetbil 2010-05-13 04:27:23 EDT --- I'll do the review for this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591454] Review Request: spice-parent - Sonatype Spice Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591454 huwang changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
