[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #8 from Alexander Kurtakov akurt...@redhat.com 2010-05-20 08:13:21 EDT --- Koji build: http://koji.fedoraproject.org/koji/buildinfo?buildID=174287 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 huwang huw...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 --- Comment #6 from huwang huw...@redhat.com 2010-05-18 02:52:14 EDT --- New Package CVS Request === Package Name: maven-resources-plugin Short Description: Maven Resources Plugin Owners: huwang Branches: InitialCC: akurtakov,yyang,weli -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Dennis Gilmore den...@ausil.us 2010-05-18 14:25:16 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-05-17 07:52:29 EDT --- I'm taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591857
--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2010-05-17
09:45:27 EDT ---
Review:
OK: rpmlint must be run on every package. OUTPUT:
maven-resources-plugin.noarch: W: no-documentation
maven-resources-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-resources-plugin
maven-resources-plugin.src: W: invalid-url Source0:
maven-resources-plugin-2.2.tar.gz
Not a problem.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. Javadocs
subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other
packages.
OK: All filenames in rpm packages must be valid UTF-8.
One small problem only:
install -pm 644 pom.xml \
%{buildroot}%{_mavenpomdir}/JPP.%{name}.pom
should be
install -pm 644 pom.xml \
%{buildroot}%{_mavenpomdir}/JPP-%{name}.pom
This is needed for proper finding of the pom.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591857
--- Comment #4 from huwang huw...@redhat.com 2010-05-17 11:21:46 EDT ---
(In reply to comment #3)
Review:
OK: rpmlint must be run on every package. OUTPUT:
maven-resources-plugin.noarch: W: no-documentation
maven-resources-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-resources-plugin
maven-resources-plugin.src: W: invalid-url Source0:
maven-resources-plugin-2.2.tar.gz
Not a problem.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any
that
are listed in the exceptions section of the Packaging Guidelines ; inclusion
of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. Javadocs
subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other
packages.
OK: All filenames in rpm packages must be valid UTF-8.
One small problem only:
install -pm 644 pom.xml \
%{buildroot}%{_mavenpomdir}/JPP.%{name}.pom
should be
install -pm 644 pom.xml \
%{buildroot}%{_mavenpomdir}/JPP-%{name}.pom
This is needed for proper finding of the pom.
Fixed.
Spec URL:
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=maven-resources-plugin.speccan=2q=#makechanges
SPRM URL:
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=maven-resources-plugin-2.2-2.src.rpmcan=2q=#makechanges
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2010-05-17 11:33:28 EDT --- Thanks, This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added CC||methe...@gmail.com --- Comment #1 from Rahul Sundaram methe...@gmail.com 2010-05-14 07:00:16 EDT --- Since you are looking for a sponsor, refer to https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591857] Review Request: maven-resources-plugin - Maven Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591857 huwang huw...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
