[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Sebastian Dziallas changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #14 from Sebastian Dziallas 2010-06-23 10:57:18 EDT --- Built in Rawhide and being queued for updates soon. Thanks again! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #13 from Kevin Fenzi 2010-06-22 21:46:40 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Sebastian Dziallas changed: What|Removed |Added Summary|Review Request: jbcrypt - |Review Request: jBCrypt - |Strong password hashing for |Strong password hashing for |Java|Java --- Comment #11 from Sebastian Dziallas 2010-06-22 09:38:54 EDT --- (In reply to comment #10) > Sebastian? I suppose you don't mind the naming that much...so one more release > number with changed name and test run? I can't exactly recall why I used lowercase-only letters in the first place, so yes, I'm more than alright with changing it. It's also compiling the test cases now. :) Spec URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt-0.3-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #12 from Sebastian Dziallas 2010-06-22 09:39:44 EDT --- New Package CVS Request === Package Name: jBCrypt Short Description: Strong password hashing for Java Owners: sdz Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #10 from Stanislav Ochotnicky 2010-06-21 02:38:47 EDT --- (In reply to comment #9) > Shouldn't this be named "jBCrypt" to match the case of the upstream project? > >From packaging guidelines on naming: While case sensitivity is not a mandatory requirement, case should only be used where necessary. Keep in mind to respect the wishes of the upstream maintainers. If they refer to their application as "ORBit", you should use "ORBit" as the package name, and not "orbit". However, if they do not express any preference of case, you should default to lowercase naming. Upstream uses jBCrypt, but I am not sure how much they care about the case. Now that I think about it I am leaning more towards jBCrypt too, but I would leave it up to packager. > Possibly you could run the TestBCrypt in %check section? This is definitely a good idea, should have noticed too. Sebastian? I suppose you don't mind the naming that much...so one more release number with changed name and test run? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #9 from Kevin Fenzi 2010-06-20 22:14:18 EDT --- Shouldn't this be named "jBCrypt" to match the case of the upstream project? Possibly you could run the TestBCrypt in %check section? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Sebastian Dziallas changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Sebastian Dziallas 2010-06-19 11:45:33 EDT --- New Package CVS Request === Package Name: jbcrypt Short Description: Strong password hashing for Java Owners: sdz Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #8 from Sebastian Dziallas 2010-06-19 11:46:16 EDT --- Thanks again for the quick review, this is awesome! :) (mhm, now I'm curious how far we get with etherpad) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #6 from Stanislav Ochotnicky 2010-06-18 02:57:39 EDT --- Just for the record: rpmlint produced no warnings/errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Stanislav Ochotnicky changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Stanislav Ochotnicky 2010-06-18 02:56:09 EDT --- It's your review. You only delayed yourself :-) Package is nice and clean. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #4 from Sebastian Dziallas 2010-06-17 13:50:30 EDT --- Heh, turns out that this was way easier than I expected it to be. Sorry for the delay. Here are the updated files: Spec URL: http://sdz.fedorapeople.org/rpmbuild/jbcrypt.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/jbcrypt-0.3-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #3 from Sebastian Dziallas 2010-06-11 08:48:30 EDT --- I'll do this over the weekend, since I'm travelling right now and will have to get back to my other machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #2 from Sebastian Dziallas 2010-06-09 12:25:42 EDT --- You're obviously right! Fixing that right now. Sorry for that stupid thing and thanks for catching it! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Stanislav Ochotnicky changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|socho...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Stanislav Ochotnicky changed: What|Removed |Added CC||socho...@redhat.com Flag||fedora-review? --- Comment #1 from Stanislav Ochotnicky 2010-06-08 08:05:49 EDT --- I will do the review. Before starting official review though, I have one question: Was it really your intention to package java file inside jar? I assume you meant to package .class file. Please fix this before we go any further (quick rpmlint was clean though) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
