[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG Last Closed|2010-09-29 03:16:04 |2011-08-09 00:55:04 --- Comment #16 from Parag AN(पराग) panem...@gmail.com 2011-08-09 00:55:04 EDT --- Please submit a new review request for this package. This has been stalled since long time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #17 from Ankur Sinha sanjay.an...@gmail.com 2011-08-09 01:18:52 EDT --- Hi Parag, The package has already been approved. Susmit just hasn't gotten commit access yet. Do we need to re-review this package, or can we just request the right people to approve Susmit's commit access? Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #18 from Parag AN(पराग) panem...@gmail.com 2011-08-09 01:32:41 EDT --- ah! SCM already done. See http://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Toshio Ernie Kuratomi a.bad...@gmail.com changed: What|Removed |Added CC||a.bad...@gmail.com --- Comment #19 from Toshio Ernie Kuratomi a.bad...@gmail.com 2011-08-09 01:39:03 EDT --- The packager seems to have several other packager, please start the nonresponsive maintainer process so those get orphaned too. I've approved your acl requests for this package. You can set yourself to be the owner if the owner doesn't appear in a reasonable amount of time. https://admin.fedoraproject.org/pkgdb/users/packages/matriux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #20 from Susmit thinklinux@gmail.com 2011-08-09 01:50:06 EDT --- Imran, are you still interested in this? This is first ping in accordance with Non-responsive Maintainer Policy. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #15 from Pierre-YvesChibon pin...@pingoured.fr 2011-06-27 17:05:12 EDT --- Maybe it is about time to bring this question to the devel mailing-list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Susmit thinklinux@gmail.com changed: What|Removed |Added Blocks||673841(fedora-medical) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Susmit thinklinux@gmail.com changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|NOTABUG | Keywords||Reopened --- Comment #13 from Susmit thinklinux@gmail.com 2010-12-31 13:51:02 EST --- I shall take this. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #14 from Susmit thinklinux@gmail.com 2010-12-31 14:22:48 EST --- I don't have commit access to this. I have submitted a request https://admin.fedoraproject.org/pkgdb/acls/name/openmolar -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG Flag|needinfo?(imran...@gmail.co | |m) | Last Closed||2010-09-29 03:16:04 --- Comment #12 from Parag AN(पराग) panem...@gmail.com 2010-09-29 03:16:04 EDT --- Closing this as no response from submitter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #11 from Parag AN(पराग) panem...@gmail.com 2010-08-05 00:34:00 EDT --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag||needinfo?(imran...@gmail.co ||m) --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2010-06-17 23:20:54 EDT --- Any reason for not building this package yet on koji? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #8 from Mohammed Imran imran...@gmail.com 2010-06-04 05:32:15 EDT --- New Package CVS Request === Package Name: openmolar Short Description: Open Source Dental Practice Management Software Owners: matriux Branches: F-12 F-13 F-14 InitialCC: susmit -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Mohammed Imran imran...@gmail.com changed: What|Removed |Added CC||sgu...@redhat.com --- Comment #7 from Mohammed Imran imran...@gmail.com 2010-06-02 06:48:41 EDT --- Thanks Parag for the review,thanks Chen for the comments. New upstream release,Version:0.2.0 Updated spec is here SPEC : http://github.com/downloads/matriux/fedora/openmolar.spec SRPM : http://github.com/downloads/matriux/fedora/openmolar-0.2.0-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #5 from Chen Lei supercyp...@gmail.com 2010-05-31 02:02:32 EDT --- Some more comments: I think you may need add Scriptlet to spec. https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Hi Parag, 3) Add PKG-INFO to %doc Should python modules include PKG-INFO to %doc? It seems *.egg-info will copy informations from PKG-INFO, I'm not sure about this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 --- Comment #6 from Parag AN(पराग) panem...@gmail.com 2010-05-31 02:35:49 EDT --- Thanks Chen, Ah! howcome my eyes missed this file -rw-r--r--1 rootroot27519 Oct 8 2009 /usr/share/icons/hicolor/scalable/apps/openmolar.svg Definitely this package should add to spec gtk-update-icon-cache scriptlet. I see icon is not appearing in menu. I only tested its functionality using menu. Regarding PKG-INFO:- you are correct egg-info already includes them so no need to add PKG-INFO as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Chen Lei supercyp...@gmail.com changed: What|Removed |Added CC||supercyp...@gmail.com --- Comment #2 from Chen Lei supercyp...@gmail.com 2010-05-30 23:53:51 EDT --- (In reply to comment #0) Spec URL: spec info here SRPM URL: srpm info here Description: description here Rpmlint === rpmlint openmolar.spec ../RPMS/noarch/openmolar-0.1.9-1.fc13.noarch.rpm ../SRPMS/openmolar-0.1.9-1.fc13.src.rpm openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/main.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/settings/_version.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/qt4gui/schema_updater.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/firstRun.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/createdemodatabase.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/qt4gui/customwidgets/calendars.py 0644L /usr/bin/env 2 packages and 1 specfiles checked; 6 errors, 0 warnings. Which can be ignored Normally, you can remove shebang from those files to avoid rpmlint errors. See https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=597755
--- Comment #4 from Parag AN(पराग) panem...@gmail.com 2010-05-31 00:45:21 EDT
---
And If you want to remove shebang which looks not needed, you can use following
in %install
for lib in %{buildroot}%{python_sitelib}/%{name}/*.py
%{buildroot}%{python_sitelib}/%{name}/settings/_version.py
%{buildroot}%{python_sitelib}/%{name}/qt4gui/*.py
%{buildroot}%{python_sitelib}/%{name}/qt4gui/customwidgets/*.py ; do
sed '/\/usr\/bin\/env/d' $lib $lib.new
touch -r $lib $lib.new
mv $lib.new $lib
done
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597755 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review+ --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2010-05-31 00:43:41 EDT --- + is ok - Needs work Review: + package builds in mock (rawhide i686). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=2218732 + rpmlint output for SRPM and for RPM is openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/main.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/settings/_version.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/qt4gui/schema_updater.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/firstRun.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/createdemodatabase.py 0644L /usr/bin/env openmolar.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/openmolar/qt4gui/customwidgets/calendars.py 0644L /usr/bin/env openmolar.noarch: W: no-manual-page-for-binary openmolar Each executable in standard binary directories should have a man page. + source files match upstream url (sha1sum) 27fff756480eb2072543bf80df8ed2b1d717b08c openmolar-0.1.9.tar.gz 27fff756480eb2072543bf80df8ed2b1d717b08c openmolar-0.1.9.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + Translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + GUI application and Desktop file installed correctly. Suggestions: 1) If you want either you can ask upstream to include openmolar man page or you can also write it. This is not blocker for review but just a suggestion. 2) remove following from %build as there is no compilation happenings that need RPM_OPT_FLAGS. CFLAGS=$RPM_OPT_FLAGS 3) Add PKG-INFO to %doc APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
