[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 Yang Yong yy...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #9 from Yang Yong yy...@redhat.com 2010-06-12 06:07:42 EDT --- http://koji.fedoraproject.org/koji/buildinfo?buildID=177853 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-06-11 00:53:15 EDT --- Try now. I think it's complete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #7 from Yang Yong yy...@redhat.com 2010-06-08 07:31:11 EDT --- Hi Kevin, cvs is not done yet after 12 hours passed, may be caused by wrong CC, please create cvs again and leave CC blank, thanks. New Package CVS Request === Package Name: maven-help-plugin Short Description: Plugin to get relative information about a project or the system Owners: yyang Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-06-07 17:27:42 EDT --- cvs done, except liweinan account doesn't exist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 Yang Yong yy...@redhat.com changed: What|Removed |Added Flag||fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2010-06-03 15:58:28 EDT --- yyang, you have to set fedora-cvs to ? not to + -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 Yang Yong yy...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #4 from Yang Yong yy...@redhat.com 2010-06-03 22:26:45 EDT --- akurtako, thanks for your reminder, changed to ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 --- Comment #5 from Yang Yong yy...@redhat.com 2010-06-03 23:08:31 EDT --- New Package CVS Request === Package Name: maven-help-plugin Short Description: Plugin to get relative information about a project or the system Owners: yyang Branches: devel InitialCC: huwang liweinan akurtako dbhole -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598891
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-06-02
10:36:39 EDT ---
Review:
OK: rpmlint must be run on every package. Output:
maven-help-plugin.noarch: W: spelling-error %description -l en_US plugin's -
plug in's, plug-in's, plugging
maven-help-plugin.noarch: W: spelling-error %description -l en_US mojos -
moos, Mojaves, Mojave
maven-help-plugin.noarch: W: no-documentation
maven-help-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-help-plugin
False positives.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other packages.
OK: All filenames in rpm packages must be valid UTF-8.
Btw, there is no need to put both -Dmaven.test.skip=true and
-Dmaven.test.failure.ignore=true . The first one do not run tests at all so the
second has no effect.
Otherwise package looks good.
This package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
