[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 Steve Traylen changed: What|Removed |Added Status|ASSIGNED|NEW CC|steve.tray...@cern.ch | AssignedTo|steve.tray...@cern.ch |nob...@fedoraproject.org Status Whiteboard||StalledSubmitter Flag|fedora-review? | --- Comment #5 from Steve Traylen 2011-11-22 16:16:51 EST --- White boarding as review stalled. Send me a private mail if anything changes. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 --- Comment #4 from Steve Traylen 2011-11-18 18:48:42 EST --- ping. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599414
--- Comment #3 from Steve Traylen 2011-08-08 12:38:13
EDT ---
Package Review
==
arcjobtool: https://bugzilla.redhat.com/show_bug.cgi?id=599414
Monday 8th August 2012
Builds okay in Fedora 16 mock.
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
Yes named as per tar ball.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on:
[x] Rpmlint output:
$ rpmlint ./SPECS/arcjobtool.spec \
./SRPMS/arcjobtool-0.3.0-2.fc15.src.rpm \
./RPMS/noarch/arcjobtool-0.3.0-2.fc15.noarch.rpm
arcjobtool.noarch: W: no-manual-page-for-binary ui-cert-request
arcjobtool.noarch: W: no-manual-page-for-binary arcjobtool
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
In principal not needed unless you target older releases which I am sure
you will.
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
Yes ASL 2.0
[!] License field in the package spec file matches the actual license.
Some of the files in share/arcjobtool/images look to be GPL as well.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
LICENSE file has been included.
[x] Spec file is legible and written in American English.
Except for where it's not meant to be.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
md5um arcjobtool-0.3.0.tar.gz ../SOURCES/arcjobtool-0.3.0.tar.gz
77bd43eb29d983ef2052f52db50fbc96 arcjobtool-0.3.0.tar.gz
77bd43eb29d983ef2052f52db50fbc96 ../SOURCES/arcjobtool-0.3.0.tar.gz
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
Not needed unles targete older builds
[x] Package consistently uses macros.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
Tested on: F16.
[x] Package functions as described.
Certainly the application starts up just fine.
[!] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[x] File based requires are sane.
=== Issues ===
1. share/arcjobtool/images contains some dual licensed and exclusivly
GPL.
2. Your %post, %pre and %posttrans all contain items for
updating desktop database and similar.
From
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
it suggests this is only needed if a Mime type is being added which
does not look to be the case.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 Steve Traylen changed: What|Removed |Added Status|NEW |ASSIGNED CC||steve.tray...@cern.ch AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch Flag||fedora-review? Bug 599414 depends on bug 530684, which changed state. Bug 530684 Summary: Review Request: nordugrid-arc - Advanced Resource Connector Grid Middleware https://bugzilla.redhat.com/show_bug.cgi?id=530684 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 --- Comment #2 from Mattias Ellert 2011-05-15 08:11:06 EDT --- Updated due to changed Requires: Spec URL: http://www.grid.tsl.uu.se/review/arcjobtool.spec SRPM URL: http://www.grid.tsl.uu.se/review/arcjobtool-0.3.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 --- Comment #1 from Mattias Ellert 2010-06-18 08:49:45 EDT --- Updated to final version 0.3.0: Spec URL: http://www.grid.tsl.uu.se/review/arcjobtool.spec SRPM URL: http://www.grid.tsl.uu.se/review/arcjobtool-0.3.0-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 Mattias Ellert changed: What|Removed |Added Depends on||530684 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
