[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-06-23 13:42:20 EDT --- gnome-js-common-0.1.2-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||gnome-js-common-0.1.2-3.fc1 ||3 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-19 11:19:09 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-06-17 18:33:34 EDT --- gnome-js-common-0.1.2-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gnome-js-common-0.1.2-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-06-14 00:45:19 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600637
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-12
13:37:41 EDT ---
1 comment and 1 issue
! BuildRoot tag is also no longer needed (since Fedora 10)
* Please don't use %{minor_ver} macro in %changelog. This will
break things silently if you upgrade the version.
Please fix the issue above (at least for macros in %changelog)
before importing this package into Fedora.
---
This package (gnome-js-common) is APPROVED by mtasaka
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600637
Michel Alexandre Salim michael.silva...@gmail.com changed:
What|Removed |Added
Flag||fedora-cvs?
--- Comment #5 from Michel Alexandre Salim michael.silva...@gmail.com
2010-06-12 16:06:00 EDT ---
Thanks; duly noted. The changelog is auto-generated from Emacs' rpm mode; I'll
probably drop it. Odd that Emacs properly expand %{major_ver} though!
New Package CVS Request
===
Package Name: gnome-js-common
Short Description: Common modules for GNOME JavaScript interpreters
Owners: salimma
Branches: F-13
InitialCC:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600637
--- Comment #2 from Michel Alexandre Salim michael.silva...@gmail.com
2010-06-11 04:57:09 EDT ---
Thanks for the comments!
--libdir=%{_datadir} sounds like a good idea. I was worried about pkgconfig
files, having only seen them deposited in %{_libdir}/pkgconfig before, but
you're of course right.
Will fix the timestamp too.
I'm currently at work, but I'll get the updated package later today.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 --- Comment #3 from Michel Alexandre Salim michael.silva...@gmail.com 2010-06-11 18:10:39 EDT --- Package updated: Spec URL: http://salimma.fedorapeople.org/specs/gnome/gnome-js-common.spec SRPM URL: http://salimma.fedorapeople.org/specs/gnome/gnome-js-common-0.1.2-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600637
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-10
16:58:39 EDT ---
Well, as some Japanese people said that it was said that
his favorite Same Gnome disappeared, I will review this...
Simple package. Some notes
* noarch handling
%patch1 -p1 -b .license
%build
# not using standard configure macro. Nothing is compiled,
# only prefix needed
./configure --prefix %{_prefix}
- Why don't you just use the following?
%configure --libdir=%{_datadir}
* Timestamps
- Trying to keep timestamps on installed files is appreciated
especially because this is based on recent autotools method
and this is noarch. Please consider to use below:
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
* Cleanups
- rpmlint may complain, however:
* On Fedora BuildRoot tag is no longer used:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* On Fedora 13+, %clean is not needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
And I guess you need this package only for F-13+.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 Michel Alexandre Salim michael.silva...@gmail.com changed: What|Removed |Added Blocks||600638 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
