[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
https://bugzilla.redhat.com/show_bug.cgi?id=605290 Björn "besser82" Esser changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=605290 Simon Green changed: What|Removed |Added CC||an...@redhat.com Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dOSZGh9MNo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
https://bugzilla.redhat.com/show_bug.cgi?id=605290 Kalev Lember changed: What|Removed |Added CC||kalevlem...@gmail.com Resolution|NOTABUG |DUPLICATE --- Comment #10 from Kalev Lember --- *** This bug has been marked as a duplicate of bug 840239 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
https://bugzilla.redhat.com/show_bug.cgi?id=605290 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Whiteboard|AwaitingSubmitter | Last Closed||2012-06-15 15:41:11 --- Comment #9 from Jason Tibbitts --- No response; after another coupe of months; closing. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 Jason Tibbitts changed: What|Removed |Added CC|fedora-package-review@redha |package-review@lists.fedora |t.com |project.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 --- Comment #7 from Mario Santagiuliana 2012-01-12 08:22:18 EST --- Could you write the BuildRequires and Requires packages on multiple lines? Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=605290
Mario Santagiuliana changed:
What|Removed |Added
CC||fed...@marionline.it
--- Comment #6 from Mario Santagiuliana 2012-01-12
08:12:16 EST ---
I am still learning how to became a reviewer so I just give you an unofficial
review.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files -f %{name}.lang section. This is OK
if packaging for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[?]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
[x]: MUST The spec file handles locales properly.
[?]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[?]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[?]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[?]: MUST Package does not own files or directories owned by other packages.
[?]: MUST Package installs properly.
[-]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint transmageddon-0.16-2.fc17.noarch.rpm
transmageddon.noarch: W: spelling-error Summary(en_US) transcoder -> trans
coder, trans-coder, transponder
transmageddon.noarch: W: spelling-error %description -l en_US transcoder ->
trans coder, trans-coder, transponder
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint transmageddon-0.16-2.fc17.src.rpm
transmageddon.src: W: spelling-error Summary(en_US) transcoder -> trans coder,
trans-coder, transponder
transmageddon.src: W: spelling-error %description -l en_US transcoder -> trans
coder, trans-coder, transponder
transmageddon.src:38: W: macro-in-comment %{buildroot}
transmageddon.src:38: W: macro-in-comment %{_bindir}
transmageddon.src:39: W: macro-in-comment %{buildroot}
transmageddon.src:39: W: macro-in-comment %{_datadir}
transmageddon.src:40: W: macro-in-comment %{buildroot}
transmageddon.src:40: W: macro-in-comment %{_datadir}
transmageddon.src:41: W: macro-in-comment %{buildroot}
transmageddon.src:41: W: macro-in-comment %{_datadir}
transmageddon.src:42: W: macro-in-comment %{buildroot}
transmageddon.src:42: W: macro-in-comment %{_datadir}
transmageddon.src:43: W: macro-in-comment %{buildroot}
transmageddon.src:43: W: macro-in-comment %{_datadir}
transmageddon.src:44: W: macro-in-comment %{buildroot}
transmageddon.src:44: W: macro-in-comment %{_datadir}
transmageddon.src:44: W: macro-in-comment %{name}
transmageddon.src:45: W: macro-in-comment %{buildroot}
transmageddon.src:45: W: macro-in-comment %{_datadir}
transmageddon.src:45: W: macro-in-comment %{name}
transmageddon.src:46: W: macro-in-comment %{buildroot}
transmageddon.src:46: W: macro-in-comment %{_mandir}
transmage
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 Aidan Delaney changed: What|Removed |Added CC||a.j.dela...@brighton.ac.uk --- Comment #5 from Aidan Delaney 2011-04-03 09:21:30 EDT --- This .spec works well in Fedora 15. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 --- Comment #4 from Runa Bhattacharjee 2010-08-11 08:59:01 EDT --- Hello, I rewrote the .spec file and generated a new SRPM: http://runab.fedorapeople.org/packages/transmageddon/0.16-2/ rpmlint output: transmageddon.noarch: W: spelling-error Summary(en_US) transcoder -> trans coder, trans-coder, transcendent transmageddon.noarch: W: spelling-error %description -l en_US transcoder -> trans coder, trans-coder, transcendent 1 packages and 0 specfiles checked; 0 errors, 2 warnings. A patch had to be written for the .desktop file, to fix the issues related to the deprecated key values. The patch and the traceback errors have been reported upstream: https://bugzilla.gnome.org/show_bug.cgi?id=626626 Thanks Runa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 Hicham HAOUARI changed: What|Removed |Added CC||hicham.haou...@gmail.com --- Comment #3 from Hicham HAOUARI 2010-07-15 22:54:13 EDT --- you are missing important BR : pygtk2 gstreamer-python, also please try a build on koji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 Parag AN(पराग) changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=605290
Thomas Spura changed:
What|Removed |Added
CC||toms...@fedoraproject.org
--- Comment #2 from Thomas Spura 2010-06-18
09:38:46 EDT ---
Hmm, I tried to transcode a random movie file into webm and this is the crash:
Traceback (most recent call last):
File "transmageddon.py", line 676, in on_presetchoice_changed
self.devicename= self.presetchoices[presetchoice]
KeyError: 'Keine Voreinstellungen'
Traceback (most recent call last):
File "transmageddon.py", line 624, in on_transcodebutton_clicked
self._start_transcoding()
File "transmageddon.py", line 516, in _start_transcoding
audiocodec, videocodec, self.devicename,
AttributeError: TransmageddonUI instance has no attribute 'devicename'
When clicking on 'cancel' again:
Traceback (most recent call last):
File "transmageddon.py", line 636, in on_cancelbutton_clicked
self._cancel_encoding =
transcoder_engine.Transcoder.Pipeline(self._transcoder,"null")
AttributeError: TransmageddonUI instance has no attribute '_transcoder'
Besides that:
The 'mkdir -p's are not needed, a snipped from rpmbuild output:
test -z "/usr/share/applications" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/applications"
/usr/bin/install -c -m 644 transmageddon.desktop
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/applications'
test -z "/usr/share/pixmaps" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/pixmaps"
/usr/bin/install -c -m 644 transmageddon.svg
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/pixmaps'
test -z "/usr/share/man/man1" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/man/man1"
/usr/bin/install -c -m 644 transmageddon.1
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/man/man1'
test -z "/usr/share/transmageddon" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/transmageddon"
That's done by the Makefile itself.
Another warning:
/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64//usr/share/applications/transmageddon.desktop:
warning: key "Encoding" in group "Desktop Entry" is deprecated
/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64//usr/share/applications/transmageddon.desktop:
warning: value "GNOME;GTK;Application;AudioVideo;X-Ximian-Main;X-Red-Hat-Base;"
for key "Categories" in group "Desktop Entry" contains a deprecated value
"Application"
- Don't mix RPM_BUILD_ROOT and buildir.
See
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- You write %{buildroot}/%{_datadir}: %{_datadir} already contains an '/' at
the beginning.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Alias||transmageddon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605290 --- Comment #1 from Parag AN(पराग) 2010-06-17 11:58:19 EDT --- *** Bug 605295 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
