[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE --- Comment #11 from Iain Arnell iarn...@gmail.com 2010-08-05 23:17:38 EDT --- These got pushed to stable, but bodhi seems to have forgotten to inform bugzilla. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-07-13 16:40:29 EDT --- perl-Data-Serializer-0.49-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Data-Serializer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Data-Serializer-0.49-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-07-13 16:44:38 EDT --- perl-Data-Serializer-0.49-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Data-Serializer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Data-Serializer-0.49-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 --- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-07-12 13:22:24 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-07-12 23:18:54 EDT --- perl-Data-Serializer-0.49-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Data-Serializer-0.49-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-07-12 23:18:59 EDT --- perl-Data-Serializer-0.49-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Data-Serializer-0.49-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Iain Arnell iarn...@gmail.com 2010-07-12 23:18:08 EDT --- Thanks for the review. Permissions fixed and committed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 Emmanuel Seyman emmanuel.sey...@club-internet.fr changed: What|Removed |Added Status|NEW |ASSIGNED CC||emmanuel.sey...@club-intern ||et.fr AssignedTo|nob...@fedoraproject.org|emmanuel.sey...@club-intern ||et.fr Flag||fedora-review? --- Comment #1 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 2010-07-11 02:08:57 EDT --- Taking. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608447
Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr
2010-07-11 02:28:49 EDT ---
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2310626
[x] Rpmlint output:
perl-Data-Serializer.noarch: E: script-without-shebang
/usr/share/perl5/Data/Serializer.pm
perl-Data-Serializer.noarch: E: script-without-shebang
/usr/share/perl5/Data/Serializer/Cookbook.pm
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
31a8c3f5ab573a840b4314d327bc534a Data-Serializer-0.49.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[!] Permissions on files are set properly.
/usr/share/perl5/Data/Serializer/Cookbook.pm and
/usr/share/perl5/Data/Serializer.pm
are chmod 755.They should be chmod 644.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: rawhide.x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: rawhide.x86_64
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
All tests successful.
Files=28, Tests=2982, 7 wallclock secs ( 0.31 usr 0.03 sys + 6.05 cusr 0.94
csys = 7.33 CPU)
Result: PASS
APPROVED.
Ian, please change the file permissions on Data/Serializer.pm and
Data/Serializer/Cookbook.pm before check-in.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 --- Comment #3 from Iain Arnell iarn...@gmail.com 2010-07-11 03:30:17 EDT --- New Package CVS Request === Package Name: perl-Data-Serializer Short Description: Modules that serialize data structures Owners: iarnell Branches: F-11 F-12 F-13 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608447] Review Request: perl-Data-Serializer - Modules that serialize data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608447 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Iain Arnell iarn...@gmail.com 2010-07-11 03:36:29 EDT --- Oops. Ignore previous comment - should be F-12 F-13 branches only, of course. New Package CVS Request === Package Name: perl-Data-Serializer Short Description: Modules that serialize data structures Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
