[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 Emmanuel Seyman emmanuel.sey...@club-internet.fr changed: What|Removed |Added Status|NEW |CLOSED CC||emmanuel.seyman@club-intern ||et.fr Resolution||CURRENTRELEASE Last Closed||2011-08-11 09:21:18 --- Comment #15 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 2011-08-11 09:21:18 EDT --- This looks fixed (the module has been build and released). Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 Jérôme Fenal jfe...@free.fr changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Jérôme Fenal jfe...@free.fr 2010-10-09 06:11:36 EDT --- New Package SCM Request === Package Name: perl-Test-Script-Run Short Description: Test the script with run Owners: jfenal Branches: el5 el6 f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2010-10-10 00:22:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #12 from Jérôme Fenal jfe...@free.fr 2010-09-21 17:02:26 EDT --- Hi, any remaining task I need to take care of, before going on on this request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #10 from Remi Collet fed...@famillecollet.com 2010-07-23 03:09:38 EDT --- Jérôme : you must be in the packager group to change this flag. Before adding you to this group I'm waiting for - your FAS account - a test review (as discussed) Remi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #11 from Jérôme Fenal jfe...@free.fr 2010-07-23 07:33:46 EDT --- Remi, Sorry for the confusion, here they are (also sent in private) : - FAS : jfenal - Test review : https://bugzilla.redhat.com/show_bug.cgi?id=597700#c3 Regards, J. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #9 from Jérôme Fenal jfe...@free.fr 2010-07-21 15:52:54 EDT --- Hi all, anything I can do in order to be able to set fedora-cvs=? flag ? Thanks, J. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #7 from Jérôme Fenal jfe...@free.fr 2010-07-13 16:29:12 EDT --- Applied Requires changes. http://github.com/jfenal/perl-Test-Script-Run/raw/master/perl-Test-Script-Run.spec http://github.com/downloads/jfenal/perl-Test-Script-Run/perl-Test-Script-Run-0.04-4.fc13.noarch.rpm http://github.com/downloads/jfenal/perl-Test-Script-Run/perl-Test-Script-Run-0.04-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Remi Collet fed...@famillecollet.com 2010-07-14 01:14:10 EDT --- All MUST fixed *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608470
--- Comment #6 from Remi Collet fed...@famillecollet.com 2010-07-12 03:32:08
EDT ---
=== FORMAL REVIEW ===
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2312420
[x] Rpmlint output:
perl-Test-Script-Run.src: I: checking
perl-Test-Script-Run.src: I: checking-url
http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds)
perl-Test-Script-Run.src: I: checking-url
http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz
(timeout 10 seconds)
perl-Test-Script-Run.noarch: I: checking
perl-Test-Script-Run.noarch: I: checking-url
http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds)
perl-Test-Script-Run.spec: I: checking-url
http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
ed398196b5ce6496e70bd9c5ada8d9e4 Test-Script-Run-0.04.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
= perl exception for %{perl_vendorlib}/Test
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: fedora-12-x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on (dist-f14):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2312420
[-] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -e test_harness(0,
'inc', 'blib/lib', 'blib/arch') t/00.load.t t/01.run.t
t/00.load.t .. 1/1 # Testing Test::Script::Run 0.04
t/00.load.t .. ok
t/01.run.t ... couldn't find the script at
/home/extras/BUILD/Test-Script-Run-0.04/blib/lib/Test/Script/Run.pm line 188.
t/01.run.t ... 1/38 couldn't find the script at
/home/extras/BUILD/Test-Script-Run-0.04/blib/lib/Test/Script/Run.pm line 188,
$fh line 5.
t/01.run.t ... ok
All tests successful.
Files=2, Tests=39, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.15 cusr 0.06
csys = 0.24 CPU)
Result: PASS
[!] Final requires
perl(IPC::Run3)
perl(Test::Exception)
perl(:MODULE_COMPAT_5.10.1)
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608470
--- Comment #4 from Remi Collet fed...@famillecollet.com 2010-07-11 11:45:09
EDT ---
%{perl_vendorlib}/Test/Script/Run.pm
With this line, you only own then .pm file.
According to Guidelines A package must own all directories that it creates
So you must own test and script folder.
Simple way:
%{perl_vendorlib}/Test
Very descriptive way:
%dir %{perl_vendorlib}/Test
%dir %{perl_vendorlib}/Test/Script
%{perl_vendorlib}/Test/Script/Run.pm
Everything else seems ok.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 Remi Collet fed...@famillecollet.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #5 from Jérôme Fenal jfe...@free.fr 2010-07-11 14:54:28 EDT --- All comments applied : http://github.com/jfenal/perl-Test-Script-Run/raw/master/perl-Test-Script-Run.spec http://github.com/downloads/jfenal/perl-Test-Script-Run/perl-Test-Script-Run-0.04-3.fc13.src.rpm http://github.com/downloads/jfenal/perl-Test-Script-Run/perl-Test-Script-Run-0.04-3.fc13.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #3 from Jérôme Fenal jfe...@free.fr 2010-07-05 14:43:36 EDT --- Oh, and for EPEL, yes, this can't work as IPC::Run3 is not yet pushed from Fedora to EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608470
--- Comment #2 from Jérôme Fenal jfe...@free.fr 2010-07-05 14:42:26 EDT ---
Now tracking changes with git at http://github.com/jfenal/perl-Test-Script-Run.
Followed all recommandations:
- release naming
- file globbing
- DESTDIR
- %{?perl_default_filter}
$ rpmlint ~/rpm/RPMS/noarch/perl-Test-Script-Run-0.04-2.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ~/rpm/SRPMS/perl-Test-Script-Run-0.04-2.fc13.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Packages spec available at
- http://jfenal.free.fr/rpm/perl-Test-Script-Run.spec
- http://jfenal.free.fr/rpm/perl-Test-Script-Run-0.04-2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608470
--- Comment #1 from Remi Collet fed...@famillecollet.com 2010-07-03 03:07:18
EDT ---
Quick notes (not yet a review)
Release must be fixed 1%{?dist}
(set %dist .fc13 in your .rpmmacros)
$ rpmlint -v perl-Test-Script-Run.spec
/home/extras/SRPMS/perl-Test-Script-Run-0.04-1.fc8.src.rpm
/home/extras/RPMS/noarch/perl-Test-Script-Run-0.04-1.fc8.noarch.rpm
perl-Test-Script-Run.spec: I: checking-url
http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz
(timeout 10 seconds)
perl-Test-Script-Run.src: I: checking
perl-Test-Script-Run.src: I: checking-url
http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds)
perl-Test-Script-Run.src: I: checking-url
http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz
(timeout 10 seconds)
perl-Test-Script-Run.noarch: I: checking
perl-Test-Script-Run.noarch: I: checking-url
http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
= ok
Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given
the recent fun along those lines :)
Think about including %{?perl_default_filter} by default, even if just pro
forma. It won't hurt anything and might save some pain down the line.
I hate too wide wildcard in %file, so a more precise could be
%{perl_vendorlib}/Test
%{_mandir}/man3/Test*
N.B. /usr/share/perl5/Test is already owned by perl-Test-Exception (which is
required), so you don't need to own it (Guidelines says MUST: Packages must
not own files or directories already owned by other packages.), but this is F
= 13 specific. F = 12 use /usr/lib/perl5/vendor_perl/5.10.0/Test which must
be owned.
Mock for EL-5 enter a infinite root.
Sorry! since you don't have any existing picks, you must make a
geographic selection.
(1) Africa
(2) Asia
(3) Australasia
(4) Central America
(5) Europe
(6) North America
(7) Oceania
(8) South America
Select your continent (or several nearby continents) []
Probably because
DEBUG util.py:255: Aucun paquet trouvé pour perl(IPC::Run3)
Mock for F-13 is ok.
Koji scratch buld for rawhide (perl 5.12.1) is ok
http://koji.fedoraproject.org/koji/taskinfo?taskID=2291633
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608470] Review Request: perl-Test-Script-Run - Test scripts with Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 Emmanuel Seyman emmanuel.sey...@club-internet.fr changed: What|Removed |Added CC||emmanuel.sey...@club-intern ||et.fr Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
