[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #17 from Fedora Update System 2011-01-13 18:27:38 EST --- kpassgen-1.3-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||kpassgen-1.3-1.fc14 Resolution||ERRATA Last Closed|2010-09-09 10:51:40 |2011-01-13 18:27:44 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #16 from Fedora Update System 2011-01-07 01:44:10 EST --- kpassgen-1.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kpassgen-1.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #15 from Jason Tibbitts 2011-01-03 10:15:17 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #14 from Siddharth Sharma 2011-01-03 04:00:14 EST --- New Package SCM Request === Package Name: kpassgen Short Description: Random password creator Owners: siddharths Branches: f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Siddharth Sharma changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #13 from Siddharth Sharma 2011-01-03 02:28:35 EST --- New Package SCM Request === Package Name: kpassgen Short Description: Random password creator Owners: siddharths Branches: f14 FAS: siddharths -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #12 from Kevin Fenzi 2011-01-02 15:10:53 EST --- We can only act on Fedora Account System accounts, not email addresses. Can you update your request to use FAS names instead of emails in the CC field? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #11 from Siddharth Sharma 2011-01-01 07:48:53 EST --- New Package SCM Request === Package Name: kpassgen Short Description: Random password creator Owners: siddharths Branches: f14 InitialCC: magnus.tuomi...@gmail.com, ka...@smartlink.ee -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Siddharth Sharma changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Magnus Tuominen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Magnus Tuominen 2010-12-23 11:56:48 EST --- All issues fixed. Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #9 from Siddharth Sharma 2010-12-23 11:31:00 EST --- Spec URL: http://siddharths.fedorapeople.org/SPECS/kpassgen.spec SRPM URL: http://siddharths.fedorapeople.org/SRPMS/kpassgen-1.3-1.fc14.src.rpm Description: Random password creater -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #8 from Siddharth Sharma 2010-12-23 11:24:10 EST --- Thanks alot Magnus :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609638
--- Comment #7 from Magnus Tuominen 2010-12-22
14:23:57 EST ---
Just noticed something I missed:
Release: should be 1%{dist} and not 1.3%{dist}
Same goes for the changelog entry.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609638
--- Comment #6 from Magnus Tuominen 2010-12-22
14:19:29 EST ---
review done on the following:
http://siddharths.fedorapeople.org/SPECS/kpassgen.spec
http://siddharths.fedorapeople.org/SRPMS/kpassgen-1.3-1.3.fc14.src.rpm
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
- rpmlint -iv kpassgen.spec
kpassgen.spec: I: checking-url
http://kde-apps.org/content/show.php/kpassgen-1.3.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
- rpmlint -iv kpassgen-1.3-1.3.fc14.src.rpm
kpassgen.src: I: checking
kpassgen.src: I: checking-url
http://kde-apps.org/content/show.php/KPassGen?content=108673 (timeout 10
seconds)
kpassgen.src: I: checking-url
http://kde-apps.org/content/show.php/kpassgen-1.3.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- Ok
MUST: The package must be named according to the Package Naming Guidelines .
- Ok
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
- Ok
MUST: The package must meet the Packaging Guidelines .
- Ok
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
- GPLv2, Ok
MUST: The License field in the package spec file must match the actual license.
- Ok
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
- Ok
MUST: The spec file must be written in American English.
- Ok
MUST: The spec file for the package MUST be legible.
- Ok
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
src.rpm: 7c9f5ba8fb06ca79e2c7ad8ef268b271
upstream: 150e74a68c5292e2e0c5630b9babae3c
- NOT ok, check upstream source location.
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
- Ok f14-x86_64
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
- Ok
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
- Ok
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
- Ok
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
- Ok
MUST: Packages must NOT bundle copies of system libraries.[11]
- Ok
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
- Ok
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
- Ok
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
- Ok
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
- Ok
MUST: Each package must consistently use macros.
- Ok
MUST: The package must contain code, or permissable content.
- Ok
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
- Ok
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
- Ok
MUST: Header files must be in a -devel package.
- Ok
MUST: Static libraries must be in a -static package.
- Ok
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Magnus Tuominen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Siddharth Sharma changed: What|Removed |Added Flag|fedora-review?, needinfo-, | |needinfo-, fedora-cvs- | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #5 from Magnus Tuominen 2010-09-11 15:06:15 EDT --- Please update this to the latest release (1.1) and I will do the review for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Magnus Tuominen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Magnus Tuominen changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||magnus.tuomi...@gmail.com Resolution|WORKSFORME | AssignedTo|nob...@fedoraproject.org|magnus.tuomi...@gmail.com Keywords||Reopened --- Comment #4 from Magnus Tuominen 2010-09-09 11:01:45 EDT --- I'll take it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #3 from Siddharth Sharma 2010-09-09 10:54:04 EDT --- Please review spec again if needed though i fixed everything i guess but still if something is left i will do -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Siddharth Sharma changed: What|Removed |Added Status|NEW |CLOSED Resolution||WORKSFORME Last Closed||2010-09-09 10:51:40 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Siddharth Sharma changed: What|Removed |Added Priority|medium |low Flag|needinfo?(siddharth@gma |needinfo-, needinfo-, |il.com) |fedora-cvs- Severity|medium |low -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Jason Tibbitts changed: What|Removed |Added Flag||needinfo?(siddharth@gma ||il.com) --- Comment #2 from Jason Tibbitts 2010-09-01 11:15:57 EDT --- Almost two months with no response to the above review commentary; this will be closed soon if the situation continues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Kalev Lember changed: What|Removed |Added CC||ka...@smartlink.ee --- Comment #1 from Kalev Lember 2010-07-02 13:03:42 EDT --- It appears that you have modified the spec file after initial submission. If you do that, please bump the Release, update %changelog and post new links to spec and srpm in this ticket. > Group: Utilities Use one of groups from /usr/share/doc/rpm-*/GROUPS file instead; Utilities isn't a standard rpm group. > License: GNU Refer to http://fedoraproject.org/wiki/Licensing page to figure out what to put in the License tag. > %description > A random password creator Perhaps you can be a bit more verbose? There's a nice description at http://kde-apps.org/content/show.php/KPassGen?content=108673 , use that. You need to use either desktop-file-install or desktop-file-validate as per https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage %doc is currently empty. KPassgen has COPYING file in the tarball and you need to include that in the rpm too: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
