[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
https://bugzilla.redhat.com/show_bug.cgi?id=609738 Jiri Kastner changed: What|Removed |Added CC||jkast...@redhat.com --- Comment #17 from Jiri Kastner --- Package Change Request == Package Name: shiboken New Branches: epel7 Owners: than jreznik ltinkl kkofler geertj rdieter -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #14 from Fedora Update System 2010-08-02 21:12:31 EDT --- shiboken-0.3.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #13 from Fedora Update System 2010-07-26 19:14:39 EDT --- shiboken-0.3.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/shiboken-0.3.2-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Kalev Lember changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||shiboken-0.3.2-4.fc14 Resolution||NEXTRELEASE --- Comment #12 from Kalev Lember 2010-07-26 19:12:54 EDT --- Imported and built, closing the ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #11 from Kevin Fenzi 2010-07-26 18:31:54 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Kalev Lember changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Kalev Lember 2010-07-24 11:14:21 EDT --- New Package CVS Request === Package Name: shiboken Short Description: CPython bindings generator for C++ libraries Owners: kalev rdieter kkofler than ltinkl Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #9 from Kalev Lember 2010-07-24 11:12:42 EDT --- Thanks a lot for the review, Magnus. Let me know if you need anything reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Magnus Tuominen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Magnus Tuominen 2010-07-24 11:09:45 EDT --- OK, I'm happy with that, approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609738
--- Comment #7 from Kalev Lember 2010-07-24 10:57:25 EDT
---
(In reply to comment #6)
> shiboken-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libshiboken.so.0.3.2
> e...@glibc_2.2.5
> This library package calls exit() or _exit(), probably in a non-fork()
> context. Doing so from a library is strongly discouraged - when a library
> function calls exit(), it prevents the calling program from handling the
> error, reporting it to the user, closing files properly, and cleaning up any
> state that the program has. It is preferred for the library to return an
> actual error code and let the calling program decide how to handle the
> situation.
>
> 5 packages and 0 specfiles checked; 0 errors, 10 warnings.
>
> Spelling errors can be ignored.
> Not shure what to make of shared-lib-calls-exit, but it doesn't look good.
I suspect rpmlint is just being stupid. libshiboken/typeresolver.cpp:70
contains the following line which probably triggers the rpmlint error:
std::atexit(deinitTypeResolver);
This is something all together different than calling exit() directly.
> in %files
> %{_libdir}/generatorrunner/* <-- add generatorrunner as R
generatorrunner is already an implicit dependency:
$ rpm -q --requires shiboken | grep gen
libgenrunner.so.0.5
$ rpm -qf /usr/lib/libgenrunner.so.0.5
generatorrunner-0.5.0-2.fc14.i686
But yeah, I guess it's cleaner to also explicitly list generatorrunner dep.
> ? SHOULD: Usually, subpackages other than devel should require the base
> package
> using a fully versioned dependency.
>
> Add Requires: %{name} = %{version}-%{release} to %package libs
No, it's the other way around in here: the main package has
Requires: %{name}-libs = %{version}-%{release}
The reason why libs are in a separate package is to avoid pulling in the whole
shiboken main package (plus its long dep chain) for libraries which link
against libshiboken; requiring main package from libs package would make the
split meaningless.
* Sat Jul 24 2010 Kalev Lember - 0.3.2-4
- Explicitly require generatorrunner for %%{_libdir}/generatorrunner/ directory
ownership (#609738)
Spec URL: http://kalev.fedorapeople.org/shiboken.spec
SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-4.fc14.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348167
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609738
--- Comment #6 from Magnus Tuominen 2010-07-24
10:24:10 EDT ---
Shiboken Review
? MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -iv /var/lib/mock/fedora-13-x86_64/result/shiboken-*.rpm
shiboken.src: I: checking
shiboken.src: W: spelling-error Summary(en_US) CPython -> C Python, Python,
Brython
The value of this tag appears to be misspelled. Please double-check.
shiboken.src: W: spelling-error %description -l en_US generatorrunner ->
generator runner, generator-runner, generator
The value of this tag appears to be misspelled. Please double-check.
shiboken.src: W: spelling-error %description -l en_US apiextractor ->
extractor, fluidextract, extraction
The value of this tag appears to be misspelled. Please double-check.
shiboken.src: I: checking-url http://www.pyside.org (timeout 10 seconds)
shiboken.src: I: checking-url
http://www.pyside.org/files/shiboken-0.3.2.tar.bz2 (timeout 10 seconds)
shiboken.x86_64: I: checking
shiboken.x86_64: W: spelling-error Summary(en_US) CPython -> C Python, Python,
Brython
The value of this tag appears to be misspelled. Please double-check.
shiboken.x86_64: W: spelling-error %description -l en_US apiextractor ->
extractor, fluidextract, extraction
The value of this tag appears to be misspelled. Please double-check.
shiboken.x86_64: I: checking-url http://www.pyside.org (timeout 10 seconds)
shiboken.x86_64: W: no-manual-page-for-binary shiboken
Each executable in standard binary directories should have a man page.
shiboken-debuginfo.x86_64: I: checking
shiboken-debuginfo.x86_64: I: checking-url http://www.pyside.org (timeout 10
seconds)
shiboken-devel.x86_64: I: checking
shiboken-devel.x86_64: I: checking-url http://www.pyside.org (timeout 10
seconds)
shiboken-libs.x86_64: I: checking
shiboken-libs.x86_64: W: spelling-error Summary(en_US) CPython -> C Python,
Python, Brython
The value of this tag appears to be misspelled. Please double-check.
shiboken-libs.x86_64: W: spelling-error %description -l en_US generatorrunner
-> generator runner, generator-runner, generator
The value of this tag appears to be misspelled. Please double-check.
shiboken-libs.x86_64: W: spelling-error %description -l en_US apiextractor ->
extractor, fluidextract, extraction
The value of this tag appears to be misspelled. Please double-check.
shiboken-libs.x86_64: I: checking-url http://www.pyside.org (timeout 10
seconds)
shiboken-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libshiboken.so.0.3.2
e...@glibc_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
5 packages and 0 specfiles checked; 0 errors, 10 warnings.
Spelling errors can be ignored.
Not shure what to make of shared-lib-calls-exit, but it doesn't look good.
+ MUST: The package must be named according to the Package Naming Guidelines.
+ MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
+ MUST: The package must meet the Packaging Guidelines.
+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
+ MUST: The License field in the package spec file must match the actual
license.
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ MUST: The spec file must be written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
upstream: 802ecf28206aa17a9e3d64bf736c6470
src.rpm: 802ecf28206aa17a9e3d64bf736c6470
+ MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
+ MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
+ MUST: All build dependencies must be listed in
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Kalev Lember changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Kalev Lember 2010-07-24 09:14:32 EDT --- * Sat Jul 24 2010 Kalev Lember - 0.3.2-3 - Require python2-devel in devel package as the public headers include Python.h Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-3.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348060 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #4 from Kalev Lember 2010-07-24 09:06:03 EDT --- * Sat Jul 24 2010 Kalev Lember - 0.3.2-2 - BR sparsehash-devel instead of sparsehash Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-2.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348050 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Magnus Tuominen changed: What|Removed |Added Flag||fedora-review? --- Comment #3 from Magnus Tuominen 2010-07-24 08:50:31 EDT --- (In reply to comment #2) > (In reply to comment #1) > > BR: should state > > shiboken-devel instead of shiboken. sorry, sparsehash-devel instead of sparsehash. Wanted: edit function to comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #2 from Magnus Tuominen 2010-07-24 08:49:05 EDT --- (In reply to comment #1) > BR: should state shiboken-devel instead of shiboken. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Magnus Tuominen changed: What|Removed |Added CC||magnus.tuomi...@gmail.com AssignedTo|nob...@fedoraproject.org|magnus.tuomi...@gmail.com --- Comment #1 from Magnus Tuominen 2010-07-24 08:48:29 EDT --- BR: should state -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Kalev Lember changed: What|Removed |Added AssignedTo|thom...@fedoraproject.org |nob...@fedoraproject.org Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Chen Lei changed: What|Removed |Added CC||supercyp...@gmail.com Bug 609738 depends on bug 604695, which changed state. Bug 604695 Summary: Review Request: generatorrunner - Plugin-based application to run apiextractor-based generators https://bugzilla.redhat.com/show_bug.cgi?id=604695 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Thomas Janssen changed: What|Removed |Added CC||thom...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|thom...@fedoraproject.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Bug 609738 depends on bug 609728, which changed state. Bug 609728 Summary: Review Request: sparsehash - Extremely memory-efficient C++ hash_map implementation https://bugzilla.redhat.com/show_bug.cgi?id=609728 What|Old Value |New Value Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609738] Review Request: shiboken - CPython bindings generator for C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 Kalev Lember changed: What|Removed |Added Depends on||604695, 609728 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
