[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Ray Strode [halfline] changed: What|Removed |Added Blocks|674672 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Ray Strode [halfline] changed: What|Removed |Added Blocks||674672 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Matthias Clasen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Rakesh Pandit changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #12 from Rakesh Pandit 2010-07-05 07:16:49 EDT --- Changing status to assigned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 --- Comment #10 from Chen Lei 2010-07-02 23:34:01 EDT --- (In reply to comment #9) > It is named this way for consistency with the unique package. > If you look at http://live.gnome.org/LibUnique, you will find equal amounts of > references to libunique and unique. IMHO, I think unique should be renamed to libunique. Upstream renamed tarball to libunique completely after version 1.0.6. See 1.0.4 http://koji.fedoraproject.org/koji/rpminfo?rpmID=1058822 1.0.8 http://koji.fedoraproject.org/koji/rpminfo?rpmID=1181378 I think it's more reasonable to rename this package to libunique or libunique3. Also, only unique tarball is only available at http://people.gnome.org/~ebassi/source/ Gnome site always use libunique as tarball name even on version 1.0.0. See http://ftp.acc.umu.se/pub/GNOME/sources/libunique/1.0/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 --- Comment #9 from Matthias Clasen 2010-07-02 23:21:17 EDT --- It is named this way for consistency with the unique package. If you look at http://live.gnome.org/LibUnique, you will find equal amounts of references to libunique and unique. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 --- Comment #8 from Chen Lei 2010-07-02 22:22:03 EDT --- Hi Matthias, Why not rename this package to libunique instead of unique3? Upstream seems call it as libunique, the tarball name is also libunique-2.90.1.tar.bz2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 --- Comment #7 from Matthias Clasen 2010-07-02 14:32:39 EDT --- I've asked Richard if he would mind owning it, since he is the maintainer of unique, and this is just a gtk3 port of that. But feel free to add me as owner as well, if it makes your job easier, I don't mind owning yet another package... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 --- Comment #6 from Jason Tibbitts 2010-07-02 14:01:56 EDT --- OK, now I get to ask if that CVS request is correct. You've pushed this package all the way through review but you won't be the owner? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Matthias Clasen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Matthias Clasen 2010-07-02 13:43:30 EDT --- Sorry. For some reason the request got marked as a private comment... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #4 from Jason Tibbitts 2010-07-02 13:14:01 EDT --- The fedora-cvs flag is set but there's no CVS request that I can find. Resetting the flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Matthias Clasen changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Chen Lei changed: What|Removed |Added CC||supercyp...@gmail.com --- Comment #2 from Chen Lei 2010-07-02 05:27:10 EDT --- Some trivial suggestion: 1.It loooks like BuildRequires: gnome-doc-utils >= 0.3.2 and Requires: pkgconfig is not needed. 2. I seems the minimum version for gtk3 is 2.90.0, I think BuildRequires: gtk3-devel >= 2.90.0 can be changed to gtk3-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Adel Gadllah changed: What|Removed |Added CC||adel.gadl...@gmail.com AssignedTo|nob...@fedoraproject.org|adel.gadl...@gmail.com Flag||fedora-review+ --- Comment #1 from Adel Gadllah 2010-07-02 02:45:40 EDT --- Package Review: [+] source files match upstream: 32ab9849994da70f461fc78c59a2b930d294f8c7 [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] license field matches the actual license. [+] license is open source-compatible: LGPLv2+ [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] package builds in koji. [+] package installs properly. [+] debuginfo package looks complete. [1] rpmlint is silent. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] scriptlets are sane. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no libtool .la droppings. == [1]: Just noise: --- unique3-2.90.1-1.fc14.src/unique3.spec: W: no-cleaning-of-buildroot %clean unique3-2.90.1-1.fc14.src/unique3.spec: W: no-buildroot-tag unique3-2.90.1-1.fc14.src/unique3.spec: W: no-%clean-section --- => Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610211] Review Request: unique3 - Single instance support for GTK3 applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net Summary|unique3 - Single instance |Review Request: unique3 - |support for GTK3|Single instance support for |applications|GTK3 applications -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
