[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #17 from Peter Robinson 2010-08-10 08:43:29 EDT --- build for rawhide. Thanks Jonathon for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #16 from Kevin Fenzi 2010-08-09 13:24:02 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Peter Robinson changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Peter Robinson 2010-08-07 18:14:38 EDT --- New Package GIT Request === Package Name: meego-panel-zones Short Description: Meego zones panel Owners: pbrobinson Branches: F-14 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 MERCIER Jonathan changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #14 from Peter Robinson 2010-08-07 17:34:33 EDT --- (In reply to comment #13) > APPROVED! Thanks for the review Jonathon, can you set the fedora-review flag to + -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #13 from MERCIER Jonathan 2010-08-07 17:22:18 EDT --- APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 MERCIER Jonathan changed: What|Removed |Added Flag|needinfo?(bioinfornat...@gm | |ail.com)| --- Comment #12 from MERCIER Jonathan 2010-08-07 17:20:28 EDT --- for me i think is good now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Peter Robinson changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|bioinfornat...@gmail.com Flag||needinfo?(bioinfornat...@gm ||ail.com) --- Comment #11 from Peter Robinson 2010-08-07 15:32:52 EDT --- Jonathan, what's the status of this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #10 from Peter Robinson 2010-08-05 02:58:26 EDT --- So I think the above review was done on the meego package. I've updated the package. SPEC: http://pbrobinson.fedorapeople.org/meego-panel-zones.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-zones-0.2.0-0.1.fc14.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2380801 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #9 from Peter Robinson 2010-08-04 09:41:49 EDT --- > Issue: > 1. do not build with koji, rpmint for src.rpm and spec: > $ rpmlint meego-panel-zones-0.2.1-2.5.src.rpm That's not my RPM. I suspect you've got one that Chen mentioned above from upstream MeeGo. http://pbrobinson.fedorapeople.org/meego-panel-zones-0.1.18-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=610794
--- Comment #8 from MERCIER Jonathan 2010-08-02
19:49:18 EDT ---
Key:
[P] Pass
[F] Fail See [n]
[-] Not applicable
[?] Questions (see comments)
[?] MUST: rpmlint must be run on every package. The output should be
posted in the review.
[P] MUST: The package must be named according to the Package Naming
Guidelines.
[P] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption.
[P] MUST: The package must meet the Packaging Guidelines.
[P] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines.
[P] MUST: The License field in the package spec file must match
the actual license.
[-] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[P] MUST: The spec file must be written in American English.
[P] MUST: The spec file for the package MUST be legible.
[P] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
[F] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture.
see [2]
[F] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec
in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be
placed in a comment, next to the corresponding ExcludeArch line.
see [2]
[P] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the
Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
[P] MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
forbidden.
[-] MUST: Every binary RPM package (or sub package) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[-] MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package.
Without this, use of Prefix: /usr is considered a blocker.
[P] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory. Refer to the Guidelines for examples.
[P] MUST: A package must not contain any duplicate files in the %files
listing.
[P] MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section
must include a %defattr(...) line.
[P] MUST: The %clean section is not required for F-13 and above. Each package
for F-12 and below (or EPEL) MUST have a %clean section, which contains
rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[P] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
[P] MUST: The package must contain code, or permissible content.
This is described in detail in the code vs. content section
of Packaging Guidelines.
[-] MUST: Large documentation files should go in a -doc sub package.
(The definition of large is left up to the packager's best judgement,
but is not restricted to size. Large can refer to either size or quantity)
[P] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program
must run properly if it is not present.
[-] MUST: Header files must be in a -devel package.
[-] MUST: Static libraries must be in a -static package.
[-] MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig' (for directory ownership and usability).
[-] MUST: If a package contains library files with a suffix
(e.g. libfoo.so.1.1), then library files that end in .so
(without suffix) must go in a -devel package.
[-] MUST: In the vast majority of cases, devel packages must require
the base package using a fully versioned dependency
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #7 from Peter Robinson 2010-08-01 10:41:20 EDT --- (In reply to comment #5) > can you see: > http://fedoraproject.org/wiki/PackageNamingGuidelines#SnapshotPackages Yes, but its a tagged release. In the update that I'm just preparing I'm going to use the tagged release number instead of a git reference to better reflect this. meego doesn't do tar files. They do src.rpm or the git repo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #6 from Chen Lei 2010-08-01 09:32:17 EDT --- (In reply to comment #5) > can you see: > http://fedoraproject.org/wiki/PackageNamingGuidelines#SnapshotPackages MeeGo packages is a special case. Actually this package is not a snapshot, it's a formal release, but meego project tend to not upload tarballs to public place. Note: moblin-panel-zones = meego-panel-zones, meego renamed this package since version 0.2.0. http://repo.meego.com/MeeGo/releases/1.0/netbook/repos/source/moblin-panel-zones-0.1.18-1.1.src.rpm http://repo.meego.com/MeeGo/releases/1.0.1/netbook/repos/source/moblin-panel-zones-0.1.19-3.3.src.rpm http://repo.meego.com/MeeGo/builds/trunk/1.0.80.12.20100727.1/netbook/repos/source/meego-panel-zones-0.2.1-2.5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #5 from MERCIER Jonathan 2010-08-01 09:21:53 EDT --- can you see: http://fedoraproject.org/wiki/PackageNamingGuidelines#SnapshotPackages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #4 from Peter Robinson 2010-08-01 08:46:45 EDT --- (In reply to comment #3) > if you would use upstream do comment in spec how you get this and how you do > your tar.gz > see in example http://bioinfornatics.fedorapeople.org/tango.spec Its documented in the first 5 lines of the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 MERCIER Jonathan changed: What|Removed |Added CC||bioinfornat...@gmail.com --- Comment #3 from MERCIER Jonathan 2010-08-01 08:37:51 EDT --- if you would use upstream do comment in spec how you get this and how you do your tar.gz see in example http://bioinfornatics.fedorapeople.org/tango.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Chen Lei changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Chen Lei changed: What|Removed |Added Status|NEW |ASSIGNED CC||supercyp...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #2 from Chen Lei 2010-07-02 13:02:19 EDT --- I suggest you to use tarball from offical meego repo. Also, packaging meego 1.1 will be more useful, it looks like meego 1.0 is an experimental release(few qt stuff, still using moblin name). Meego 1.1 is more like Fedora 14, both releases will use kernel 2.6.35. We can modify src.rpm from http://repo.meego.com/MeeGo/builds/1.0.80, a package list for meego 1.1 is available. http://repo.meego.com/MeeGo/builds/1.0.80/1.0.80.8.20100629.1/netbook/images/meego-netbook-ia32/meego-netbook-ia32-1.0.80.8.20100629.1.packages We can easily use diff to see which package are updated between weekly images regularly. wget http://repo.meego.com/MeeGo/builds/1.0.80/1.0.80.8.20100622.1/netbook/images/meego-netbook-ia32/meego-netbook-ia32-1.0.80.8.20100622.1.packages wget http://repo.meego.com/MeeGo/builds/1.0.80/1.0.80.8.20100629.1/netbook/images/meego-netbook-ia32/meego-netbook-ia32-1.0.80.8.20100629.1.packages diff -u meego-netbook-ia32-1.0.80.8.20100622.1.packages meego-netbook-ia32-1.0.80.8.20100629.1.packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 --- Comment #1 from Chen Lei 2010-07-02 12:46:37 EDT --- How can you determine git_version e5fadfe is the version 0.1.18? From http://meego.gitorious.org/meego-netbook-ux/meego-panel-zones The version for Master/meego 1.1 is 0.2.0, the version for meego 1.0 is 0.1.19(the package name is moblin-panel-zones). It'll be much easier to use tarball in the upstream src.rpm, them write a comment before the source field. http://repo.meego.com/MeeGo/builds/1.0/latest/netbook/repos/source/moblin-panel-zones-0.1.19-3.3.src.rpm http://repo.meego.com/MeeGo/builds/1.0.80/1.0.80.8.20100629.1/netbook/repos/source/meego-panel-zones-0.2.1-2.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
