[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #24 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 leigh scott changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #23 from leigh scott --- Package Change Request == Package Name: tint2 New Branches: el6 Owners: leigh123linux -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #22 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 leigh scott changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #21 from Germán Racca --- (In reply to leigh scott from comment #19) > Hi Germán, > > Can I have a epel7 branch please? > I need it for my cinnamon port. > > > cinnamon has broken dependencies in the epel-7 tree: > On x86_64: > cinnamon-2.0.14-7.el7.x86_64 requires zukitwo-gtk3-theme > cinnamon-2.0.14-7.el7.x86_64 requires zukitwo-gtk2-theme > cinnamon-2.0.14-7.el7.x86_64 requires tint2 > cinnamon-2.0.14-7.el7.x86_64 requires gnome-themes > cinnamon-2.0.14-7.el7.x86_64 requires blueman > On ppc64: > cinnamon-2.0.14-7.el7.ppc64 requires zukitwo-gtk3-theme > cinnamon-2.0.14-7.el7.ppc64 requires zukitwo-gtk2-theme > cinnamon-2.0.14-7.el7.ppc64 requires tint2 > cinnamon-2.0.14-7.el7.ppc64 requires gnome-themes > cinnamon-2.0.14-7.el7.ppc64 requires blueman > Please resolve this as soon as possible. > > > Many thanks > > Leigh Yes! Please, tell me what to do. Germán. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #20 from Jon Ciesla --- Any comment from the Fedora maintainers? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #19 from leigh scott --- Hi Germán, Can I have a epel7 branch please? I need it for my cinnamon port. cinnamon has broken dependencies in the epel-7 tree: On x86_64: cinnamon-2.0.14-7.el7.x86_64 requires zukitwo-gtk3-theme cinnamon-2.0.14-7.el7.x86_64 requires zukitwo-gtk2-theme cinnamon-2.0.14-7.el7.x86_64 requires tint2 cinnamon-2.0.14-7.el7.x86_64 requires gnome-themes cinnamon-2.0.14-7.el7.x86_64 requires blueman On ppc64: cinnamon-2.0.14-7.el7.ppc64 requires zukitwo-gtk3-theme cinnamon-2.0.14-7.el7.ppc64 requires zukitwo-gtk2-theme cinnamon-2.0.14-7.el7.ppc64 requires tint2 cinnamon-2.0.14-7.el7.ppc64 requires gnome-themes cinnamon-2.0.14-7.el7.ppc64 requires blueman Please resolve this as soon as possible. Many thanks Leigh -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
https://bugzilla.redhat.com/show_bug.cgi?id=615153 leigh scott changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from leigh scott --- Package Change Request == Package Name: tint2 New Branches: epel7 Owners: leigh123linux -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #17 from Fedora Update System 2010-09-02 00:01:44 EDT --- tint2-0.11-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Fedora Update System changed: What|Removed |Added Fixed In Version|tint2-0.11-2.fc12 |tint2-0.11-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #16 from Fedora Update System 2010-08-31 23:31:08 EDT --- tint2-0.11-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Fedora Update System changed: What|Removed |Added Fixed In Version|tint2-0.11-2.fc13 |tint2-0.11-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #15 from Fedora Update System 2010-08-31 23:24:17 EDT --- tint2-0.11-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Fedora Update System changed: What|Removed |Added Fixed In Version||tint2-0.11-2.fc13 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Germán Racca changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-08-23 19:47:45 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #14 from Fedora Update System 2010-08-23 19:41:18 EDT --- tint2-0.11-2.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/tint2-0.11-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #13 from Fedora Update System 2010-08-23 19:39:42 EDT --- tint2-0.11-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/tint2-0.11-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #12 from Fedora Update System 2010-08-23 19:35:06 EDT --- tint2-0.11-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/tint2-0.11-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #11 from Kevin Fenzi 2010-08-23 17:07:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Germán Racca changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Germán Racca 2010-08-22 02:49:17 EDT --- Thanks very much Ankur for your time! As you have already reviewed this, would you make the review of bug 625939? New Package SCM Request === Package Name: tint2 Short Description: A lightweight X11 desktop panel and task manager Owners: skytux Branches: f12 f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Ankur Sinha changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Ankur Sinha 2010-08-21 22:36:34 EDT --- hello, [an...@070905042 SRPMS]$ rpmlint ../SPECS/tint2.spec tint2-0.11-2.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/tint2.spec: W: invalid-url Source0: http://tint2.googlecode.com/files/tint2-0.11.tar.bz2 HTTP Error 404: Not Found tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom tint2.src: W: invalid-url Source0: http://tint2.googlecode.com/files/tint2-0.11.tar.bz2 tint2.i686: W: spelling-error %description -l en_US ttm -> tam, atm, tom tint2.i686: W: no-manual-page-for-binary tint2conf tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom tint2.src: W: invalid-url Source0: http://tint2.googlecode.com/files/tint2-0.11.tar.bz2 HTTP Error 404: Not Found 4 packages and 1 specfiles checked; 0 errors, 7 warnings. Looks good. XXX APPROVED XXX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Germán Racca changed: What|Removed |Added Blocks||625939 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #8 from Germán Racca 2010-08-20 16:37:52 EDT --- Hi Ankur: Sorry for the delay :( I've packaged tint2 and tintwizard separately. Please find updated files here: SPEC: http://skytux.fedorapeople.org/packages/tint2.spec SRPM: http://skytux.fedorapeople.org/packages/tint2-0.11-2.fc13.src.rpm Koji build from scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2415326 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #7 from Ankur Sinha 2010-08-07 10:12:17 EDT --- (In reply to comment #6) > (In reply to comment #5) > > Hello Ankur: > > > Yes. I think that would be better. > > Well...I'm not sure right now if it is better to package them separately, > because this version of tint2 has a config tool, called tint2conf, which once > opened it uses tintwizard.py to configure the theme. > You can package them separately, and add a dependancy on tintwizard in the tint package? That way, tint2 will install tintwizard as a separate package on installation. It's not advised to package two different programs into one package, even if they're only used for each other. An illustration: What if tintwizard has a new release, but tint doesn't? You'll have to push an update for the tint package as a whole ( a larger update for nuts ). > But coming back to the license issue...is it not allowed to use a combination > of 2 licenses in a single package? Could you please clarify this to me? > Because > in [1] says we can. If this is the case, I can package tint2 and tintwizard.py > together without any problem. > > [1]https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios Yes, you can have multiple Licenses. Since I'm still for two separate packages, this isn't relevant here. > > > It still shouldn't call it a binary AFAIK. It's a python script. Although I > > may > > be wrong. I'd suggest asking upstream to make up a man page for tintwizard > > and > > include it in the distribution too. > > Certainly I could suggest upstream to add a man page for tintwizard.py, but I > don't think it is essential here because it is only a warning and to write a > man page could take a long time... > > Ankur, again many thanks for your time, and I would like you to clarify my > doubts in order to go on with this package. > > Regards, > German. A man page is suggested, you can always add it later and push an update. Please do request upstream to get started on it though. regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #6 from Germán Racca 2010-07-17 18:03:37 EDT --- (In reply to comment #5) Hello Ankur: > Yes. I think that would be better. Well...I'm not sure right now if it is better to package them separately, because this version of tint2 has a config tool, called tint2conf, which once opened it uses tintwizard.py to configure the theme. But coming back to the license issue...is it not allowed to use a combination of 2 licenses in a single package? Could you please clarify this to me? Because in [1] says we can. If this is the case, I can package tint2 and tintwizard.py together without any problem. [1]https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios > It still shouldn't call it a binary AFAIK. It's a python script. Although I > may > be wrong. I'd suggest asking upstream to make up a man page for tintwizard and > include it in the distribution too. Certainly I could suggest upstream to add a man page for tintwizard.py, but I don't think it is essential here because it is only a warning and to write a man page could take a long time... Ankur, again many thanks for your time, and I would like you to clarify my doubts in order to go on with this package. Regards, German. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #5 from Ankur Sinha 2010-07-17 02:10:27 EDT --- (In reply to comment #4) > (In reply to comment #2) > Hello Ankur: > > First of all many thanks for the full review! :-) > > > Issues: > > > > 1. License is unclear. You'd probably be better off contacting upstream to > > choose one of the two. > > Actually, tint2[1] and tintwizard[2] are different projects with different > owners, although they are related, and this could be the reason that tint2 > also > ships tintwizard. Maybe I must package them separately? > > [1]http://code.google.com/p/tint2/ > [2]http://code.google.com/p/tintwizard/ Yes. I think that would be better. > > > 2.rpmlint output: > > > > [an...@localhost rpmbuild]$ rpmlint SPECS/tint2.spec > > SRPMS/tint2-0.11-1.fc13.src.rpm > > /var/lib/mock/fedora-rawhide-i386/result/*.rpm > > tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom > > tint2.i686: W: spelling-error %description -l en_US ttm -> tam, atm, tom > > tint2.i686: W: no-manual-page-for-binary tintwizard.py > > tint2.i686: W: no-manual-page-for-binary tint2conf > > tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom > > 4 packages and 1 specfiles checked; 0 errors, 5 warnings. > > > > I wonder why it refers to tintwizard.py as a binary. Please check this? > > Because it is in /usr/bin and has executable permission? > > $ rpmlint -i RPMS/i686/tint2-0.11-1.fc13.i686.rpm > ... > tint2.i686: W: no-manual-page-for-binary tintwizard.py > Each executable in standard binary directories should have a man page. > ... > > Cheers, > Germán. It still shouldn't call it a binary AFAIK. It's a python script. Although I may be wrong. I'd suggest asking upstream to make up a man page for tintwizard and include it in the distribution too. Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #4 from Germán Racca 2010-07-17 00:47:22 EDT --- (In reply to comment #2) Hello Ankur: First of all many thanks for the full review! :-) > Issues: > > 1. License is unclear. You'd probably be better off contacting upstream to > choose one of the two. Actually, tint2[1] and tintwizard[2] are different projects with different owners, although they are related, and this could be the reason that tint2 also ships tintwizard. Maybe I must package them separately? [1]http://code.google.com/p/tint2/ [2]http://code.google.com/p/tintwizard/ > 2.rpmlint output: > > [an...@localhost rpmbuild]$ rpmlint SPECS/tint2.spec > SRPMS/tint2-0.11-1.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm > tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom > tint2.i686: W: spelling-error %description -l en_US ttm -> tam, atm, tom > tint2.i686: W: no-manual-page-for-binary tintwizard.py > tint2.i686: W: no-manual-page-for-binary tint2conf > tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom > 4 packages and 1 specfiles checked; 0 errors, 5 warnings. > > I wonder why it refers to tintwizard.py as a binary. Please check this? Because it is in /usr/bin and has executable permission? $ rpmlint -i RPMS/i686/tint2-0.11-1.fc13.i686.rpm ... tint2.i686: W: no-manual-page-for-binary tintwizard.py Each executable in standard binary directories should have a man page. ... Cheers, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=615153
--- Comment #2 from Ankur Sinha 2010-07-16 03:11:34
EDT ---
REVIEW:
+ OK
? ISSUE
- NA
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
? License
? License field in spec matches
? License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[an...@localhost rpmbuild]$ md5sum tint2-0.11.tar.bz2
SOURCES/tint2-0.11.tar.bz2
6fc5731e7425125fa84a2add5cef4bff tint2-0.11.tar.bz2
6fc5731e7425125fa84a2add5cef4bff SOURCES/tint2-0.11.tar.bz2
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
+ Package is a GUI app and has a .desktop file
- Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
- No rpmlint output.
SHOULD Items:
+ Should build in mock.
+ Should build on all supported archs
? Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
Issues:
1. License is unclear. You'd probably be better off contacting upstream to
choose one of the two.
2.rpmlint output:
[an...@localhost rpmbuild]$ rpmlint SPECS/tint2.spec
SRPMS/tint2-0.11-1.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm
tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom
tint2.i686: W: spelling-error %description -l en_US ttm -> tam, atm, tom
tint2.i686: W: no-manual-page-for-binary tintwizard.py
tint2.i686: W: no-manual-page-for-binary tint2conf
tint2.src: W: spelling-error %description -l en_US ttm -> tam, atm, tom
4 packages and 1 specfiles checked; 0 errors, 5 warnings.
I wonder why it refers to tintwizard.py as a binary. Please check this?
The rest looks good. Once these minor issues are cleared, you're good to go.
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 --- Comment #3 from Ankur Sinha 2010-07-16 03:12:29 EDT --- I haven't checked the functioning of the package btw. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Ankur Sinha changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com AssignedTo|nob...@fedoraproject.org|sanjay.an...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615153] Review Request: tint2 - A lightweight X11 desktop panel and task manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615153 Germán Racca changed: What|Removed |Added CC||ch...@chessgriffin.com --- Comment #1 from Germán Racca 2010-07-15 23:16:47 EDT --- *** Bug 515247 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
