[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #21 from Fedora Update System 2011-03-19 14:20:58 EDT --- pfHandle-1.1-4.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Fedora Update System changed: What|Removed |Added Fixed In Version|pfHandle-1.1-3.fc14 |pfHandle-1.1-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #22 from Fedora Update System 2011-03-19 14:21:07 EDT --- pfHandle-1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #20 from Fedora Update System 2011-03-01 21:43:47 EST --- Package pfHandle-1.1-4.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing pfHandle-1.1-4.el6' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/pfHandle-1.1-4.el6 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #19 from Fedora Update System 2011-03-01 21:42:49 EST --- Package pfHandle-1.1-4.el5: * should fix your issue, * was pushed to the Fedora EPEL 5 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing pfHandle-1.1-4.el5' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/pfHandle-1.1-4.el5 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #18 from Jason Tibbitts 2011-03-01 21:10:00 EST --- The branch names are EL-5 and EL-6; I fixed the request for you. Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Carl Thompson changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #17 from Carl Thompson 2011-03-01 18:13:00 EST --- Package Change Request == Package Name: pfHandle New Branches: EPEL5 EPEL6 Owners: redragon InitialCC: redragon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Fedora Update System changed: What|Removed |Added Fixed In Version|pfHandle-1.1-3.fc13 |pfHandle-1.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #16 from Fedora Update System 2010-08-18 21:12:50 EDT --- pfHandle-1.1-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pfHandle-1.1-3.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #15 from Fedora Update System 2010-08-13 17:08:31 EDT --- pfHandle-1.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #14 from Fedora Update System 2010-08-02 20:37:00 EDT --- pfHandle-1.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pfHandle'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pfHandle-1.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #13 from Fedora Update System 2010-08-01 15:22:59 EDT --- pfHandle-1.1-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pfHandle'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pfHandle-1.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #12 from Fedora Update System 2010-07-30 19:48:34 EDT --- pfHandle-1.1-3.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/pfHandle-1.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #11 from Fedora Update System 2010-07-30 19:48:29 EDT --- pfHandle-1.1-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/pfHandle-1.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #10 from Kevin Fenzi 2010-07-30 16:33:09 EDT --- GIT done (by process-cvs-requests.py). with f14 branch added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Carl Thompson changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Carl Thompson changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #9 from Carl Thompson 2010-07-28 15:49:48 EDT --- New Package CVS Request === Package Name: pfHandle Short Description: wrapper for postfix queue management tools Owners: redragon Branches: F-13 InitialCC: redragon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Kevin Fenzi 2010-07-28 15:22:47 EDT --- ok, looks good. I see no further blockers now, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #7 from Carl Thompson 2010-07-28 14:23:55 EDT --- SPEC: http://red-dragon.com/pfHandle.spec SRPM: http://red-dragon.com/pfHandle-1.1-3.fc13.src.rpm cleaned up %doc section Properly updated the upstream versioning updated README to state its GPLv2 and that the full license is in COPYING. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #6 from Kevin Fenzi 2010-07-28 13:10:36 EDT --- Cool. We are getting there. ;) 1. Thats fine, but: a) You can just do "%doc COPYING README". No need to use _defaultdocdir or the like. b) You seem to have changed the upstream release contents without changing the release. This is not good practice. Anytime you change the contents, make a new release. Now when people look at the '1' version they won't know if it's the one without COPYING and README changes or not. ;) c) You have in README: "See COPYING for licensing information" Which is not explicit enough. Just based on copying, the license here would be "GPL+" ie, any version of the gpl ever published. ;) If you just want v2, say "This package is released under the GPLv2 only" 2. Looks good. 3. Excellent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #5 from Carl Thompson 2010-07-28 00:39:01 EDT --- SPEC: http://red-dragon.com/pfHandle.spec SRPM: http://red-dragon.com/pfHandle-1-2.fc13.src.rpm 1) Added COPYING file and updated README 2) removed RPM_BUILD_ROOT from install and clean 3) rpmlint says [redra...@gkar SPECS]$ rpmlint pfHandle.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [redra...@gkar SRPMS]$ rpmlint pfHandle-1-2.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. koji build on f13 passed no failures koji build on rawhide passed no failures -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #4 from Kevin Fenzi 2010-07-27 23:59:12 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. See below - Meets Packaging Guidelines. See below - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 52a127b0616657d05edc0cb21e91d172 pfHandle-1.tar.gz 52a127b0616657d05edc0cb21e91d172 pfHandle-1.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The only indicator of what the package license is is the launchpad site. ;) Might be good to include a COPYING file and explicitly state in the README that it's GPL v2 only. 2. You should nuke the [ "$RPM_BUILD_ROOT" != "/" ] && from the clean section. 3. rpmlint says: 2 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #3 from Carl Thompson 2010-07-26 14:15:01 EDT --- New Spec URL: http://www.red-dragon.com/pfHandle.spec SRPM URL: http://www.red-dragon.com/pfHandle-1-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #2 from Kevin Fenzi 2010-07-24 16:08:39 EDT --- Some general comments before doing a full review here: - You probibly want a dist tag. If you don't have one it becomes difficult to ship the same version to multiple release branches. - You should get rid of the "[ "$RPM_BUILD_ROOT" != "/" ] && " constructs. - You should get rid of the Vendor tag Fix those up and I can do the full review. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@tummy.com Flag||fedora-review? --- Comment #1 from Kevin Fenzi 2010-07-24 15:37:32 EDT --- I'll go ahead and review this and your other submission and look at sponsoring you. ;) Look for a full review in a while here... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617400] Review Request: pfHandle - wrapper for tools to manage postfix mail queue
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 manuel wolfshant changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
