[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||goddard-backgrounds-13.0.0- ||2.fc14 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-08-01 15:18:18 EDT --- goddard-backgrounds-13.0.0-2.fc14, laughlin-backgrounds-13.91.0-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Fixed In Version|goddard-backgrounds-13.0.0- |laughlin-backgrounds-13.91. |2.fc14 |0-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=618852
Julian Aloofi julian.fed...@googlemail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Julian Aloofi julian.fed...@googlemail.com 2010-07-30
04:47:50 EDT ---
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. N/A
SHOULD: The package builds in mock.
- builds fine for fedora-13-i386, fedora-rawhide-i386 and fedora-12-i386
NOTE: You do not need the BuildRoot tag anymore, so you could just remove it
next time you update the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 --- Comment #5 from Martin Sourada martin.sour...@gmail.com 2010-07-30 05:39:36 EDT --- Thanks for the review :-) I'll make the fixes you noted after the initial import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Martin Sourada martin.sour...@gmail.com 2010-07-30 05:41:24 EDT --- New Package CVS Request === Package Name: laughlin-backgrounds Short Description: Laughlin desktop backgrounds Owners: mso Branches: F-14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-07-30 16:37:42 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-07-30 17:15:19 EDT --- goddard-backgrounds-13.0.0-2.fc14,laughlin-backgrounds-13.91.0-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/goddard-backgrounds-13.0.0-2.fc14,laughlin-backgrounds-13.91.0-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 Julian Aloofi julian.fed...@googlemail.com changed: What|Removed |Added QAContact|extras...@fedoraproject.org |julian.fed...@googlemail.co ||m -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 Julian Aloofi julian.fed...@googlemail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|julian.fed...@googlemail.co ||m Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618852] Review Request: laughlin-backgrounds - Laughlin desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618852 --- Comment #3 from Julian Aloofi julian.fed...@googlemail.com 2010-07-28 18:34:04 EDT --- This package looks like there aren't any problems anyway. You used F13 Laughlin in the changelog, but that's about the only thing I was able to find. I'll probably do the full review stuff tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
