[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #15 from Mamoru Tasaka 2010-08-13 13:26:22 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #14 from Kevin Fenzi 2010-08-10 13:58:27 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Tajidin Abdullah changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Tajidin Abdullah 2010-08-10 12:35:04 EDT --- New Package SCM Request === Package Name: faenza-icon-theme Short Description: icon theme for Equinox GTK theme Owners: tajidinabd Branches: f12 f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621713
Mamoru Tasaka changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from Mamoru Tasaka 2010-08-10
10:56:01 EDT ---
Okay.
One additional comment:
--
cp -R ./Faenza/ $RPM_BUILD_ROOT%{_datadir}/icons
cp -R ./Faenza-Dark/ $RPM_BUILD_ROOT%{_datadir}/icons
--
- Please change this to "cp -a" to keep timestamps on installed
files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
---
This pacakge (faenza-icon-theme) is APPROVED by mtasaka
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #11 from Tajidin Abdullah 2010-08-10 04:16:46 EDT --- well waiting for response from upstream about renaming the source package so in holding pattern til then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #10 from Germán Racca 2010-08-09 23:58:18 EDT --- (In reply to comment #9) > https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F > "The first thing to consider is that you cannot use COPYING to determine license versioning..." You are right Mamoru, sorry :) Regards, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #9 from Mamoru Tasaka 2010-08-09 23:49:31 EDT --- (In reply to comment #8) > Question: > > I don't know why GPL+ if there is a file saying explicitly that the license is > GPLv3+...who can explain me that? > (In reply to comment #1) > * License > - In the zip file I see only GPLv3 "COPYING.txt" is included > and no other information cannot be found in the zip > which specifies the version of GPL this zip is licensed under. > > In this case we regard that this zip is licensed under "GPL+" > (GPL at any version), see: > > https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621713
Germán Racca changed:
What|Removed |Added
CC||gra...@gmail.com
--- Comment #8 from Germán Racca 2010-08-09 23:27:25 EDT ---
Question:
I don't know why GPL+ if there is a file saying explicitly that the license is
GPLv3+...who can explain me that?
Tarjidin:
You can contact upstream and ask him to put the version of each release in the
name of the zip file, as for example: Faenza_Icons_by_tiheum_0.5.zip
Also you can change:
%dir %{_datadir}/icons/Faenza
%{_datadir}/icons/Faenza/*
%dir %{_datadir}/icons/Faenza-Dark
%{_datadir}/icons/Faenza-Dark/*
by
%{_datadir}/icons/Faenza/
%{_datadir}/icons/Faenza-Dark/
so in that way you own directories and also the contents. I think it is more
compact :)
Regards,
Germán.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #7 from Tajidin Abdullah 2010-08-09 14:49:54 EDT --- I got the version number 0.5 from this URL http://gnome-look.org/content/show.php/Faenza?content=128143 that is in the spec file if that is not the version please tell me what is then. No other information in regards to version number. Spec Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme.spec SRPM Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme-0.5-4.fc13.src.rpm Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #6 from Mamoru Tasaka 2010-08-09 13:12:47 EDT --- Well, ? Again I don't see how you identified the version number as 0.5. Would you write some notes in the spec file as comments what specifies the version number of the zip file? ? Also what is the purpose of defining %tarname macro and using it in "%setup -q -c" ? When "-c" option is passed to %setup, it creates a new directory before unpackaging source file (in this case zip file), and using additional "-n" option does not bear any difference (i.e. just "%setup -q -c" is enough). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #5 from Tajidin Abdullah 2010-08-08 17:22:30 EDT --- Spec Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme.spec Srpm Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme-0.5-3.fc13.src.rpm made corrections to reflect 0.5-3 added scriplet made corrections to utilize tarname macro successful koji scratch http://koji.fedoraproject.org/koji/taskinfo?taskID=2388524 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #4 from Mamoru Tasaka 2010-08-08 12:47:07 EDT --- (Removing NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #3 from Mamoru Tasaka 2010-08-08 12:16:13 EDT --- For -2: * Unused macro - You seem to have defined %tarname, however this macro is used nowhere in the spec file * Version - Again, what file or so indicates that the version is actually 0.5.2? * Scriptlets: - Please also update Faenza-Dark/ directory -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #2 from Tajidin Abdullah 2010-08-07 18:34:11 EDT --- Spec Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme.spec Srpm Url: http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme-0.5.2-2.fc13.src.rpm make sure you reload the browser when you check the spec file sometimes its showing the old spec file Successful build on Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2387694 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621713
Mamoru Tasaka changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #1 from Mamoru Tasaka 2010-08-07
14:52:49 EDT ---
Some notes.
? Version number
- Would you write how we can identify the version number
of this zip file?
* License
- In the zip file I see only GPLv3 "COPYING.txt" is included
and no other information cannot be found in the zip
which specifies the version of GPL this zip is licensed under.
In this case we regard that this zip is licensed under "GPL+"
(GPL at any version), see:
https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
* BuildRoot
- As I wrote in bug 620990, BuildRoot tag is no longer needed
on Fedora (and EPEL6).
* scriptlets
- For updating GTK icon, please follow:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
("hicolor" must be replaced appropritely)
! Note
- Not %postrun but %postun .
* Misc notes:
--
ln -sf ./distributor-logo-fedora.png distributor-logo.png
--
- "./" is redundant and please remove this.
* rpmlint issues
--
faenza-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Faenza-Dark/index.theme
faenza-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Faenza/index.theme
--
- These errors are because these files have unneeded executable permission.
Please change the permission of these files to 0644.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Tajidin Abdullah changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
