[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2010-08-25 23:23:10 EDT --- emacs-rinari-2.1-4.20100815git.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|emacs-rinari-2.1-4.20100815 |emacs-rinari-2.1-4.20100815 |git.fc13|git.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||emacs-rinari-2.1-4.20100815 ||git.fc12 Resolution||ERRATA Last Closed||2010-08-24 17:03:12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-08-24 17:03:08 EDT --- emacs-rinari-2.1-4.20100815git.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|emacs-rinari-2.1-4.20100815 |emacs-rinari-2.1-4.20100815 |git.fc12|git.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-08-24 17:03:36 EDT --- emacs-rinari-2.1-4.20100815git.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #15 from Kevin Fenzi ke...@tummy.com 2010-08-16 15:22:40 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-08-17 00:15:04 EDT --- emacs-rinari-2.1-4.20100815git.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/emacs-rinari-2.1-4.20100815git.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-08-17 01:32:28 EDT --- emacs-rinari-2.1-4.20100815git.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update emacs-rinari'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/emacs-rinari-2.1-4.20100815git.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #3 from Arun SAG saga...@gmail.com 2010-08-15 05:10:50 EDT --- Updated the package, Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-rinari.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-rinari-2.1-2.20100815git.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #4 from Shakthi Kannan shakthim...@gmail.com 2010-08-15 08:15:50 EDT --- #001 Please remove the quotes! I used it to refer to the phrase/words that are relevant. Also 'rails' is in smaller-case in the .spec file. Please correct it. #003 It should be: %global pkg rinari %global pkgname Rinari -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622002
--- Comment #5 from Shakthi Kannan shakthim...@gmail.com 2010-08-15 09:09:41
EDT ---
#007 Why so many redundant entries?
%dir %{_emacs_sitelispdir}/%{pkg}
%dir %{_emacs_sitelispdir}/%{pkg}/util/
%dir %{_emacs_sitelispdir}/%{pkg}/util/jump/
Use:
%dir %{_emacs_sitelispdir}/%{pkg}/
This will include the tree under it.
#008 Why is this required?
%dir %{_emacs_sitestartdir}/
This is owned by emacs-common.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #6 from Arun SAG saga...@gmail.com 2010-08-15 09:35:23 EDT --- Issues are corrected. Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-rinari.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-rinari-2.1-3.20100815git.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #7 from Shakthi Kannan shakthim...@gmail.com 2010-08-15 10:12:15 EDT --- #007 If you need to include the whole tree under the directory, you will need to include the trailing '/' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #8 from Arun SAG saga...@gmail.com 2010-08-15 10:39:37 EDT --- I have updated, Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-rinari.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-rinari-2.1-4.20100815git.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622002
Shakthi Kannan shakthim...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Shakthi Kannan shakthim...@gmail.com 2010-08-15 12:23:03
EDT ---
#009 There is a spelling mistake 'instillation' in the README file. Please fix
that.
Here is the review:
+:ok, NA: not applicable
MUST Items:
[+] MUST: rpmlint output
$ rpmlint emacs-rinari.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint emacs-rinari-2.1-4.20100815git.fc15.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint emacs-rinari-2.1-4.20100815git.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[NA] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
87ad3ecbbea0a4bfbf75d4c00b9123f1 rinari-20100815.tar.bz2
[+] MUST: must successfully compile and build into binary rpms on one main arch
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Package approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Arun SAG saga...@gmail.com 2010-08-15 12:31:15 EDT --- New Package CVS Request === Package Name: emacs-rinari Short Description: Ruby on rails minor mode for emacs Owners: sagarun Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Arun SAG saga...@gmail.com 2010-08-15 23:55:43 EDT --- Package Change Request == Package Name: emacs-rinari New Branches: F-14 Owners: sagarun [Missed to request F-14 branch] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-08-16 00:22:41 EDT --- emacs-rinari-2.1-4.20100815git.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/emacs-rinari-2.1-4.20100815git.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-08-16 00:20:53 EDT --- emacs-rinari-2.1-4.20100815git.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/emacs-rinari-2.1-4.20100815git.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622002
--- Comment #2 from Arun SAG saga...@gmail.com 2010-08-13 03:27:53 EDT ---
(In reply to comment #1)
#001: In Summary:, for nouns, please use Ruby on Rails and Emacs.
Ok.
#002: For your comments, please give a newline above and below, and give a
white-space after '#' as in:
# The source of this package was pulled from upstream's vcs.
# use the following command to generate the tar ball:
The .spec file must be readable.
Ok.
#003: As per the GNU Emacs template please use:
%global pkg foo
%global pkgname Foo
Sure.
#004: Source0 should point to a URL that is available for download. Please
upload the same sources that you used for packaging at your fedorapeople.org
website, and mention the URL.
Ok.
#005: Use the following:
%{__rm}
%{__install}
This practice is discouraged, please read
http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html
#006: In emacs-rinari-init.el, please don't include ido-mode, since, it is
only
recommended and not required. We don't need to force it on the end user. Just
use:
;; Init file for rinari plugin
(add-to-list 'load-path /usr/share/emacs/site-lisp/rinari/)
(require 'rinari)
I will remove the ido-mode.
I have tested the package, and it works.
Thank you shakthi for the comments, i will fix the spec and update the srpm
tonight.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 Shakthi Kannan shakthim...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|shakthim...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622002] Review Request: emacs-rinari - Ruby on rails minor mode for emacs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622002
--- Comment #1 from Shakthi Kannan shakthim...@gmail.com 2010-08-13 01:41:38
EDT ---
#001: In Summary:, for nouns, please use Ruby on Rails and Emacs.
#002: For your comments, please give a newline above and below, and give a
white-space after '#' as in:
# The source of this package was pulled from upstream's vcs.
# use the following command to generate the tar ball:
The .spec file must be readable.
#003: As per the GNU Emacs template please use:
%global pkg foo
%global pkgname Foo
#004: Source0 should point to a URL that is available for download. Please
upload the same sources that you used for packaging at your fedorapeople.org
website, and mention the URL.
#005: Use the following:
%{__rm}
%{__install}
#006: In emacs-rinari-init.el, please don't include ido-mode, since, it is only
recommended and not required. We don't need to force it on the end user. Just
use:
;; Init file for rinari plugin
(add-to-list 'load-path /usr/share/emacs/site-lisp/rinari/)
(require 'rinari)
I have tested the package, and it works.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
