[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||stardict-xmllittre-1.0-3.fc ||16 Resolution||ERRATA Last Closed||2011-12-30 17:54:02 --- Comment #14 from Fedora Update System 2011-12-30 17:54:02 EST --- stardict-xmllittre-1.0-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2011-12-22 17:47:50 EST --- stardict-xmllittre-1.0-3.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 --- Comment #12 from Fedora Update System 2011-12-19 17:56:29 EST --- stardict-xmllittre-1.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/stardict-xmllittre-1.0-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 --- Comment #11 from Jon Ciesla 2011-11-21 08:32:43 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 François Cami changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from François Cami 2011-11-20 18:31:50 EST --- New Package SCM Request === Package Name: stardict-xmllittre Short Description: Authoritative 19th century French dictionary Owners: fcami Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 --- Comment #9 from François Cami 2011-11-20 18:27:31 EST --- Thank you Mario. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624182
Mario Blättermann changed:
What|Removed |Added
Flag|fedora-review?, |fedora-review+, needinfo-
|needinfo?(mario.blaetterman |
|n...@gmail.com)|
--- Comment #8 from Mario Blättermann 2011-11-20
17:22:38 EST ---
Yes, I agree.
PACKAGE APPROVED.
(In reply to comment #6)
> If you don't want to provide your package for EPEL <= 6, you may drop the
> following parts of your spec file:
>
> - the BuildRoot declaration.
> - the initial cleaning of ${RPM_BUILD_ROOT} in %install
> - the %defattr line in %files
Consider to remove the mentioned parts if you don't plan to package for older
EPELs, before you commit it to the Git repo.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 François Cami changed: What|Removed |Added Flag||needinfo?(mariobl@freenet.d ||e) --- Comment #7 from François Cami 2011-11-15 14:42:23 EST --- Thank you for reviewing. My comments below. [X] MUST: The package must be licensed with a Fedora approved license. As far as I can read in the sources (or as detected by my translation software, because it's French only), there's no implicit declaration of GPLv3. Seems to be rather GPL+ than GPLv3. Would you explain the French README please? [X] MUST: The License field in the package spec file must match the actual license. The README implies GPL+ indeed, yet the website at: http://francois.gannaz.free.fr/Littre/horsligne.php links explicitely to: http://fsffrance.org/gpl/gpl-fr.fr.html which is, unless I am mistaken, an unofficial translation of GPLv3. So I took what I thought was the safe route, which is GPLv3. Do you agree? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624182
--- Comment #6 from Mario Blättermann 2011-10-03 15:33:50
EDT ---
$ rpmlint -i -v *stardict-xmllittre.src: I: checking
stardict-xmllittre.src: I: checking-url
http://francois.gannaz.free.fr/Littre/horsligne.php (timeout 10 seconds)
stardict-xmllittre.src: I: checking-url
http://francois.gannaz.free.fr/Littre/dlds/XMLittre_stardict_1.0.tar (timeout
10 seconds)
stardict-xmllittre.noarch: I: checking
stardict-xmllittre.noarch: I: checking-url
http://francois.gannaz.free.fr/Littre/horsligne.php (timeout 10 seconds)
stardict-xmllittre.spec: I: checking-url
http://francois.gannaz.free.fr/Littre/dlds/XMLittre_stardict_1.0.tar (timeout
10 seconds)
stardict-xmllittre.spec: W: invalid-url Source0:
http://francois.gannaz.free.fr/Littre/dlds/XMLittre_stardict_1.0.tar ''
The value should be a valid, public HTTP, HTTPS, or FTP URL.
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
The URL seems to be unavailable, but with wget I can download the tarball.
However, the server is terribly slow.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[X] MUST: The package must be licensed with a Fedora approved license.
As far as I can read in the sources (or as detected by my translation
software, because it's French only), there's no implicit declaration
of GPLv3. Seems to be rather GPL+ than GPLv3. Would you explain
the French README please?
[X] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
263506fab62afafda6a37c3f398bf994 XMLittre_stardict_1.0.tar
263506fab62afafda6a37c3f398bf994 XMLittre_stardict_1.0.tar.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. I don't speak French, let alone
this version of French.
[.] SHOULD: If scriptlets are used, those scriptlets must be
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mari...@freenet.de AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? --- Comment #5 from Mario Blättermann 2011-10-03 15:13:22 EDT --- Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3400400 Looks fine so far, stay tuned for a full review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 François Cami changed: What|Removed |Added Depends on|617340 | --- Comment #4 from François Cami 2011-06-30 17:11:46 EDT --- Removing 617340 as blocker - this was because I was not a packager when the review request was done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 Kevin Fenzi changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #3 from Kevin Fenzi 2010-08-15 15:59:58 EDT --- Removing needsponsor here as I am sponsoring. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 --- Comment #2 from François Cami 2010-08-15 09:58:22 EDT --- Added README, after converting to UTF-8. Spec URL: http://fcami.fedorapeople.org/srpms/stardict-xmllittre.spec SRPM URL: http://fcami.fedorapeople.org/srpms/stardict-xmllittre-1.0-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 --- Comment #1 from François Cami 2010-08-15 09:34:35 EDT --- Now with better %description. Spec URL: http://fcami.fedorapeople.org/srpms/stardict-xmllittre.spec SRPM URL: http://fcami.fedorapeople.org/srpms/stardict-xmllittre-1.0-2.fc13.src.rpm Please note that I am aware that the package name does not strictly follow Fedora's naming guidelines. However: * upstream's real name is XMLLittré (and "é" cannot be used), * we have other stardict dictionaries in Fedora, as far as I can tell they are all prefixed with stardict-, * Debian's package name is stardict-xmllittre: http://packages.debian.org/sid/stardict-xmlittre -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624182] Review Request: stardict-xmllittre - Authoritative 19th century French dictionary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624182 François Cami changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||617340 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
