[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|needinfo?(xav...@bachelot.o | |rg) | Last Closed||2010-11-09 04:21:26 --- Comment #16 from Xavier Bachelot xav...@bachelot.org 2010-11-09 04:21:26 EST --- An update with the latest snapshot is on its way to rawhide, F14 and F13. http://koji.fedoraproject.org/koji/taskinfo?taskID=2589368 http://koji.fedoraproject.org/koji/taskinfo?taskID=2589390 http://koji.fedoraproject.org/koji/taskinfo?taskID=2589394 Time to close this bug now. Thanks again for the review, hopefully you or someone else find a bit of time for the sister review in that other famous repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Flag||needinfo?(xav...@bachelot.o ||rg) --- Comment #15 from Alex Lancaster al...@users.sourceforge.net 2010-11-07 17:20:59 EST --- Thanks for the rawhide build, any chance we could get builds and updates for f13 and f14? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2010-10-25 14:43:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=625602
--- Comment #10 from Xavier Bachelot xav...@bachelot.org 2010-10-21 05:20:34
EDT ---
(In reply to comment #9)
[ ? ] MUST: rpmlint must be run on every package
$ rpmlint RPMS/x86_64/libbluray-*
~/RPMS/SRPMS/libbluray-0.1-0.1.20100819.fc13.src.rpm
libbluray.x86_64: W: spelling-error %description -l en_US bluray - blurry,
blurt, blurb
libbluray.x86_64: W: spelling-error %description -l en_US embeddable -
embedding, embedded, shreddable
libbluray.x86_64: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.x86_64: W: spelling-error %description -l en_US vlc - vac, voc,
Vlad
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj/native 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdnav 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/hdmv 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/decoders 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/util 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/file 0775L
libbluray.src: W: spelling-error %description -l en_US bluray - blurry,
blurt,
blurb
libbluray.src: W: spelling-error %description -l en_US embeddable -
embedding,
embedded, shreddable
libbluray.src: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.src: W: spelling-error %description -l en_US vlc - vac, voc, Vlad
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src: W: invalid-url Source0: libbluray-20100819.tar.bz2
4 packages and 0 specfiles checked; 10 errors, 15 warnings.
Can you look into the debuginfo errors? not sure if they need to be
fixed or not. Regarding the macros-in-comment warning, can probably
ignore that, as well the spelling-error's.
I'll look into the perms on the debuginfo, but this is likely coming from the
tarball generation.
[ ? ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
Can't test the MD5 checksums because the git command will check out
a different version of the code than the one uploaded in the SRPM,
unless the git command in the spec uses the same date as
%{tarball_date}. Make sure that %{tarball_date} is adjusted
correctly at the time of checkin.
I will rework this part to use the commit hash rather than the date. I'll also
fix the release tag to include the commit hash (at least the start of it), as
per the guideline on pre-releases.
[ ? ] MUST: Static libraries must be in a -static package.
Seems that generating a static package is optional, is this intentional?
Yes, this is intentional. Static libs are only needed to build some of the
small test programs that are included (but not built nor installed by default
Makefile).
[ x ] SHOULD: The reviewer should test that the package functions as
described. A package should not segfault instead of running, for
example.
xbmc (from RPM Fusion) correctly links against libbluray, don't have
discs to test, unfortunately.
You can probably test with the BD iso from the link in comment #3.
Thanks a lot for the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #11 from Xavier Bachelot xav...@bachelot.org 2010-10-21 19:25:49 EDT --- New SRPM and spec addressing your comments : Spec URL: http://www.bachelot.org/fedora/SPECS/libbluray.spec SRPM URL : http://www.bachelot.org/fedora/SRPMS/libbluray-0.1-0.2.20101021git144a204c02687.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Xavier Bachelot xav...@bachelot.org 2010-10-21 19:35:15 EDT --- New Package SCM Request === Package Name: libbluray Short Description: Library to access Blu-Ray disks for video playback Owners: xavierb Branches: f12 f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #13 from Alex Lancaster al...@users.sourceforge.net 2010-10-21 22:04:27 EDT --- (In reply to comment #10) (In reply to comment #9) I will rework this part to use the commit hash rather than the date. I'll also fix the release tag to include the commit hash (at least the start of it), as per the guideline on pre-releases. Got your updated spec, looks good. Thanks for fixing that. [ ? ] MUST: Static libraries must be in a -static package. Seems that generating a static package is optional, is this intentional? Yes, this is intentional. Static libs are only needed to build some of the small test programs that are included (but not built nor installed by default Makefile). Check. You can probably test with the BD iso from the link in comment #3. Actually, just after I submitted the review, I recompiled XBMC with libbluray support. It appears that xbmc dlopen()s libbluray.so.1 or otherwise doesn't link it into the binary, however it does correctly load. Unfortunately xbmc can't play an ISO directly, but I could loopback mount the ISO and then navigate to the folder and it did play the disc content (albeit with no Bluray menus, it just skipped to next playlist item), but seems to playback just fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=625602
Alex Lancaster al...@users.sourceforge.net changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Alex Lancaster al...@users.sourceforge.net 2010-10-21
00:20:46 EDT ---
Looks good. Please check my notes on things to fix post-checkin
(particularly the SourceURL stuff), otherwise:
APPROVED
Full review follows:
x = passes review item
- = fails review item, package approval blocked until resolution
? = query that can be resolved after approval, not a blocker
N/A = not applicable to this package
MUST items:
[ ? ] MUST: rpmlint must be run on every package
$ rpmlint RPMS/x86_64/libbluray-*
~/RPMS/SRPMS/libbluray-0.1-0.1.20100819.fc13.src.rpm
libbluray.x86_64: W: spelling-error %description -l en_US bluray - blurry,
blurt, blurb
libbluray.x86_64: W: spelling-error %description -l en_US embeddable -
embedding, embedded, shreddable
libbluray.x86_64: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.x86_64: W: spelling-error %description -l en_US vlc - vac, voc, Vlad
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj/native 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdnav 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/hdmv 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/decoders 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/util 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/file 0775L
libbluray.src: W: spelling-error %description -l en_US bluray - blurry, blurt,
blurb
libbluray.src: W: spelling-error %description -l en_US embeddable - embedding,
embedded, shreddable
libbluray.src: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.src: W: spelling-error %description -l en_US vlc - vac, voc, Vlad
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src: W: invalid-url Source0: libbluray-20100819.tar.bz2
4 packages and 0 specfiles checked; 10 errors, 15 warnings.
Can you look into the debuginfo errors? not sure if they need to be
fixed or not. Regarding the macros-in-comment warning, can probably
ignore that, as well the spelling-error's.
[ x ] MUST: The package must be named according to the Package Naming
Guidelines
[ x ] MUST: The spec file name must match the base package %{name} [...]
[ x ] MUST: The package must meet the Packaging Guidelines
[ x ] MUST: The package must be licensed with a Fedora approved license
and meet the Licensing Guidelines
Licensed under LGPLv2+, headers contain:
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
so clearly LGPLv2+, which matches spec file
[ x ] MUST: The License field in the package spec file must match the
actual license
COPYING contains text of LGPL version 2.1
[ x ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc
[ x ] MUST: The spec file must be written in American English.
[ x ] MUST: The spec file for the package MUST be legible.
[ ? ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
Can't test the MD5 checksums because the git command will check out
a different version of the code than the one uploaded in the SRPM,
unless the git command in
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|al...@users.sourceforge.net Flag||fedora-review? --- Comment #8 from Alex Lancaster al...@users.sourceforge.net 2010-10-19 02:36:05 EDT --- Taking review. Full review will be along soon, meanwhile, just running rpmlint, which looks good, only warnings which can be ignored. $ rpmlint libbluray-0.1-0.1.20100819.fc13.x86_64.rpm libbluray.x86_64: W: spelling-error %description -l en_US bluray - blurry, blurt, blurb libbluray.x86_64: W: spelling-error %description -l en_US embeddable - embedding, embedded, shreddable libbluray.x86_64: W: spelling-error %description -l en_US mplayer - player, m player, mp layer libbluray.x86_64: W: spelling-error %description -l en_US vlc - vac, voc, Vlad 1 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpmlint libbluray-devel-0.1-0.1.20100819.fc13.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #4 from Xavier Bachelot xav...@bachelot.org 2010-10-13 03:36:18 EDT --- Hi Spot, Legal team, Just a gentle reminder, is there any update on this ? I know you're all very busy, but this bug is stalled for almost 2 months now. Regards, Xavier -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #5 from Tom spot Callaway tcall...@redhat.com 2010-10-13 14:08:39 EDT --- Assuming this package doesn't enable playback of encrypted BD media, I don't think it is a problem, it seems to be analogous to libdvdread. Is that correct? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #6 from Xavier Bachelot xav...@bachelot.org 2010-10-13 14:31:30 EDT --- Yes, it's correct. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2010-10-13 14:35:42 EDT --- Then I'm lifting FE-Legal here. You probably don't want it blocking 625603 either, as that one is going to be blocked FE-Legal indefinitely. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2010-09-20 11:18:17 EDT --- One of the issue here is to determine if libbluray is useful without libaacs and libbdplus, as it would not meet the following guideline : https://fedoraproject.org/wiki/Packaging:Guidelines#Packages_which_are_not_useful_without_external_bits In others words, are we in a similar situation as for DVDs : libdvread is acceptable while libdvdcss is not. Indeed the commercial bluray discs offering is mostly composed of encrypted discs, and thus useless w/o libaacs and libbdplus. However there are now FOSS BD authoring tool and as such, we'll likely have more and more non-encrypted BDs. This post links to such a BD, made from well known free content (Elephant's Dream and Big Bug Bunny) : http://x264dev.multimedia.cx/?p=328 Just some food for thought when this bug will be reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #2 from Xavier Bachelot xav...@bachelot.org 2010-09-17 05:27:53 EDT --- Hi Legal team, any update on this ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #1 from Xavier Bachelot xav...@bachelot.org 2010-08-19 18:25:09 EDT --- Just for safety, make this bug block FE-LEGAL too, although the most sensitive package is libaacs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
