[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-09-01 01:53:48 EDT --- ghostscript-chinese-0.3.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghostscript-chinese-0.3.1-1 ||.fc14 Resolution||ERRATA Last Closed||2010-09-01 01:53:53 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-08-31 16:19:48 EDT --- ghostscript-chinese-0.3.1-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ghostscript-chinese'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ghostscript-chinese-0.3.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2010-08-31 01:01:07 EDT --- ghostscript-chinese-0.3.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghostscript-chinese-0.3.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 --- Comment #3 from Kevin Fenzi ke...@tummy.com 2010-08-29 15:00:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=625678
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review+
--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-08-25 04:57:00 EDT
---
Review:
+ Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2425290 is
successful.
+ rpmlint is output for SRPM and for RPM.
ghostscript-chinese.noarch: W: self-obsoletion cjkuni-fonts-ghostscript
obsoletes cjkuni-fonts-ghostscript = 0.2.20080216.1
ghostscript-chinese.src:24: W: unversioned-explicit-obsoletes
cjkuni-fonts-ghostscript
ghostscript-chinese.src: W: no-cleaning-of-buildroot %install
ghostscript-chinese.src: W: no-cleaning-of-buildroot %clean
ghostscript-chinese.src: W: no-buildroot-tag
ghostscript-chinese.src: W: no-%clean-section
ghostscript-chinese-zh_CN.noarch: W: no-documentation
ghostscript-chinese-zh_TW.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 8 warnings.
+ source files match upstream url (sha1sum)
a1192e567ab75e614e1292109cdae74470356b8d ghostscript-chinese-0.3.1.tar.gz
a1192e567ab75e614e1292109cdae74470356b8d ghostscript-chinese-0.3.1.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ Macro use appears rather consistent.
+ no translations are available
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
Suggestions:
1) Please see
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing.
According to it, subpackages should require main package as it installs
COPYING.
you can drop main package installing subpackages if not needed.
2) I think ghostscript is already above 8.63-4 version in Fedora so you can
drop versioned requires for ghostscript and just have
Requires: ghostscript
3) rpmlint showed self-obsoletion. See
http://fedoraproject.org/wiki/PackageNamingGuidelines#Renaming.2Freplacing_existing_packages
This can be fixed by using
Provides: cjkuni-fonts-ghostscript = %{version}
Obsoletes:cjkuni-fonts-ghostscript 0.2.20080216.1
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 --- Comment #2 from Peng Wu p...@redhat.com 2010-08-25 22:14:48 EDT --- New Package SCM Request === Package Name: ghostscript-chinese Short Description: Ghostscript Chinese fonts configuration files Owners: pwu Branches: F-13 F-14 InitialCC: petersen i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 Peng Wu p...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625678 Peng Wu p...@redhat.com changed: What|Removed |Added CC||i18n-b...@lists.fedoraproje ||ct.org AssignedTo|nob...@fedoraproject.org|panem...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
