[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Mohamed El Morabity changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #4 from Mohamed El Morabity 2010-12-28 00:59:13 EST --- *** Bug 665956 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 --- Comment #5 from Ankur Sinha 2010-12-28 01:25:51 EST --- Hello, Ah! I somehow missed this review. I packaged for personal use sometime back. The spec and srpm are here, if you want to reference them. It appears to be quite simple package. http://ankursinha.fedorapeople.org/detex/ Thanks, regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 --- Comment #6 from Christoph Wickert 2010-12-28 03:22:50 EST --- Usually we follow the rule "first come, first served" so I'd like Didi to finish this review instead of doing another one. Didi, you need help? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Christoph Wickert changed: What|Removed |Added Flag||needinfo?(d...@ribalba.de) --- Comment #7 from Christoph Wickert 2011-02-20 18:17:02 EST --- Didi, are you still there? Please respond to this review request, otherwise I think Ankur should take over. I'd like to see this package in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Didi Hoffmann changed: What|Removed |Added Flag|needinfo?(d...@ribalba.de) | --- Comment #8 from Didi Hoffmann 2011-02-21 05:38:37 EST --- Hey I sent you a mail ages ago. Let me write up all the changes I made and resubmit it here. I have taken Ankurs stuff into account. I really like this tool too. Give me a few min(hours) and I will post the new package. Cheers Didi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 --- Comment #9 from Christoph Wickert 2011-02-25 16:07:39 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Christoph Wickert changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|fedora-review? | Last Closed||2011-03-06 08:08:25 --- Comment #10 from Christoph Wickert 2011-03-06 08:08:25 EST --- Didi contacted me and told me that he is sorry to have no more time to maintain packages in Fedora because of his dayjob. Ankur, please file a new review request and submit your package. Then change the resolution of this bug to duplicate of yours. You can assign the review to me if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 --- Comment #11 from Ankur Sinha 2011-03-07 03:06:20 EST --- Hello! Aye aye Sir! I'll get down to this immediately. Thanks! Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Ankur Sinha changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #12 from Ankur Sinha 2011-03-07 03:09:52 EST --- *** This bug has been marked as a duplicate of bug 682666 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Didi Hoffmann changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Christoph Wickert changed: What|Removed |Added Status|NEW |ASSIGNED CC||cwick...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org Flag||fedora-review? --- Comment #1 from Christoph Wickert 2010-08-22 10:16:17 EDT --- I#m going to take this over, stay tuned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Lameire Alexis changed: What|Removed |Added CC||alexisis-pristont...@hotmai ||l.com --- Comment #2 from Lameire Alexis 2010-08-22 10:32:29 EDT --- Although this review is in progress, I see two (very) little issues: - on the summary, you must write TeX and LaTeX, not Tex/LaTex ;) - you should indent all the values in your preamble. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=626175
--- Comment #3 from Christoph Wickert 2010-10-31
10:24:40 EDT ---
I'm extremely sorry for the delay Didi!
REVIEW FOR 458b5603a1c21a383285e4aceeb4f6b7 detex-2.8-1.src.rpm
FIX - MUST: rpmlint must be run on every package.
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/detex-*
detex.src:24: W: setup-not-quiet
Use %setup -q instead of %setup
detex.src:32: W: macro-in-comment %{__make}
detex.src:32: W: macro-in-comment %{buildroot}
This is the line that is commented out, remove it. Macros in comments confuse
rpm. Even though things are commented out, the macros get resolved. When you
have a macro like %setup, that consists of several lines (use 'rpm --eval
%setup' to check), the build will break.
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57:
warning: numeric expression expected (got `,')
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: cannot
use a space as a starting delimiter
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a space)
detex.x86_64: W: manual-page-warning /usr/share/man/man1/detex.1.gz 57: normal
or special character expected (got a node)
Not sure about this one.
detex-debuginfo.x86_64: E: debuginfo-without-sources
Read http://fedoraproject.org/wiki/Packaging/Debuginfo
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (NCSA)
FIX - MUST: License field in spec file matches the actual license: According to
its http://www.cs.purdue.edu/homes/trinkle/detex/ NCSA not BSD.
FIX - MUST: license file is not included in %doc: Include the COPYRIGHT file in
%doc.
OK - MUST: spec is in American English
FIX - MUST: spec is legible, but could be better if the tags in the header were
properly indented.
OK - MUST: sources match the upstream source by MD5
7a96b647f43bb077323cde92faa1e893
FIX - MUST: does not successfully compile and build into binary rpms:
error: %patch without corresponding "Patch:" tag
You are using Patch0:, therefor the patch needs to be applied with %patch0 too,
not only %patch.
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates (none)
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static librar
