[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-10-21 02:01:05 EDT --- libmnetutil-0.8.0-0.2.20100629svn3775.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libmnetutil-0.8.0-0.2.20100 |libmnetutil-0.8.0-0.2.20100 |629svn3775.fc14 |629svn3775.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libmnetutil-0.8.0-0.2.20100 |libmnetutil-0.8.0-0.2.20100 |629svn3775.fc13 |629svn3775.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-10-19 05:09:50 EDT --- libmnetutil-0.8.0-0.2.20100629svn3775.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||libmnetutil-0.8.0-0.2.20100 ||629svn3775.fc14 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-10-11 05:47:53 EDT --- libmnetutil-0.8.0-0.2.20100629svn3775.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libmnetutil-0.8.0-0.2.20100629svn3775.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-10-11 05:48:00 EDT --- libmnetutil-0.8.0-0.2.20100629svn3775.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libmnetutil-0.8.0-0.2.20100629svn3775.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-10-11 05:48:06 EDT --- libmnetutil-0.8.0-0.2.20100629svn3775.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/libmnetutil-0.8.0-0.2.20100629svn3775.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-10-11 07:52:28 --- Comment #12 from Kalev Lember ka...@smartlink.ee 2010-10-11 07:52:28 EDT --- Closing the ticket as the packages are built and updates submitted; furthermore it's also easier to check bugzilla dependencies if this ticket is closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-10-10 00:26:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-10-08 16:30:58 EDT --- WARNING: Requested package name libnetmutil doesn't match bug summary libmnetutil Can you fix the bug summary and/or the package name in the request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Peter Lemenkov lemen...@gmail.com 2010-10-09 01:11:45 EDT --- New Package SCM Request === Package Name: libmnetutil Short Description: Minisip library providing various C++ network classes Owners: peter Branches: f12 f13 f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2010-10-07 03:54:49 EDT --- Thanks, Kalev! I was just going to ask you about reviewing a couple of my packages in exchange :) Ok, regarding your comments: 1. No I didnt' contact upstream yet, but I'll do it in a next weeks, I promise. 2. I have no plans for EL-5 yet, but I'd prefer to keep pkgconfig as a dependency (someone may consider grab my spec-file and rebuild with old rpmbuild - this might confuse him) 3. Likewise - I personally prefer to add dependency on directory owner instead of claiming ownership. New Package SCM Request === Package Name: libnetmutil Short Description: Minisip library providing various C++ network classes Owners: peter Branches: f12 f13 f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Status|NEW |ASSIGNED CC||ka...@smartlink.ee AssignedTo|nob...@fedoraproject.org|ka...@smartlink.ee Flag||fedora-review? Bug 626458 depends on bug 626446, which changed state. Bug 626446 Summary: Review Request: libmutil - A C++ library providing various utilities https://bugzilla.redhat.com/show_bug.cgi?id=626446 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #2 from Kalev Lember ka...@smartlink.ee 2010-10-06 15:54:38 EDT --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=626458
--- Comment #3 from Kalev Lember ka...@smartlink.ee 2010-10-06 16:33:04 EDT
---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2518427
I have a few initial comments, but none of them is a review blocker. Just some
small things you might want to change before importing the package into git.
How did upstream react to the libmnetutil-0001-Remove-bundled-udns.patch? Looks
like the patch removes all of the udns source files. If upstream doesn't want
to take the patch like this, another option would be to rework it so that the
configure script gets an option to choose between bundled or system copy of
udns.
%package devel
...
Requires: pkgconfig
In Fedora 12+ rpmbuild generates the pkgconfig dependency automatically for
subpackages which ship .pc files. It is however needed for EL5 and older. So if
you only intend to package it in Fedora, you might want to remove that line.
%package devel
...
Requires: automake
...
%files devel
...
%{_datadir}/aclocal/*.m4
A recent change in packaging guidelines suggests to use multiple directory
ownership to avoid dragging in other packages which wouldn't be otherwise
needed for normal functioning. I guess automake would fall under that category
too.
https://fedoraproject.org/wiki/Packaging/Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=626458
Kalev Lember ka...@smartlink.ee changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Kalev Lember ka...@smartlink.ee 2010-10-06 16:46:47 EDT
---
Fedora review libmnetutil-0.8.0-0.2.20100629svn3775.fc12.src.rpm 2010-10-06
+ OK
! needs attention
rpmlint output:
$ rpmlint libmnetutil \
libmnetutil-devel \
libmnetutil-0.8.0-0.2.20100629svn3775.fc15.src.rpm \
libmnetutil-debuginfo-0.8.0-0.2.20100629svn3775.fc15.i686.rpm
libmnetutil.i686: W: spelling-error Summary(en_US) Minisip - Mini sip,
Mini-sip, Minister
libmnetutil.i686: W: spelling-error %description -l en_US minisip - mini sip,
mini-sip, minister
libmnetutil.i686: W: unused-direct-shlib-dependency
/usr/lib/libmnetutil.so.0.0.0 /lib/libm.so.6
libmnetutil.src: W: spelling-error Summary(en_US) Minisip - Mini sip,
Mini-sip, Minister
libmnetutil.src: W: spelling-error %description -l en_US minisip - mini sip,
mini-sip, minister
libmnetutil.src: W: invalid-url Source0: libmnetutil-0.8.0.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
+ Rpmlint warnings are harmless and can be ignored
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
from upstream svn repo produce matching tarball.
0e0de89d8c816f7cc287816d95769230 libmnetutil-0.8.0.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Looks good, but take a look at comment #3 before importing into Fedora.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2010-09-26 04:30:31 EDT --- New build: http://peter.fedorapeople.org/libmnetutil.spec http://peter.fedorapeople.org/libmnetutil-0.8.0-0.2.20100629svn3775.fc12.src.rpm - Properly placed examples - Changed descriptions Finally cleaning up NotReady flag here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status Whiteboard||NotReady -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||626699 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||626701 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||626726 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||626462 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
