[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libmikey-0.8.0-0.2.20100127 ||svn3750.fc14 Resolution||ERRATA Last Closed||2010-11-08 17:34:54 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:34:49 EST --- libmikey-0.8.0-0.2.20100127svn3750.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:43:29 EST --- libmikey-0.8.0-0.2.20100127svn3750.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libmikey-0.8.0-0.2.20100127 |libmikey-0.8.0-0.2.20100127 |svn3750.fc14|svn3750.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:41:08 EST --- libmikey-0.8.0-0.2.20100127svn3750.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libmikey-0.8.0-0.2.20100127 |libmikey-0.8.0-0.2.20100127 |svn3750.fc12|svn3750.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-10-31 17:31:46 EDT --- libmikey-0.8.0-0.2.20100127svn3750.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libmikey'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-10-30 19:20:24 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-10-31 01:40:38 EDT --- libmikey-0.8.0-0.2.20100127svn3750.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-10-31 01:40:32 EDT --- libmikey-0.8.0-0.2.20100127svn3750.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-10-31 01:40:45 EDT --- libmikey-0.8.0-0.2.20100127svn3750.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ka...@smartlink.ee Flag||fedora-review? --- Comment #3 from Kalev Lember ka...@smartlink.ee 2010-10-29 04:25:00 EDT --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=626701
Kalev Lember ka...@smartlink.ee changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Kalev Lember ka...@smartlink.ee 2010-10-29 05:31:37 EDT
---
Fedora review libmikey-0.8.0-0.2.20100127svn3750.fc12.src.rpm 2010-10-29
+ OK
! needs attention
rpmlint output:
$ rpmlint libmikey \
libmikey-devel \
libmikey-0.8.0-0.2.20100127svn3750.fc15.src.rpm \
libmikey-debuginfo-0.8.0-0.2.20100127svn3750.fc15.i686.rpm
libmikey.i686: W: unused-direct-shlib-dependency /usr/lib/libmikey.so.0.0.0
/usr/lib/libmnetutil.so.0
libmikey.i686: W: unused-direct-shlib-dependency /usr/lib/libmikey.so.0.0.0
/lib/libm.so.6
libmikey-devel.i686: W: no-documentation
libmikey.src: W: invalid-url Source0: libmikey-0.8.0.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ Rpmlint warnings are mostly harmless.
If you want to, you can try fixing libmnetutil.so.0 dependency,
but this is certainly not a review blocker.
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
from upstream svn repo produce matching tarball.
b22c89a5e1d5745149a23e0e1527ceee ../SOURCES/libmikey-0.8.0.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Looks good. Please don't forget to send the build fix patch upstream.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2010-10-29 06:38:57 EDT --- Thanks, Kalev! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Peter Lemenkov lemen...@gmail.com 2010-10-29 06:41:59 EDT --- New Package SCM Request === Package Name: libmikey Short Description: A C++ library implementing the Multimedia Internet KEYing protocol Owners: peter Branches: f12 f13 f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status Whiteboard|NotReady| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 --- Comment #2 from Peter Lemenkov lemen...@gmail.com 2010-10-25 05:28:47 EDT --- Fixed. http://peter.fedorapeople.org/libmikey.spec http://peter.fedorapeople.org/libmikey-0.8.0-0.2.20100127svn3750.fc12.src.rpm Koji build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2551934 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Bug 626701 depends on bug 626699, which changed state. Bug 626699 Summary: Review Request: libmcrypto - A C++ library providing various cryptography related utilities https://bugzilla.redhat.com/show_bug.cgi?id=626699 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added CC||ka...@smartlink.ee --- Comment #1 from Kalev Lember ka...@smartlink.ee 2010-10-13 12:40:24 EDT --- All deps of libmikey appear to be in rawhide now. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2532858 failed with the following error: mikey/MikeyCsIdMap.cxx: In constructor 'MikeyCsIdMapSrtp::MikeyCsIdMapSrtp()': mikey/MikeyCsIdMap.cxx:39:44: error: cannot call constructor 'std::vectorMikeySrtpCs*::vector' directly mikey/MikeyCsIdMap.cxx:39:44: error: for a function-style cast, remove the redundant '::vector' mikey/MikeyCsIdMap.cxx: In constructor 'MikeyCsIdMapIPSEC4::MikeyCsIdMapIPSEC4()': mikey/MikeyCsIdMap.cxx:44:42: error: cannot call constructor 'std::listMikeyIPSEC4Cs*::list' directly mikey/MikeyCsIdMap.cxx:44:42: error: for a function-style cast, remove the redundant '::list' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Bug 626701 depends on bug 626446, which changed state. Bug 626446 Summary: Review Request: libmutil - A C++ library providing various utilities https://bugzilla.redhat.com/show_bug.cgi?id=626446 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED Bug 626701 depends on bug 626458, which changed state. Bug 626458 Summary: Review Request: libmnetutil - A C++ library providing various network utilities https://bugzilla.redhat.com/show_bug.cgi?id=626458 What|Old Value |New Value Resolution||NEXTRELEASE Status|MODIFIED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626701] Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626701 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Depends on||626446, 626458, 626699 Status Whiteboard||NotReady -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
