[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #17 from Fedora Update System 2011-03-28 23:48:03 EDT --- ghc-ranges-0.2.3-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Fedora Update System changed: What|Removed |Added Fixed In Version||ghc-ranges-0.2.3-2.fc15 Resolution|RAWHIDE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #18 from Fedora Update System 2011-04-02 18:49:54 EDT --- ghc-ranges-0.2.3-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-ranges-0.2.3-1.fc14 |ghc-ranges-0.2.3-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-ranges-0.2.3-2.fc15 |ghc-ranges-0.2.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #19 from Fedora Update System 2011-04-02 18:52:31 EDT --- ghc-ranges-0.2.3-1.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #1 from Lakshmi Narasimhan 2010-12-19 07:47:59 EST --- Ben, The LICENSE file has this text "Do what you will." I think it will be better if we can ask the author to get the proper BSD 3clause variant license packaged with the sources. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #2 from Lakshmi Narasimhan 2010-12-19 08:03:05 EST --- Review is complete. The license text issue is blocking. Other things look fine. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #3 from Lakshmi Narasimhan 2011-01-02 03:19:47 EST --- A mail has been sent to upstream requesting to add the correct license text to the source package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #4 from Lakshmi Narasimhan 2011-01-16 23:29:31 EST --- The package author has upgraded the package to new version that includes the LICENSE file. http://hackage.haskell.org/packages/archive/ranges/0.2.3/ranges-0.2.3.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Lakshmi Narasimhan changed: What|Removed |Added Flag||needinfo?(maths...@gmail.co ||m) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Ben Boeckel changed: What|Removed |Added Status|NEW |ASSIGNED Flag|needinfo?(maths...@gmail.co | |m) | --- Comment #5 from Ben Boeckel 2011-01-28 23:32:54 EST --- Spec URL: http://benboeckel.net/packaging/ghc-ranges/ghc-ranges.spec SRPM URL: http://benboeckel.net/packaging/ghc-ranges/ghc-ranges-0.2.3-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630278
Lakshmi Narasimhan changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #6 from Lakshmi Narasimhan 2011-01-29
01:23:23 EST ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i ghc-ranges-*.rpm ../ghc-ranges.spec
ghc-ranges.src: W: spelling-error %description -l en_US lookup -> lockup,
hookup, look up
The value of this tag appears to be misspelled. Please double-check.
ghc-ranges.src: W: strange-permission ranges-0.2.3.tar.gz 0640L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
ghc-ranges.src: W: strange-permission ghc-ranges.spec 0640L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
ghc-ranges.x86_64: W: spelling-error %description -l en_US lookup -> lockup,
hookup, look up
The value of this tag appears to be misspelled. Please double-check.
ghc-ranges.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/ghc-ranges-0.2.3/LICENSE
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.
ghc-ranges-devel.x86_64: W: spelling-error %description -l en_US lookup ->
lockup, hookup, look up
The value of this tag appears to be misspelled. Please double-check.
ghc-ranges-prof.x86_64: E: devel-dependency ghc-ranges-devel
Your package has a dependency on a devel package but it's not a devel package
itself.
ghc-ranges-prof.x86_64: W: spelling-error %description -l en_US lookup ->
lockup, hookup, look up
The value of this tag appears to be misspelled. Please double-check.
ghc-ranges-prof.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-ranges-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/ranges-0.2.3/libHSranges-0.2.3_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
4 packages and 1 specfiles checked; 1 errors, 9 warnings.
Please use the patch to fix the line endings warning
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK, BSD 3 clause, LICENSE file has been updated in v0.2.3
No prebuilt external bits - OK
Spec legibity - OK, attached a patch to remove some lines that are not
necessary
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK
%clean is ignored - present anyway. OK
Build Requires list - OK
Summary and description - OK
API documentation - OK, present in devel package
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Yes, included. But the license text is not proper. Asked the package reviewer
to get the proper license text included as part of the sources. The LICENSE
file is updated in version 0.2.3
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum built/ghc-ranges-0.2.3-1.fc14.src/ranges-0.2.3.tar.gz
b2e6b2fbcf74e2ac79ee9f422aeda0f3
built/ghc-ranges-0.2.3-1.fc14.src/ranges-0.2.3.tar.gz
md5sum ranges-0.2.3.tar.gz
b2e6b2fbcf74e2ac79ee9f422aeda0f3 ranges-0.2.3.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Yes, built on x86_64.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2748694
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handl
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #8 from Lakshmi Narasimhan 2011-01-29 01:25:36 EST --- Also, please upgrade to cabal2spec-0.22.4 while committing the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #7 from Lakshmi Narasimhan 2011-01-29 01:24:10 EST --- Created attachment 475923 --> https://bugzilla.redhat.com/attachment.cgi?id=475923 patch to fix line endings in LICENSE file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Ben Boeckel changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Ben Boeckel 2011-01-29 12:15:36 EST --- New Package CVS Request === Package Name: ghc-ranges Short Description: Ranges and various functions on them Owners: mathstuf Branches: F-13 F-14 Thanks. InitialCC: haskell-sig(In reply to comment #8) > Also, please upgrade to cabal2spec-0.22.4 while committing the spec file. Will do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #10 from Dennis Gilmore 2011-01-30 19:01:57 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Lakshmi Narasimhan changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #11 from Lakshmi Narasimhan 2011-03-05 20:03:04 EST --- Rawhide build http://koji.fedoraproject.org/koji/buildinfo?buildID=228283 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Lakshmi Narasimhan changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||RAWHIDE Last Closed||2011-03-05 20:56:28 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Lakshmi Narasimhan changed: What|Removed |Added Flag||needinfo?(maths...@gmail.co ||m) --- Comment #12 from Lakshmi Narasimhan 2011-03-05 21:20:52 EST --- Hi Ben, Can you submit updates of ghc-ranges for F15,F14 and F13? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Ben Boeckel changed: What|Removed |Added Flag|needinfo?(maths...@gmail.co | |m) | --- Comment #13 from Ben Boeckel 2011-03-24 12:31:42 EDT --- Building for F15 now. Will submit when it finishes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #16 from Fedora Update System 2011-03-24 12:39:21 EDT --- ghc-ranges-0.2.3-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ghc-ranges-0.2.3-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #14 from Fedora Update System 2011-03-24 12:39:06 EDT --- ghc-ranges-0.2.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-ranges-0.2.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 --- Comment #15 from Fedora Update System 2011-03-24 12:39:13 EDT --- ghc-ranges-0.2.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-ranges-0.2.3-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630278] Review Request: ghc-ranges - Ranges and various functions on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630278 Ben Boeckel changed: What|Removed |Added Blocks||630279 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
