[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-10-08 16:38:43 EDT --- fatrat-1.1.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-10-08 23:31:36 EDT --- fatrat-1.1.3-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-09-29 06:51:02 EDT --- fatrat-1.1.3-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/fatrat-1.1.3-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-09-29 06:52:13 EDT --- fatrat-1.1.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fatrat-1.1.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-09-27 07:31:08 EDT --- fatrat-1.1.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fatrat-1.1.2-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-09-27 07:29:37 EDT --- fatrat-1.1.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/fatrat-1.1.2-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 Jan Vcelak jvce...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-09-27 07:39:07 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 --- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-09-25 00:59:50 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=631898
Jan Vcelak jvce...@redhat.com changed:
What|Removed |Added
Flag|needinfo?(jvce...@redhat.co |needinfo?(jkal...@redhat.co
|m) |m)
--- Comment #2 from Jan Vcelak jvce...@redhat.com 2010-09-23 07:30:45 EDT ---
(In reply to comment #1)
If you don't plan to have Fatrat in EPEL5 and below, you do not need to define
BuildRoot:... anymore, rpmbuild will use a sane one automatically (since
F-10).
You also do not need to clean the buildroot manually at the beginning of
%install (since F-10).
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
I don't think this is critical. And I would rather leave both things there
(BuildRoot and clean), if someone wanted to build it for older Fedora or EPEL.
In addition, removing these will emit new rpmlint warnings.
[ERR] GUI app must include a %{name}.desktop and use desktop-file-install
$desktop-file-validate fatrat.desktop
fatrat.desktop: warning: value Application;Network; for key Categories
in group Desktop Entry contains a deprecated value Application
fatrat.desktop: warning: value fatrat.png for key Icon in group
Desktop Entry is an icon name with an extension, but there should be no
extension as described in the Icon Theme Specification if the value is not
an absolute path
I'm not sure if that's real problem, but it would be fine to have it fixed.
This is being fixed during %install. See the lines under update desktop file
comment. The binary package contains valid desktop file.
(I'm using sed to fix it, as desktop-file-install can't handle that.)
[ERR] Icon tag in Desktop Files
mentioned above
Above as well. ;-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 Jan Kaluža jkal...@redhat.com changed: What|Removed |Added Flag|fedora-review?, |fedora-review+ |needinfo?(jkal...@redhat.co | |m) | --- Comment #3 from Jan Kaluža jkal...@redhat.com 2010-09-23 07:48:10 EDT --- You're right. I think it's OK then. Consider the package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631898] Review Request: fatrat - Feature-rich download manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631898 Jan Vcelak jvce...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jan Vcelak jvce...@redhat.com 2010-09-23 08:13:59 EDT --- New Package SCM Request === Package Name: fatrat Short Description: Feature-rich download manager Owners: jvcelak Branches: f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
