[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #12 from Chen Lei  2010-10-19 12:06:20 EDT 
---
I'll update libmeegotouch to 0.20.4x soon which is target for Meego 1.2. Since
Meego haven't released Tablet UX yet, we still have a lot of time to package
MTF stack packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

Chen Lei  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|NOTABUG |
   Keywords||Reopened

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

Chen Lei  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG
Last Closed||2010-10-06 23:45:15

--- Comment #11 from Chen Lei  2010-10-06 23:45:15 EDT 
---
(In reply to comment #10)
> >rpmlint libmeegotouch-0.20.25-2.fc14.x86_64.rpm
> 
> libmeegotouch.x86_64: W: shared-lib-calls-exit
> /usr/lib64/libmeegotouchcore.so.0.20.24 e...@glibc_2.2.5
> Not OK, please comment/fix.
> 
This won't be a serious issue, I think it's safe to ignore this warning. Many
core libraries use exit() function actually. 

> 
> libmeegotouch.x86_64: E: non-standard-dir-perm /var/cache/meegotouch 01777L
> Not OK, is it really needed to pre-create cache dir with these permissions?
> 
1777 is better than 777, this directory should be written by normal users.

> 
> Summary - not OK (need comment/fix).

How to fix?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #10 from Jaroslav Reznik  2010-10-05 04:57:53 
EDT ---
>rpmlint libmeegotouch-0.20.25-2.fc14.x86_64.rpm

libmeegotouch.x86_64: W: shared-lib-calls-exit
/usr/lib64/libmeegotouchcore.so.0.20.24 e...@glibc_2.2.5
Not OK, please comment/fix.

libmeegotouch.x86_64: W: non-conffile-in-etc /etc/profile.d/libmeegotouch.sh
libmeegotouch.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/meegotouch.schemas
OK

libmeegotouch.x86_64: E: non-standard-dir-perm /var/cache/meegotouch 01777L
Not OK, is it really needed to pre-create cache dir with these permissions?

libmeegotouch.x86_64: W: no-manual-page-for-binary mthemedaemon
libmeegotouch.x86_64: W: no-manual-page-for-binary mservicemapper
OK
libmeegotouch.x86_64: W: dangerous-command-in-%pre rm
libmeegotouch.x86_64: W: dangerous-command-in-%post rm
OK, probably comes from %gconf_schema_upgrade
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets)

>rpmlint libmeegotouch-qtstyle-0.20.25-2.fc14.x86_64.rpm 

libmeegotouch-qtstyle.x86_64: W: spelling-error Summary(en_US) plugin -> plug
in, plug-in, plugging
libmeegotouch-qtstyle.x86_64: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
OK

libmeegotouch-qtstyle.x86_64: W: no-documentation
OK, in main package

libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstylekinetic
libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstyledialogs
libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstyleexample
OK

> rpmlint libmeegotouch-devel-0.20.25-2.fc14.x86_64.rpm 
libmeegotouch-devel.x86_64: W: no-documentation
OK

libmeegotouch-devel.x86_64: W: spurious-executable-perm
/usr/include/meegotouch/mrichtexteditstyle.h
Fix it, please.

libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mapplettester
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary
mapplicationextensiontester
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary dui-rename-files
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mgen
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mnotificationtool
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary widgetsgallery
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary dui-rename-symbols
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mmoc
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mmoc.pl
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary m-servicefwgen
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary
mnotificationstresstest
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary animatedlayout
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary
applicationextensiondemo

OK

Summary - not OK (need comment/fix).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #9 from Jaroslav Reznik  2010-10-05 04:40:16 
EDT ---
rpmlint libmeegotouch.spec 

libmeegotouch.spec:92: W: configure-without-libdir-spec
OK, libdir specified

libmeegotouch.spec: W: no-cleaning-of-buildroot %clean
libmeegotouch.spec: W: no-buildroot-tag
libmeegotouch.spec: W: no-%clean-section
OK, F14+ only

libmeegotouch.spec: W: invalid-url Source0: libmeegotouch-0.20.25.tar.bz2
OK, extracted from upstream src.rpm, commented

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #8 from Jaroslav Reznik  2010-10-05 03:44:36 
EDT ---
> > Still there's an issue with fdupes probably.
> > 
> > + %fdupes 
> > /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
> > /var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
> > RPM build errors:
> > error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
> > Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
> 
> You may use SRPM from meego upstream, %fudpes is a SUSE specific macro.
> 
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2506423

Ah, sorry - you're right, by mistake I used upstream src.rpm :( (Downloaded in
a same directory).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #7 from Chen Lei  2010-10-05 02:56:58 EDT ---
(In reply to comment #5)
> Created attachment 451396 [details]
> qmake in qtdir to qmake-qt4
> 
> I'm able to build it with this patch - it directly takes qmake-qt4 (not qmake 
> -
> it's qt 3 one!).

I don't think this patch is needed, my latest spec already export QTDIR before
./configure.


(In reply to comment #6)
> Created attachment 451421 [details]
> widgetsgallery demo dso - librt
> 
> This patch fixes librt DSO.
> 
> Still there's an issue with fdupes probably.
> 
> + %fdupes 
> /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
> /var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
> RPM build errors:
> error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
> Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)

You may use SRPM from meego upstream, %fudpes is a SUSE specific macro.


http://koji.fedoraproject.org/koji/taskinfo?taskID=2506423

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #6 from Jaroslav Reznik  2010-10-04 10:54:00 
EDT ---
Created attachment 451421
  --> https://bugzilla.redhat.com/attachment.cgi?id=451421
widgetsgallery demo dso - librt

This patch fixes librt DSO.

Still there's an issue with fdupes probably.

+ %fdupes /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
/var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #4 from Jaroslav Reznik  2010-10-04 08:55:16 
EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > Patches: do we really need all patches? at least missing-Epoch-function is 
> > not
> > needed anymore as we have Qt 4.7, please update
> 
> I removed patch5 from spec. All other patches are remained, they are all
> extracted from upstream SRPM, I think it'll be easier to track upstream RPM 
> and
> bugzilla system closely. 

Agreed.

> Currently, I track F14 with Meego 1.1 which will be released on 2010-10-27.

It's getting closer! 

> > Build: not ok
> > 
> > + ./configure -prefix /usr -libdir /usr/lib64 -release
> > 
> > QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
> > If your Qt is in a nonstandard location, try:
> > QTDIR= ./configure
> > error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)
> > 
> It's weird, I can build the package in rawhide koji. Maybe this issue is
> trigger once the system has both qt3-devel and qt-devel installed.

I'll check it - it should call qmake-qt4.

> > 
> > PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm 
> > Qt
> > co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
> > Thanks.
> 
> OK, please also apply co-maintainer for exsited meego packages in pkgdb(e.g.
> libaccounts-glib libaccounts-qt contextkit libqttracker).

Great, applied.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #5 from Jaroslav Reznik  2010-10-04 09:13:05 
EDT ---
Created attachment 451396
  --> https://bugzilla.redhat.com/attachment.cgi?id=451396
qmake in qtdir to qmake-qt4

I'm able to build it with this patch - it directly takes qmake-qt4 (not qmake -
it's qt 3 one!).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #3 from Chen Lei  2010-10-01 11:57:02 EDT ---
New Links:

http://dl.dropbox.com/u/1338197/1/libmeegotouch-0.20.25-2.fc13.src.rpm
http://dl.dropbox.com/u/1338197/1/libmeegotouch.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-10-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #2 from Chen Lei  2010-10-01 09:24:01 EDT ---
(In reply to comment #1)
> Patches: do we really need all patches? at least missing-Epoch-function is not
> needed anymore as we have Qt 4.7, please update

I removed patch5 from spec. All other patches are remained, they are all
extracted from upstream SRPM, I think it'll be easier to track upstream RPM and
bugzilla system closely. 

Currently, I track F14 with Meego 1.1 which will be released on 2010-10-27.

> Build: not ok
> 
> + ./configure -prefix /usr -libdir /usr/lib64 -release
> 
> QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
> If your Qt is in a nonstandard location, try:
> QTDIR= ./configure
> error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)
> 
It's weird, I can build the package in rawhide koji. Maybe this issue is
trigger once the system has both qt3-devel and qt-devel installed.

> 
> PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt
> co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
> Thanks.

OK, please also apply co-maintainer for exsited meego packages in pkgdb(e.g.
libaccounts-glib libaccounts-qt contextkit libqttracker).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #1 from Jaroslav Reznik  2010-09-29 09:39:14 
EDT ---
Name: ok
Summary: ok
Version & Release: ok
Group: ok
License: ok
URL: ok
Sources: caedf70a5851e2d1e1e9c282f40c841a ok
Patches: do we really need all patches? at least missing-Epoch-function is not
needed anymore as we have Qt 4.7, please update
Requires & BuildRequires: XXX
Description: ok
Build: not ok

+ ./configure -prefix /usr -libdir /usr/lib64 -release

QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
If your Qt is in a nonstandard location, try:
QTDIR= ./configure
error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)


PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt
co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-09-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

Jaroslav Reznik  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jrez...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

Chen Lei  changed:

   What|Removed |Added

 Blocks||614297

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review