[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
https://bugzilla.redhat.com/show_bug.cgi?id=632856 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Whiteboard|AwaitingSubmitter | Last Closed||2013-05-20 10:38:34 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uq2bOmCOgea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632856 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC|fedora-package-review@redha |package-review@lists.fedora |t.com |project.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632856 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #8 from Thomas Spura toms...@fedoraproject.org 2011-10-06 18:50:49 EDT --- (In reply to comment #7) Of course ; I was only providing a pointer that the package is still current. Providing a pointer, that Robert is right and there should be a new one with changes. Will there be new one? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632856
--- Comment #4 from Robert Scheck redhat-bugzi...@linuxnetz.de 2011-04-26
18:27:13 EDT ---
Fedora dislikes the usage of %global for %{name}, %{version}, %{release} and
other basic things, because Name: xinput_calibrator brings the same result
as %global name xinput_calibrator, so please correct this accordingly.
There is no need to set %{_prefix} for yourself, because did you ever have a
look to what %configure expands? And there is also no need for the parameters
you added, because of this:
$ rpm --eval '%configure'
CFLAGS=${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic} ; export
CFLAGS ;
CXXFLAGS=${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic} ; export
CXXFLAGS ;
FFLAGS=${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules} ; export FFLAGS ;
./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
\
--program-prefix= \
--disable-dependency-tracking \
--prefix=/usr \
--exec-prefix=/usr \
--bindir=/usr/bin \
--sbindir=/usr/sbin \
--sysconfdir=/etc \
--datadir=/usr/share \
--includedir=/usr/include \
--libdir=/usr/lib64 \
--libexecdir=/usr/libexec \
--localstatedir=/var \
--sharedstatedir=/var/lib \
--mandir=/usr/share/man \
--infodir=/usr/share/info
%
If the expansion does not fit for you, your build system is misconfigured or
not set up as it should be.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632856
Robert Scheck redhat-bugzi...@linuxnetz.de changed:
What|Removed |Added
CC||redhat-bugzilla@linuxnetz.d
||e
--- Comment #2 from Robert Scheck redhat-bugzi...@linuxnetz.de 2011-04-25
13:52:06 EDT ---
Some thoughts:
- Why do you need the %global usage (first 4 lines)?
- Why %configure --prefix=%{_prefix} --libdir=%{_libdir} rather
%configure?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632856 --- Comment #3 from Dave Ludlow d...@adsllc.com 2011-04-25 14:31:05 EDT --- Robert: The %global statements are used to make it so that information is specified once instead of scattered throughout the file. It also makes maintainability easier since you can confidently change the information without worrying about subtle side effects. See also: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define The prefix and libdir are specified so that the files are installed to /usr/bin and /usr/lib* instead of /usr/local/bin and /usr/local/lib*. Packages install their files into /usr, hand-compiled programs install their files into /usr/local. See also the '/usr/local' section of: http://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/usr.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632856 --- Comment #1 from Dave Ludlow d...@adsllc.com 2010-09-11 12:00:07 EDT --- RPMLINT $ rpmlint SPECS/xinput_calibrator.spec RPMS/x86_64/xinput_calibrator-*0.7* SRPMS/xinput_calibrator-0.7.0-1.fc13.src.rpm xinput_calibrator.x86_64: W: spelling-error %description -l en_US xinput - input, x input, Xingu xinput_calibrator.x86_64: W: spelling-error %description -l en_US xorg - xor, org, borg xinput_calibrator.x86_64: W: spelling-error %description -l en_US udev - udder, Udine, Aude xinput_calibrator.x86_64: W: spelling-error %description -l en_US evdev - evade, evident, evidence xinput_calibrator-debuginfo.x86_64: W: spelling-error Summary(en_US) xinput - input, x input, Xingu xinput_calibrator-debuginfo.x86_64: W: spelling-error %description -l en_US xinput - input, x input, Xingu xinput_calibrator.src: W: spelling-error %description -l en_US xinput - input, x input, Xingu xinput_calibrator.src: W: spelling-error %description -l en_US xorg - xor, org, borg xinput_calibrator.src: W: spelling-error %description -l en_US udev - udder, Udine, Aude xinput_calibrator.src: W: spelling-error %description -l en_US evdev - evade, evident, evidence 3 packages and 1 specfiles checked; 0 errors, 10 warnings. Warnings discussion: The spell-checker is being overzealous with proper names; everything is fine. KOJI http://koji.fedoraproject.org/koji/taskinfo?taskID=2461650 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
