[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #15 from Fedora Update System 2010-10-28 02:15:08 EDT --- spew-1.0.8-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Fedora Update System changed: What|Removed |Added Fixed In Version|spew-1.0.8-3.fc13 |spew-1.0.8-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Fedora Update System changed: What|Removed |Added Fixed In Version|spew-1.0.8-3.fc12 |spew-1.0.8-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #14 from Fedora Update System 2010-10-27 18:55:56 EDT --- spew-1.0.8-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #13 from Fedora Update System 2010-10-27 18:29:37 EDT --- spew-1.0.8-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||spew-1.0.8-3.fc12 Resolution||ERRATA Last Closed||2010-10-27 18:29:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2010-10-01 21:13:30 EDT --- spew-1.0.8-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spew'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #10 from Fedora Update System 2010-10-01 12:34:49 EDT --- spew-1.0.8-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #9 from Fedora Update System 2010-10-01 12:34:43 EDT --- spew-1.0.8-3.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #11 from Fedora Update System 2010-10-01 12:34:56 EDT --- spew-1.0.8-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #8 from Kevin Fenzi 2010-09-20 23:44:51 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 David Nalley changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from David Nalley 2010-09-19 20:26:07 EDT --- Martin: Thanks for the review!! New Package SCM Request === Package Name: spew Short Description: I/O performance measurement and load generation tool Owners: ke4qqq Branches: f12 f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634258
Martin Gieseking changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Martin Gieseking 2010-09-16
12:36:03 EDT ---
Here's the formal review. Since I couldn't find any further issues, the package
is ready now.
$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv2 according to source file headers
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) must be included in
%doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum spew-1.0.8.tgz*
02058dd1814caa8c67b8405668e845b2 spew-1.0.8.tgz
02058dd1814caa8c67b8405668e845b2 spew-1.0.8.tgz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files must call ldconfig in %post and
%postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: .so files (without suffix) must go in a -devel package.
[.] MUST: devel packages must require the base package.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
- seems to work properly
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Subpackages other than devel should require the base package.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: your package should contain man pages for binaries/scripts.
Package APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Martin Gieseking changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de Flag||fedora-review? --- Comment #5 from Martin Gieseking 2010-09-16 12:11:23 EDT --- OK, the package looks fine now. I'm going to do the formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #4 from David Nalley 2010-09-16 09:18:52 EDT --- - Dropped ncurses as a requires - dropped install from doc - added blank line between changelog entries Spec URL: http://ke4qqq.fedorapeople.org/spew.spec SRPM URL: http://ke4qqq.fedorapeople.org/spew-1.0.8-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #3 from Martin Gieseking 2010-09-16 04:11:06 EDT --- Here are some more (minor) notes: - You can drop "Requires: ncurses" as none of the ncurses command-line tools seem to be used. The package containing the ncurses libraries (ncurses-libs) is added automatically as a dependency. - drop file INSTALL from %doc (it's not of much use in a binary package) - add a blank line between the %changlog revisions to increase legibility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #2 from David Nalley 2010-09-15 16:37:49 EDT --- Thanks for taking a look! The scratch build uncovered a few BR problems. I fixed the remaining items Spec URL: http://ke4qqq.fedorapeople.org/spew.spec SRPM URL: http://ke4qqq.fedorapeople.org/spew-1.0.8-2.fc13.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2470085 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634258
Terje Røsten changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #1 from Terje Røsten 2010-09-15 16:03:26
EDT ---
Looks good, some small comments:
- list bins more explicit (like the mans)
- list man like this: %{_mandir}/man1/gorge.1*
- Group: Applications/Internet seems a bit strange?
- remove leading space in second line in %description
- nice if you could provide a scratch build
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
