[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-10-14 02:28:01 EDT --- libphidget-2.1.7.20100621-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libphidget-2.1.7.20100621-5 |libphidget-2.1.7.20100621-5 |.fc14 |.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-10-14 02:37:51 EDT --- libphidget-2.1.7.20100621-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libphidget-2.1.7.20100621-5 |libphidget-2.1.7.20100621-5 |.fc13 |.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-10-12 08:46:43 EDT --- libphidget-2.1.7.20100621-5.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libphidget-2.1.7.20100621-5 ||.fc14 Resolution||ERRATA Last Closed||2010-10-12 08:46:48 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-10-03 23:18:02 EDT --- libphidget-2.1.7.20100621-5.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/libphidget-2.1.7.20100621-5.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-10-03 23:17:55 EDT --- libphidget-2.1.7.20100621-5.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libphidget-2.1.7.20100621-5.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-10-03 23:18:08 EDT --- libphidget-2.1.7.20100621-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libphidget-2.1.7.20100621-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-09-27 09:09:39 EDT --- libphidget-2.1.7.20100621-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libphidget-2.1.7.20100621-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-09-27 16:07:46 EDT --- libphidget-2.1.7.20100621-4.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libphidget'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libphidget-2.1.7.20100621-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #9 from Kevin Fenzi ke...@tummy.com 2010-09-25 01:02:31 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635515
--- Comment #4 from Peter Lemenkov lemen...@gmail.com 2010-09-21 04:27:41 EDT
---
Ok, we almost finished, but now you'd better to split off java-part into its
own sub-package.
Also there are some new issues:
* You need to install into %{_javadir} instead of %{_jnidir}. Take a look at
the following link:
https://fedoraproject.org/wiki/Packaging:Java#Directory_structure
* You need to add Requires: udev (owner of %{_sysconfdir}/udev/rules.d)
* You also need to add necessary (Build)Requires for java-related stuff. See
this link for details:
https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #5 from Rich Mattes richmat...@gmail.com 2010-09-21 08:41:52 EDT --- Thanks, I split the java stuff into its own subpackage and corrected the issues you pointed out. The package builds fine for me in mock (fedora-13-x86_64.) The new spec and SRPM are available here: Spec URL: http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget-2.1.7.20100621-3.fc13.src.rpm $ rpmlint ../RPMS/x86_64/libphidget-* ../SRPMS/libphidget-* libphidget.x86_64: W: spelling-error %description -l en_US Phidgets - Fidgets libphidget-devel.x86_64: W: no-documentation libphidget-java.x86_64: W: no-documentation libphidget.src: W: spelling-error %description -l en_US Phidgets - Fidgets 5 packages and 0 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Peter Lemenkov lemen...@gmail.com 2010-09-21 08:50:36 EDT --- Ok, I don't see any other issues so far. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #7 from Rich Mattes richmat...@gmail.com 2010-09-21 10:55:15 EDT --- Thanks for the quick review Peter! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635515 --- Comment #8 from Rich Mattes richmat...@gmail.com 2010-09-21 10:55:44 EDT --- New Package SCM Request === Package Name: libphidget Short Description: Drivers and API for Phidget devices Owners: rmattes Branches: f12 f13 f14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635515
--- Comment #3 from Rich Mattes richmat...@gmail.com 2010-09-20 20:48:55 EDT
---
Thanks for taking on the review!
I've enabled zeroconf, zeroconf-lookup, and am now using the ldconfig switch.
I added the patch to keep the buildsystem from trying to rm old versions of
itself, and commented out the ldconfig stuff cause i was already in there.
I've dropped the patches (and the calls to aclocal and libtoolize.) I've also
installed the udev rules.
--enable-jni didn't seem to do anything, but I did a little digging and the
.jar file has a separate make target. I've enabled it and installed the .jar
file to the jnidir. I'm not really sure what to do with the resulting .jar
file: the packaging guidelines say that the .jar file should be installed in
%{_libdir}/%{name}, but then it goes on to outline the %{_jnidir}. I've put
the .jar in the jnidir for now. If it's wrong, I'll fix or remove it.
Spec URL: http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget-2.1.7.20100621-2.fc13.src.rpm
$ rpmlint ../RPMS/x86_64/libphidget-* ../SRPMS/libphidget*
libphidget.x86_64: W: spelling-error %description -l en_US Phidgets - Fidgets,
Midgets, Widgets
libphidget-devel.x86_64: W: no-documentation
libphidget.src: W: spelling-error %description -l en_US Phidgets - Fidgets,
Midgets, Widgets
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
