[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #2 from Dennis Gilmore  2011-01-06 21:41:42 EST ---
Spec URL: http://ausil.us/packages/yubikey-ksm.spec
SRPM URL: http://ausil.us/packages/yubikey-ksm-1.5-3.fc15.src.rpm

added requires on php-pdo
moved the htaccess file to docs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Ricky Zhou  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|rz...@redhat.com
   Flag||fedora-review+

--- Comment #3 from Ricky Zhou  2011-01-07 20:46:31 EST ---
X - rpmlint clean (normal google code warning)

yubikey-ksm-1.5-3.fc14.noarch.rpm:
yubikey-ksm.src: W: invalid-url Source0:
http://yubikey-ksm.googlecode.com/files/yubikey-ksm-1.5.tgz HTTP Error 404: Not
Found

yubikey-ksm-1.5-3.fc14.noarch.rpm
yubikey-ksm.noarch: W: incoherent-version-in-changelog 1.3-3 ['1.5-3.fc14',
'1.5-3']
yubikey-ksm.noarch: E: non-readable /etc/ykksm/ykksm-config.php 0640L
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-export
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-checksum
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-gen-keys
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-import
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

Non-readable error is false positive.
Minor issue - the last changelog entry in the spec uses the wrong
version, should bump version and reset the release.

OK - package meets naming guidelines
OK - spec file name matches base package name
OK - meets packaging guidelines
OK - meets licensing guidelines
OK - license field matches
OK - spec in American English
OK - spec is legible
OK - spec sources match upstream
OK - builds in mock
OK - no bundled libs
OK - owns its directories, does not own files owned by other packages
OK - does not list a file more than once
OK - permissions are OK
OK - consistently uses macros
OK - contains code or permissible content
OK - files in %doc do not affect runtime
OK - filenames valid UTF-8

SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Dennis Gilmore  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Dennis Gilmore  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Dennis Gilmore  2011-01-25 21:03:53 EST ---
Package Name: yubikey-ksm
Short Description: The YubiKey Key Stroage Module
Owners: ausil
Branches: el6 f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #6 from Dennis Gilmore  2011-01-25 21:12:09 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #5 from Dennis Gilmore  2011-01-25 21:08:23 EST ---
New Package SCM Request
===
Package Name: yubikey-ksm
Short Description: The YubiKey Key Stroage Module
Owners: ausil
Branches: el6 f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #7 from Fedora Update System  2011-01-25 
22:52:49 EST ---
yubikey-ksm-1.5-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/yubikey-ksm-1.5-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #8 from Fedora Update System  2011-01-25 
22:53:20 EST ---
yubikey-ksm-1.5-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/yubikey-ksm-1.5-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #9 from Fedora Update System  2011-01-25 
22:54:08 EST ---
yubikey-ksm-1.5-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/yubikey-ksm-1.5-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System  
2011-01-26 14:01:57 EST ---
yubikey-ksm-1.5-3.el6 has been pushed to the Fedora EPEL 6 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update yubikey-ksm'.  You can provide
feedback for this update here:
https://admin.fedoraproject.org/updates/yubikey-ksm-1.5-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #11 from Fedora Update System  
2011-02-12 19:18:31 EST ---
yubikey-ksm-1.5-3.el6 has been pushed to the Fedora EPEL 6 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||yubikey-ksm-1.5-3.el6
 Resolution||ERRATA
Last Closed||2011-02-12 19:18:37

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #12 from Fedora Update System  
2011-02-13 03:47:45 EST ---
yubikey-ksm-1.5-3.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|yubikey-ksm-1.5-3.el6   |yubikey-ksm-1.5-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

--- Comment #13 from Fedora Update System  
2011-02-13 03:55:26 EST ---
yubikey-ksm-1.5-3.fc14 has been pushed to the Fedora 14 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2011-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|yubikey-ksm-1.5-3.fc13  |yubikey-ksm-1.5-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

2010-09-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637212

Ricky Zhou  changed:

   What|Removed |Added

 CC||rz...@redhat.com

--- Comment #1 from Ricky Zhou  2010-09-27 17:43:09 EDT ---
I think this needs to require php-pdo.  The user would then need to install the
more specific php-pdo-* package for whatever DB they want to use with the
package.

I'm not sure what the practice is for this, but do we really want to package
the .htaccess file in /usr/share/ykksm as opposed to placing a sample config
under /etc/httpd/conf.d or /usr/share/doc/yubikey-ksm*?

Apache people don't recommend using .htaccess files when one has access to the
server config, and including this forces admins to change/delete it if they
want to make changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review