[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-phpunit-PHPUnit-3.5.3-1 ||.fc14 Resolution||ERRATA Last Closed||2010-11-18 19:11:42 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Bug 637519 depends on bug 637507, which changed state. Bug 637507 Summary: Review Request: php-phpunit-Text-Template - Simple template engine https://bugzilla.redhat.com/show_bug.cgi?id=637507 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-11-18 19:11:27 EST --- php-phpunit-PHPUnit-3.5.3-1.fc14, php-phpunit-PHPUnit-MockObject-1.0.1-2.fc14, php-phpunit-PHPUnit-Selenium-1.0.0-2.fc14, php-phpunit-DbUnit-1.0.0-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-11-06 19:47:00 EDT --- php-phpunit-PHPUnit-3.5.3-1.fc14, php-phpunit-PHPUnit-MockObject-1.0.1-2.fc14, php-phpunit-PHPUnit-Selenium-1.0.0-2.fc14, php-phpunit-DbUnit-1.0.0-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-phpunit-PHPUnit php-phpunit-PHPUnit-MockObject php-phpunit-PHPUnit-Selenium php-phpunit-DbUnit'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-3.5.3-1.fc14,php-phpunit-PHPUnit-MockObject-1.0.1-2.fc14,php-phpunit-PHPUnit-Selenium-1.0.0-2.fc14,php-phpunit-DbUnit-1.0.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 --- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2010-11-05 13:22:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-11-05 17:56:17 EDT --- php-phpunit-PHPUnit-3.5.3-1.fc14,php-phpunit-PHPUnit-MockObject-1.0.1-2.fc14,php-phpunit-PHPUnit-Selenium-1.0.0-2.fc14,php-phpunit-DbUnit-1.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-3.5.3-1.fc14,php-phpunit-PHPUnit-MockObject-1.0.1-2.fc14,php-phpunit-PHPUnit-Selenium-1.0.0-2.fc14,php-phpunit-DbUnit-1.0.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637519
Christof Damian chris...@damian.net changed:
What|Removed |Added
CC||chris...@damian.net
AssignedTo|nob...@fedoraproject.org|chris...@damian.net
Flag||fedora-review+
--- Comment #2 from Christof Damian chris...@damian.net 2010-11-04 04:35:15
EDT ---
MUST:
OK: rpmlint must be run on every package.
1 packages and 1 specfiles checked; 0 errors, 0 warnings.
OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
b0213445543496cfd8d7b2532475ce9c PHPUnit_MockObject-1.0.1.tgz
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
builds in mock f14
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
SHOULD:
OK: The reviewer should test that the package builds in mock.
builds in f14 (f13 + epel-6 are missing php-pear(PEAR) = 1.9.1)
COMMENTS:
- I would prefer https://github.com/sebastianbergmann/phpunit-mock-objects
as the URL instead of the pear channel URL.
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Remi Collet fed...@famillecollet.com 2010-11-04 11:50:06 EDT --- Thanks for the review. I will fix the URL after import I will also hack the package.xml to lower PEAR req in EL6 New Package SCM Request === Package Name: php-phpunit-PHPUnit-MockObject Short Description: Mock Object library for PHPUnit Owners: remi Branches: f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 --- Comment #1 from Remi Collet fed...@famillecollet.com 2010-10-25 12:25:55 EDT --- Spec URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-MockObject.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-MockObject-1.0.1-1.remi.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Blocks||637507, 637518 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Blocks|637507, 637518 | Depends on||637507, 637518 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Blocks||637521 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
