[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #15 from Fedora Update System 2010-10-20 12:31:21 EDT --- erlang-gen_leader-0-0.2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Fixed In Version|erlang-gen_leader-0-0.2.fc1 |erlang-gen_leader-0-0.2.el5 |3 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #14 from Fedora Update System 2010-10-14 02:35:14 EDT --- erlang-gen_leader-0-0.2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Fixed In Version|erlang-gen_leader-0-0.2.fc1 |erlang-gen_leader-0-0.2.fc1 |2 |3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #13 from Fedora Update System 2010-10-14 02:22:59 EDT --- erlang-gen_leader-0-0.2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Fixed In Version|erlang-gen_leader-0-0.2.fc1 |erlang-gen_leader-0-0.2.fc1 |4 |2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||erlang-gen_leader-0-0.2.fc1 ||4 Resolution||ERRATA Last Closed||2010-10-13 08:50:18 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #12 from Fedora Update System 2010-10-13 08:50:14 EDT --- erlang-gen_leader-0-0.2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System 2010-10-05 05:29:36 EDT --- erlang-gen_leader-0-0.2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-gen_leader'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-gen_leader-0-0.2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #10 from Fedora Update System 2010-10-05 00:54:18 EDT --- erlang-gen_leader-0-0.2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-gen_leader-0-0.2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #9 from Fedora Update System 2010-10-05 00:54:11 EDT --- erlang-gen_leader-0-0.2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-gen_leader-0-0.2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #8 from Fedora Update System 2010-10-05 00:54:05 EDT --- erlang-gen_leader-0-0.2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-gen_leader-0-0.2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #7 from Fedora Update System 2010-10-05 00:53:58 EDT --- erlang-gen_leader-0-0.2.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/erlang-gen_leader-0-0.2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #6 from Kevin Fenzi 2010-10-04 15:10:01 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #5 from Nathaniel McCallum 2010-10-04 14:08:00 EDT --- One last note which is certainly not a blocker, the spec lists version as 0, but the file itself has a version of 1.4 in it. This looks to be a CVS generated version, but nonetheless you may want to consider following upstream's version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Peter Lemenkov changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Peter Lemenkov 2010-10-04 10:43:24 EDT --- New Package SCM Request === Package Name: erlang-gen_leader Short Description: A leader election behavior modeled after gen_server Owners: peter Branches: f12 f13 f14 el6 el5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Nathaniel McCallum changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Nathaniel McCallum 2010-10-04 10:38:48 EDT --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 --- Comment #2 from Peter Lemenkov 2010-10-04 10:23:15 EDT --- (In reply to comment #1) > [ ?? ] owns the directories it creates. > What owns /usr/lib64/erlang and /usr/lib64/erlang/lib? Is this package in the > requires? ... > Add the license text as a doc and clarify my understanding of the directories > and then we will be good to go. * both /usr/lib64/erlang/lib and /usr/lib64/erlang/ are owned by erlang-erts (listed in runtime Requires) * I'm afraid I can't add license text to %docs because according to guidelines I can (and I must) do it only *if* upstream explicitly adds it to the sources. However I added README file. I also ensured that beam-file is generated with debug_info (it doesn't hurt runtime performance but allows users to provide some static analysis in runtime). New package and spec-file: http://peter.fedorapeople.org/erlang-gen_leader.spec http://peter.fedorapeople.org/erlang-gen_leader-0-0.2.fc12.src.rpm rpmlint output is much better now: Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-gen_leader-0-0.2.fc12.ppc.rpm erlang-gen_leader.ppc: E: no-binary erlang-gen_leader.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Sulaco ~/rpmbuild/SPECS: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Nathaniel McCallum changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Nathaniel McCallum changed: What|Removed |Added Status|NEW |ASSIGNED CC||nathan...@natemccallum.com AssignedTo|nob...@fedoraproject.org|nathan...@natemccallum.com --- Comment #1 from Nathaniel McCallum 2010-10-04 09:55:24 EDT --- [ OK ] specfiles match: 67931592d06373389253e810914e8939 [ OK ] source files match upstream: 209792fa762bafdfef1c475b2ffb577c [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ FAIL ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ FAIL ] rpmlint is silent. 1. erlang-gen_leader.ppc: E: no-binary 2. erlang-gen_leader.ppc: W: only-non-binary-in-usr-lib 3. erlang-gen_leader.ppc: W: no-documentation #1 and #2 are ok. #3 could easily be solved by packaging a copy of the license. [ OK ] final provides and requires are sane [ NA ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ ?? ] owns the directories it creates. What owns /usr/lib64/erlang and /usr/lib64/erlang/lib? Is this package in the requires? [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ NA ] desktop files valid and installed properly. Add the license text as a doc and clarify my understanding of the directories and then we will be good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638906 Peter Lemenkov changed: What|Removed |Added Blocks||638909 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
