[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=642592 František Dvořák changed: What|Removed |Added CC||val...@civ.zcu.cz Resolution|WONTFIX |DUPLICATE --- Comment #17 from František Dvořák --- *** This bug has been marked as a duplicate of bug 1177697 *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #12 from Michal Fojtik 2011-03-29 07:07:02 EDT --- rev-2: http://mifo.sk/RPMS/rubygem-macaddr.spec http://mifo.sk/RPMS/rubygem-macaddr-1.0.0-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642592
--- Comment #13 from Vít Ondruch 2011-04-04 09:35:59 EDT
---
* License
- according to macaddr rubyforge home page
(http://rubyforge.org/projects/codeforpeople/) the gem is licensed just
under
Ruby license.
- You should encourage upstream to add license file:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
* Cleaning
- "rm -rf %{buildroot}" at the top of %install, %clean section
are no longer needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* Splitting out document files
- Please consider to create -doc subpackage and move the
%{gemdir}/doc/%{gemname}-%{version} directories into -doc
* Rpmlint
- incoherent-version-in-changelog 1.0.0-1 ['1.0.0-2.fc15', '1.0.0-2']
- Please fix the revision in changelog.
Koji build looks fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2971863
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #14 from Vít Ondruch 2011-05-24 06:48:14 EDT --- Ping? Any update here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #15 from Vít Ondruch 2011-07-20 06:45:31 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #9 from Vít Ondruch 2011-03-17 10:47:43 EDT --- Could you provide updates spec file please? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #10 from Michal Fojtik 2011-03-18 09:55:24 EDT --- (In reply to comment #9) > Could you provide updates spec file please? I hope this one will be correct finally: http://mifo.sk/RPMS/rubygem-macaddr.spec http://mifo.sk/RPMS/rubygem-macaddr-1.0.0-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Vít Ondruch changed: What|Removed |Added AssignedTo|jzigm...@redhat.com |vondr...@redhat.com --- Comment #11 from Vít Ondruch 2011-03-18 10:01:47 EDT --- I am taking this for review after Jozef. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Michal Fojtik changed: What|Removed |Added Blocks||642601 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Jozef Zigmund changed: What|Removed |Added CC||jzigm...@redhat.com Flag||fedora-review? --- Comment #1 from Jozef Zigmund 2010-10-13 08:46:34 EDT --- I will take this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|jzigm...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|jzigm...@redhat.com |nob...@fedoraproject.org --- Comment #2 from Mamoru Tasaka 2010-10-13 14:19:28 EDT --- (Once reverting the previous change) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642592
--- Comment #3 from Jozef Zigmund 2010-10-26 12:59:50 EDT
---
This review it's just NONFORMAL because i'm not in Fedora Packager Group right
now.
rpmlint rubygem-macaddr-1.0.0-1.fc13.src.rpm
rubygem-macaddr.src: W: no-buildroot-tag
rubygem-macaddr.src:35: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab:
line 16)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[BAD - in spec-file at line 15 is empty row and at line 16 is abundant tab
character]
MUST: The License field in the package spec file must match the actual license.
License: GPLv2+ or Ruby
[OK? - gem doesn't contain LICENSE]
Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
like:
Requires: ruby(abi) = 1.8
[OK - this MUST condition is written via macro in this spec file]
Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname
is the name from the Gem's specification.
%global gemname macaddr
Name: rubygem-%{gemname}
[OK]
The Source of the package MUST be the full URL to the released Gem archive
URL: http://codeforpeople.com/lib/ruby/macaddr/
Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
[OK]
The version of the package MUST be the Gem's version
Version: 1.0.0
[OK]
The package MUST have a Requires and a BuildRequires on rubygems
%global rubyabi 1.8
Requires: ruby(abi) = %{rubyabi}
Requires: rubygems >= 0
Requires: ruby >= 0
BuildRequires: rubygems >= 0
BuildRequires: ruby >= 0
[BAD - need remove tab character at line 16, and checking againt zero version
is not needed]
The Gem MUST be installed into %{gemdir} defined as:
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK]
If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch
[OK]
The package MUST own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK? - it doesn't contain directory gems, but i think that in this case it
isn't necessary]
The install SHOULD be performed with the command
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
[OK]
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642592
--- Comment #4 from Jozef Zigmund 2010-10-26 13:36:11 EDT
---
(In reply to comment #3)
> This review it's just NONFORMAL because i'm not in Fedora Packager Group right
> now.
>
> rpmlint rubygem-macaddr-1.0.0-1.fc13.src.rpm
> rubygem-macaddr.src: W: no-buildroot-tag
> rubygem-macaddr.src:35: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab:
> line 16)
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
> [BAD - in spec-file at line 15 is empty row and at line 16 is abundant tab
> character]
>
> MUST: The License field in the package spec file must match the actual
> license.
>
> License: GPLv2+ or Ruby
>
> [OK? - gem doesn't contain LICENSE]
>
> Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
> like:
> Requires: ruby(abi) = 1.8
>
> [OK - this MUST condition is written via macro in this spec file]
>
> Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where
> gemname
> is the name from the Gem's specification.
>
> %global gemname macaddr
> Name: rubygem-%{gemname}
>
> [OK]
>
> The Source of the package MUST be the full URL to the released Gem archive
>
> URL: http://codeforpeople.com/lib/ruby/macaddr/
> Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
>
> [OK]
>
> The version of the package MUST be the Gem's version
>
> Version: 1.0.0
>
> [OK]
>
> The package MUST have a Requires and a BuildRequires on rubygems
>
> %global rubyabi 1.8
>
> Requires: ruby(abi) = %{rubyabi}
> Requires: rubygems >= 0
> Requires: ruby >= 0
> BuildRequires: rubygems >= 0
> BuildRequires: ruby >= 0
>
> [BAD - need remove tab character at line 16, and checking againt zero version
> is not needed]
>
> The Gem MUST be installed into %{gemdir} defined as:
> %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
>
> [OK]
>
> If the Gem only contains pure Ruby code, it MUST be marked as BuildArch:
> noarch
>
> [OK]
>
> The package MUST own the following files and directories:
>
> %{gemdir}/gems/%{gemname}-%{version}/
> %{gemdir}/cache/%{gemname}-%{version}.gem
> %{gemdir}/specifications/%{gemname}-%{version}.gemspec
>
> [OK? - it doesn't contain directory gems, but i think that in this case it
> isn't necessary]
>
> The install SHOULD be performed with the command
>
> gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
>
> [OK]
Please check this review also someone else (the best, who is sponsor)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Marek Mahut changed: What|Removed |Added Status|NEW |ASSIGNED CC||mma...@redhat.com AssignedTo|nob...@fedoraproject.org|mma...@redhat.com --- Comment #5 from Marek Mahut 2010-11-04 05:38:32 EDT --- Michal, please update the spec with a correct licence. https://github.com/btakita/rr/blob/master/LICENSE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #6 from Michal Fojtik 2010-11-04 08:16:59 EDT --- Good catch, thanks. Updated files: Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 Jozef Zigmund changed: What|Removed |Added AssignedTo|mma...@redhat.com |jzigm...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #7 from Jozef Zigmund 2010-11-05 09:55:20 EDT --- (In reply to comment #6) > Good catch, thanks. Updated files: > > Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec > SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm This Spec and SRPM aren't for this gem. It should be in rubygem-rr. Please load the right ones. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642592] Review Request: rubygem-macaddr - Cross platform mac address determination for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #8 from Michal Fojtik 2010-11-08 09:55:10 EST --- (In reply to comment #7) > (In reply to comment #6) > > Good catch, thanks. Updated files: > > > > Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec > > SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm > > This Spec and SRPM aren't for this gem. It should be in rubygem-rr. Please > load > the right ones. Sorry for that: Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
