[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drupal6-advanced-help-1.2-2 ||.fc14 Resolution||ERRATA Last Closed||2011-01-28 14:23:31 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-01-28 14:23:25 EST --- drupal6-advanced-help-1.2-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-01-20 07:10:14 EST --- drupal6-advanced-help-1.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/drupal6-advanced-help-1.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-01-20 14:55:04 EST --- drupal6-advanced-help-1.2-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update drupal6-advanced-help'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/drupal6-advanced-help-1.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #7 from Volker Fröhlich volke...@gmx.at 2011-01-18 08:51:35 EST --- Please check, if the license is stated as GPLv2+, as all modules hosted in Drupal's CVS must be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2010-12-22 12:18:34 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Paul W. Frields sticks...@gmail.com changed: What|Removed |Added Blocks||662103(InsightReviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642857
Paul W. Frields sticks...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||sticks...@gmail.com
AssignedTo|nob...@fedoraproject.org|sticks...@gmail.com
Flag||needinfo?(s...@lank.es)
--- Comment #3 from Paul W. Frields sticks...@gmail.com 2010-12-10 16:12:21
EST ---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint rpmbuild/SPECS/drupal6-advanced-help.spec
rpmbuild/SRPMS/drupal6-advanced-help-1.2-1.fc14.src.rpm
rpmbuild/RPMS/noarch/drupal6-advanced-help-1.2-1.fc14.noarch.rpm
drupal6-advanced-help.src: W: spelling-error Summary(en_US) html - HTML, ht
ml, ht-ml
drupal6-advanced-help.src: W: spelling-error %description -l en_US html -
HTML, ht ml, ht-ml
drupal6-advanced-help.noarch: W: spelling-error Summary(en_US) html - HTML, ht
ml, ht-ml
drupal6-advanced-help.noarch: W: spelling-error %description -l en_US html -
HTML, ht ml, ht-ml
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Please post verbatim for other reviews, thanks!
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
NOTE: The Requires: as listed will not work in EPEL, but they are fine
in Fedora. To correct this issue, use Requires: drupal6 = 6.0
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum rpmbuild/SOURCES/advanced_help-6.x-1.2.tar.gz ; curl -s -o -
http://ftp.drupal.org/files/projects/advanced_help-6.x-1.2.tar.gz | md5sum -
a41a31032c907409ab5c330260c66fe8 rpmbuild/SOURCES/advanced_help-6.x-1.2.tar.gz
a41a31032c907409ab5c330260c66fe8 -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ N/A ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Paul W. Frields sticks...@gmail.com changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added CC||jaredsm...@jaredsmith.net --- Comment #2 from Christoph Wickert cwick...@fedoraproject.org 2010-11-21 12:32:05 EST --- *** Bug 655547 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Sven Lankes s...@lank.es changed: What|Removed |Added Summary|Review Request: |Review Request: |drupal-advanced-help - |drupal6-advanced-help - |Allows module developers to |Allows module developers to |store their help outside|store their help outside |the module system in html |the module system in html --- Comment #1 from Sven Lankes s...@lank.es 2010-10-18 17:16:42 EDT --- New files - changed the name to include the major drupal version this module is for in the name: Spec URL: http://sven.lank.es/Fedora/SPECS/drupal6-advanced-help.spec SRPM URL: http://sven.lank.es/Fedora/SRPM/drupal6-advanced-help-1.2-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
