[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-12-15 03:56:48 EST --- jnr-netdb-1.0.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|jnr-netdb-1.0.1-3.fc14 |jnr-netdb-1.0.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-12-08 16:40:49 EST --- jnr-netdb-1.0.1-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jnr-netdb-1.0.1-3.fc14 Resolution||ERRATA Last Closed||2010-12-08 16:40:54 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-12-03 15:39:41 EST --- jnr-netdb-1.0.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jnr-netdb'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/jnr-netdb-1.0.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=646637
--- Comment #5 from Mohammed Morsi mmo...@redhat.com 2010-12-02 10:21:15 EST
---
OK thanks for the feedback and srry for the delay (was off all last week).
Updated package to:
1. include pom.xml and run the maven macros
2. install jar and javadocs as %{name} and not %{name}-%{version}
3. execute one 'ant jar javadoc' command (good catch, thx for this)
I still left the javadoc subpackage depending on the main one to keep
consistency w/ all the other jruby packages. If this poses to be a big issue in
the future we can just update the package.
Spec URL: http://mo.morsi.org/files/jruby/jnr-netdb.spec
SRPM URL: http://mo.morsi.org/files/jruby/jnr-netdb-1.0.1-3.fc13.src.rpm
Again thanks for the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2010-12-02 10:42:18 EST --- Thanks. Everything is good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Mohammed Morsi mmo...@redhat.com 2010-12-02 10:52:30 EST --- Thank you greatly New Package SCM Request === Package Name: jnr-netdb Short Description: Network services database access for java Owners: mmorsi Branches: f13 f14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2010-12-02 14:36:07 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-12-02 17:54:24 EST --- jnr-netdb-1.0.1-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/jnr-netdb-1.0.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-12-02 17:54:47 EST --- jnr-netdb-1.0.1-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/jnr-netdb-1.0.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2010-11-18 12:53:56 EST --- I'll do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=646637
--- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2010-11-18
13:17:56 EST ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
jnr-netdb.noarch: W: spelling-error %description -l en_US getservbyname -
dynameter
jnr-netdb.noarch: W: spelling-error %description -l en_US getservbyport
jnr-netdb.src: W: no-buildroot-tag
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[!] Package meets the Packaging Guidelines[2].
See issues at the end of this comment.
[x] Package successfully compiles and builds into binary rpms.
[-] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: LGPLv3
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[!] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[-] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[!] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
=== Issues ===
1. Package ships pom.xml so you must install it and add the maven depmap
http://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files_and_depmaps
2.jar should be installed as %{name}.jar without %{name}-%{version}.jar
3. javadoc should be installe as %{buildroot}%{_javadocdir}/%{name} not
%{buildroot}%{_javadocdir}/%{name}-%{version}
4. Executing ant jar javadoc instead of 2 ant calls will be a bit faster
5. Javadoc package doesn't really require the jar to be usable thus I would
prefer to be able to install javadocs without dependency. This is up to you but
if you do it note that you have to add the license file to the javadoc package
too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #2 from Mohammed Morsi mmo...@redhat.com 2010-11-15 13:40:43 EST --- Updated Spec URL: http://mo.morsi.org/files/jruby/jnr-netdb.spec SRPM URL: http://mo.morsi.org/files/jruby/jnr-netdb-1.0.1-2.fc13.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2602722 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com Bug 646637 depends on bug 561462, which changed state. Bug 561462 Summary: Review Request: jaffl - Java Abstracted Foreign Function Layer https://bugzilla.redhat.com/show_bug.cgi?id=561462 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2010-11-10 17:06:59 EST --- Java packages should ship javadoc subpackages. Please add one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Depends on||561462 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646637] Review Request: jnr-netdb - Network services database access for java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||561484 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
