[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 15:42:10 --- Comment #9 from Orion Poplawski 2011-04-26 15:42:10 EDT --- Checked in and built. Thanks all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 --- Comment #8 from Jason Tibbitts 2011-04-25 22:36:27 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 Orion Poplawski changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Orion Poplawski 2011-04-25 17:04:38 EDT --- New Package SCM Request === Package Name: mod_xsendfile Short Description: Apache module to send files efficiently Owners: orion Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 Robert Scheck changed: What|Removed |Added CC||red...@linuxnetz.de Flag|fedora-cvs? |fedora-review+ --- Comment #6 from Robert Scheck 2011-04-25 16:58:59 EDT --- Changes/corrections were performed, thus: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 --- Comment #5 from Orion Poplawski 2011-04-25 14:57:42 EDT --- http://www.cora.nwra.com/~orion/fedora/mod_xsendfile.spec http://www.cora.nwra.com/~orion/fedora/mod_xsendfile-0.12-3.fc14.src.rpm * Mon Apr 25 2011 Orion Poplawski 0.12-3 - Fix license tag Really no difference between cp -p and install -p -m 644. Email sent to upstream about license file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=646686
Robert Scheck changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|redhat-bugzilla@linuxnetz.d
||e
Flag||fedora-cvs?
--- Comment #4 from Robert Scheck 2011-04-25 13:14:50 EDT
---
Okay, here we go:
[ DONE ] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/mod_xsendfile-*
mod_xsendfile.src: W: spelling-error %description -l en_US xsendfile ->
landfill, defilement
mod_xsendfile.src: W: spelling-error %description -l en_US sendfile -> send
file, send-file, Sendai
mod_xsendfile.src: W: spelling-error %description -l en_US mmap -> map, m map,
Map
mod_xsendfile.src: W: spelling-error %description -l en_US php -> fp, pp, hp
mod_xsendfile.src: W: spelling-error %description -l en_US perl -> Perl, peel,
perk
mod_xsendfile.src: W: spelling-error %description -l en_US cgi -> cig, chi, cg
mod_xsendfile.src: W: invalid-license ASL2
cat: /usr/include/httpd/.mmn: No such file or directory
mod_xsendfile.x86_64: W: spelling-error %description -l en_US xsendfile ->
landfill, defilement
mod_xsendfile.x86_64: W: spelling-error %description -l en_US sendfile -> send
file, send-file, Sendai
mod_xsendfile.x86_64: W: spelling-error %description -l en_US mmap -> map, m
map, Map
mod_xsendfile.x86_64: W: spelling-error %description -l en_US php -> fp, pp, hp
mod_xsendfile.x86_64: W: spelling-error %description -l en_US perl -> Perl,
peel, perk
mod_xsendfile.x86_64: W: spelling-error %description -l en_US cgi -> cig, chi,
cg
mod_xsendfile.x86_64: W: invalid-license ASL2
mod_xsendfile-debuginfo.x86_64: W: spelling-error Summary(en_US) xsendfile ->
landfill, defilement
mod_xsendfile-debuginfo.x86_64: W: spelling-error %description -l en_US
xsendfile -> landfill, defilement
mod_xsendfile-debuginfo.x86_64: W: invalid-license ASL2
3 packages and 0 specfiles checked; 0 errors, 17 warnings.
$
-> Ignore spelling errors, aspell doesn't know these technical words
-> License error is addressed below
-> Ignore "cat: /usr/include/httpd/.mmn", that's fine for mod_*
[ OK ] MUST: The package must be named according to the Package Naming
Guidelines.
[ OK ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ ?? ] MUST: The package must meet the Packaging Guidelines.
[FAILED] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
-> Replace "ASL2" by "ASL 2.0"
[FAILED] MUST: The License field in the package spec file must match the actual
license.
-> Replace "ASL2" by "ASL 2.0"
[ N/A ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[ OK ] MUST: The spec file must be written in American English.
[ OK ] MUST: The spec file for the package MUST be legible.
[ OK ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
-> 4b83b0e1a0c043c4e76ee99685c35110 mod_xsendfile-0.12.tar.bz2
-> 4b83b0e1a0c043c4e76ee99685c35110 mod_xsendfile-0.12.tar.bz2.1
[ OK ] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the
spec in ExcludeArch. Each architecture listed in ExcludeArch MUST
have a bug filed in bugzilla, describing the reason that the package
does not compile/build/work on that architecture. The bug number MUST
be placed in a comment, next to the corresponding ExcludeArch line.
[ OK ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging
Guidelines; inclusion of those as BuildRequires is optional. Apply
common sense.
[ N/A ] MUST: The spec file MUST handle locales properly. This is done by
using the %fi
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 --- Comment #3 from Orion Poplawski 2010-12-01 12:31:19 EST --- http://www.cora.nwra.com/~orion/fedora/mod_xsendfile.spec http://www.cora.nwra.com/~orion/fedora/mod_xsendfile-0.12-2.fc14.src.rpm * Wed Dec 1 2010 Orion Poplawski 0.12-2 - Upstream fixed tar ball packaging -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 --- Comment #2 from Orion Poplawski 2010-12-01 11:44:19 EST --- That is funny, never noticed. I've pinged the upstream maintainer about it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 Bill Pemberton changed: What|Removed |Added CC||wf...@virginia.edu --- Comment #1 from Bill Pemberton 2010-12-01 11:20:15 EST --- The source file is named .gz but the file is actually a .bz2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
