[Bug 647510] Review Request: premake - A cross-platform build configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=647510 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Björn besser82 Esser bjoern.es...@gmail.com --- Package Change Request == Package Name: premake New Branches: el5 el6 epel7 Owners: besser82 jaydg -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=647510 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-12-09 16:57:26 EST --- premake-4.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||premake-4.3-2.fc13 Resolution||ERRATA Last Closed||2010-12-09 16:57:31 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-12-09 17:03:47 EST --- premake-4.3-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|premake-4.3-2.fc13 |premake-4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-11-30 17:27:56 EST --- premake-4.3-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update premake'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/premake-4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2010-11-29 11:58:34 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-11-29 12:48:39 EST --- premake-4.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/premake-4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-11-29 12:47:12 EST --- premake-4.3-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/premake-4.3-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647510
--- Comment #9 from Dan Horák d...@danny.cz 2010-11-28 05:50:13 EST ---
(In reply to comment #8)
Changes:
- packed latest version
- changes license to BSD
- added readline-devel to BuildRequires
- added a man page
- do not clean %{_builddir}/%{buildsubdir}
- added version-release pair to changelog
all issues mentioned in the review are fixed, but a new one appeared
- you shouldn't compress the man page during install, it's done automagically
by rpm, also use wild-carded form premake4.1* in %files as the algorithm can
change
For the records - sha1sum of the source archive
8f37a3599121580f18b578811162b9b49a2e122f premake-4.3-src.zip
Also thanks for preparing the man page, did you sent it to upstream for
inclusion in the new release of premake?
The provided test suite could be run during the build, but unfortunately one
test fails on x86_64, so I chose not to add it. I'll report the bug upstream
and run the tests when it has been fixed:
os.findlib_FindSystemLib:
/home/joachim/tmp/premake-4.3/tests/base/test_os.lua:18: expected true but was
false
600 tests passed, 1 failed
thanks for the information, hopefully they will solve the issue and the
test-suite could be enabled in the future
I'm not sure about the symlink, as upstream calls the current version premake4
throughout the documentation and chosen this name as the scripts for version 4
are incompatible to scripts for the previous versions.
yes, you are right with incompatibilities, let's keep only the binary
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #10 from Joachim de Groot jdegr...@web.de 2010-11-28 06:46:33 EST --- Thanks for your review. (In reply to comment #9) all issues mentioned in the review are fixed, but a new one appeared - you shouldn't compress the man page during install, it's done automagically by rpm, also use wild-carded form premake4.1* in %files as the algorithm can change I've uploaded a version that fixes the man page compression issue: Spec URL: http://fedora.jaydg.nl/premake.spec SRPM URL: http://fedora.jaydg.nl/premake-4.3-2.fc14.src.rpm Also thanks for preparing the man page, did you sent it to upstream for inclusion in the new release of premake? Did so just now: http://sourceforge.net/tracker/?func=detailaid=3121233group_id=71616atid=531880 thanks for the information, hopefully they will solve the issue and the test-suite could be enabled in the future I've reported that bug: http://sourceforge.net/tracker/?func=detailaid=3121217group_id=71616atid=531878 I just realized that you are the codeblocks maintainer - the ability to create Codeblocks projects is the reason I got to use premake in the first place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Dan Horák d...@danny.cz changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #11 from Dan Horák d...@danny.cz 2010-11-28 08:05:20 EST --- All issues are fixed and this package is APPROVED. I will now sponsor you for the packagers group and please continue with next steps on the maintainer join wiki page. If you will have any questions then don't hesitate to ask either me directly or on the de...@lists.fp.o mailing list or #fedora-devel IRC channel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Joachim de Groot jdegr...@web.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Joachim de Groot jdegr...@web.de 2010-11-28 09:55:17 EST --- New Package SCM Request === Package Name: premake Short Description: Cross-platform build configuration tool Owners: jaydg Branches: f13 f14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647510
--- Comment #8 from Joachim de Groot jdegr...@web.de 2010-11-27 10:51:50 EST
---
Thank you for the review! I have updated the spec file:
Spec URL: http://fedora.jaydg.nl/premake.spec
SRPM URL: http://fedora.jaydg.nl/premake-4.3-1.fc14.src.rpm
Changes:
- packed latest version
- changes license to BSD
- added readline-devel to BuildRequires
- added a man page
- do not clean %{_builddir}/%{buildsubdir}
- added version-release pair to changelog
rpmlint is silent now:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
The provided test suite could be run during the build, but unfortunately one
test fails on x86_64, so I chose not to add it. I'll report the bug upstream
and run the tests when it has been fixed:
os.findlib_FindSystemLib:
/home/joachim/tmp/premake-4.3/tests/base/test_os.lua:18: expected true but was
false
600 tests passed, 1 failed
I'm not sure about the symlink, as upstream calls the current version premake4
throughout the documentation and chosen this name as the scripts for version 4
are incompatible to scripts for the previous versions.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647510
--- Comment #7 from Dan Horák d...@danny.cz 2010-11-21 16:05:17 EST ---
It may be also useful to install %{_bindir}/premake as a symlink to the
premake4 binary.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647510
Dan Horák d...@danny.cz changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|d...@danny.cz
Flag||fedora-review?
--- Comment #6 from Dan Horák d...@danny.cz 2010-11-21 13:05:35 EST ---
formal review is here, see the notes explaining OK* and BAD statuses below:
BAD source files match upstream:
upstream: 1cd4bded80ecbe695ec309352241a00e6ce01c20 premake-4.2.1-src.zip
srpm: a8253af9c17f6e90811b896a2e941492cab4e861 premake-4.2.1-src.zip
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
BAD license field matches the actual license.
OK license is open source-compatible. License text included in package.
BAD latest version is being packaged.
BAD BuildRequires are proper.
OK compiler flags are appropriate.
BAD %clean is present.
BAD package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A* %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK* file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- the freshly downloaded source archive doesn't contain the MacOS/X prebuild
binary
- the resulting license should be GPL+, see point 4 in
https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
- version 4.3 was released few days ago (includes a switch from GPL to BSD)
- readline-devel must be added as BR
- you shouldn't clean %{_builddir}/%{buildsubdir} -
http://fedoraproject.org/wiki/PackagingGuidelines#.25clean
- rpmlint complains a bit:
premake.x86_64: W: no-version-in-last-changelog
= the format of changelog is bad (must include version-release pair, also
add an empty line between entries) -
http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs
premake.x86_64: W: no-manual-page-for-binary premake4
= nice to have, but not a blocker
- a test suite is included in the sources, please check whether it can be run
during the build
- I'd use an explicit -m 755 when installing the binary, you should also
remove the %{_builddir}/%{buildsubdir} part and use . instead
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #5 from Joachim de Groot jdegr...@web.de 2010-10-29 02:56:45 EDT --- I've noticed that the debuginfo package was empty and fixed that. Spec URL: http://fedora.jaydg.nl/premake.spec SRPM URL: http://fedora.jaydg.nl/premake-4.2.1-3.fc13.src.rpm Output of rpmlint: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com --- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2010-10-28 13:33:07 EDT --- I will review your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 Joachim de Groot jdegr...@web.de changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #2 from Joachim de Groot jdegr...@web.de 2010-10-28 13:58:27 EDT --- Thanks! Some notes: This is my first package and I need a sponsor. Upstream bundles the Lua sources, I've added a patch to use the system's Lua libraries instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647510] Review Request: premake - A cross-platform build configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647510
--- Comment #4 from Joachim de Groot jdegr...@web.de 2010-10-28 18:18:25 EDT
---
Thank you for your feedback!
(In reply to comment #3)
I've just seen you added the « FE-NEEDSPONSOR » flag after I took
your package. Since I'm not a sponsor, I won't be able to approve
your package if necessary. Anyway I'll give you some comments.
Unfortunately, it took me a while to figure out how to get it there.
I have added all your changes and additionally removed the 'A' from the summary
(read about that in the review of another package).
The new files are
Spec URL: http://fedora.jaydg.nl/premake.spec
SRPM URL: http://fedora.jaydg.nl/premake-4.2.1-2.fc13.src.rpm
4) In %install, you don't need to use the absolute path to your build
directory
to install the executable. The following line is enough:
%install
rm -rf %{buildroot}
install -Dp bin/release/premake4 %{buildroot}/%{_bindir}/premake4
Note that:
* %{_bindir} macro should be used instead of /usr/bin
* the -D option will create the destination folder if necessary, so a call
to
mkdir before is useless
* the -p option will preserve timestamp
I was looking for an option to install that does not require naming the
executable again as target. That's why I came up with mkdir.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
