[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #18 from Stanislav Ochotnicky socho...@redhat.com 2011-03-11 
02:59:50 EST ---
OK, Package is good. Sorry for the delay, I didn't notice nagmails :-/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Blocks|652183(FE-JAVASIG)  |

--- Comment #19 from Alexander Kurtakov akurt...@redhat.com 2011-03-11 
09:44:50 EST ---
Dropping FE-JAVASIG block. Nothing that depends on the Java SIG anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #20 from Orion Poplawski or...@cora.nwra.com 2011-03-11 10:11:24 
EST ---
New Package SCM Request
===
Package Name: apache-rat
Short Description: Apache Release Audit Tool (RAT)
Owners: orion
Branches: f15 el6
InitialCC: 

Thanks everyone.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #21 from Jason Tibbitts ti...@math.uh.edu 2011-03-11 14:28:36 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-03-11 15:28:02

--- Comment #22 from Orion Poplawski or...@cora.nwra.com 2011-03-11 15:28:02 
EST ---
Imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #16 from Alexander Kurtakov akurt...@redhat.com 2011-03-03 
11:00:26 EST ---
Orion, ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #17 from Orion Poplawski or...@cora.nwra.com 2011-03-03 11:17:13 
EST ---
Sorry, been busy.

* Thu Mar 3 2011 Orion Poplawski or...@cora.nwra.com 0.8-0.6.20100827
- Drop unneeded rm from %%install
- Don't ship BUILD.txt
- Cleanup Requires

http://www.cora.nwra.com/~orion/fedora/apache-rat.spec
http://www.cora.nwra.com/~orion/fedora/apache-rat-0.8-0.6.20100827.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2011-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #15 from Stanislav Ochotnicky socho...@redhat.com 2011-01-06 
09:17:14 EST ---
So...Few more things:
 * rm -rf $RPM_BUILD_ROOT in %install is not needed
 * you shouldn't install BUILD.txt
 * you probably didn't see my note about useless Requires where:

apache-rat-core - apache-rat - jpackage utils
- jpackage-utils

the requires on jpackage-utils in core is not needed because it is pulled in by
main package. Similar other requires like this are in the spec. It's not
exactly a packaging problem, but makes the spec file bigger without any reason
(that I can see). If you have a reason for this, please explain. 

All in all the package is good now, but I'll wait for new version/response
before accepting...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #14 from Orion Poplawski or...@cora.nwra.com 2010-12-28 13:06:00 
EST ---
* Mon Dec 27 2010 Orion Poplawski or...@cora.nwra.com 0.8-0.5.20100827
- Drop maven settings patch
- Add svn revision to export command
- Set maven.test.failure.ignore=true instead of maven.test.skip
- Use %%{_mavenpomdir}

http://www.cora.nwra.com/~orion/fedora/apache-rat.spec
http://www.cora.nwra.com/~orion/fedora/apache-rat-0.8-0.5.20100827.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #13 from Stanislav Ochotnicky socho...@redhat.com 2010-12-23 
07:35:22 EST ---
Ah, sorry that was supposed to be -Dmaven.test.failure.ignore=true. 

About those failures...They could be caused by new/old
plexus-container-default. Quick look didn't give me much more info. Feel free
to ignore the failures, IMO they shouldn't cause trouble in runtime. It's most
probably due to our use of local repo and other things...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||socho...@redhat.com
 AssignedTo|nob...@fedoraproject.org|socho...@redhat.com
   Flag||fedora-review?

--- Comment #9 from Stanislav Ochotnicky socho...@redhat.com 2010-12-22 
09:12:01 EST ---
I'll have a look

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #10 from Stanislav Ochotnicky socho...@redhat.com 2010-12-22 
09:45:48 EST ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
apache-rat.noarch: W: spelling-error %description -l en_US labour - labor, lab
our, lab-our
Yeah, I'd also prefer labour, but it's supposed to be en_US

apache-rat.noarch: W: spelling-error %description -l en_US metadata - meta
data, meta-data, metatarsus
apache-rat.noarch: W: spelling-error %description -l en_US plugin - plug in,
plug-in, plugging
apache-rat.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-rat
apache-rat.src: W: spelling-error %description -l en_US labour - labor, lab
our, lab-our
apache-rat.src: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
apache-rat.src: W: spelling-error %description -l en_US plugin - plug in,
plug-in, plugging
apache-rat.src:45: W: macro-in-comment %{name}
apache-rat.src:45: W: macro-in-comment %{version}
apache-rat.src:45: W: macro-in-comment %{release}
apache-rat.src:46: W: macro-in-comment %{name}
apache-rat.src:46: W: macro-in-comment %{version}
apache-rat.src:46: W: macro-in-comment %{release}

Remove those commented Requires please

apache-rat.src: W: invalid-url Source0: apache-rat-0.8-20100827.tar.bz2
apache-rat-core.noarch: W: spelling-error %description -l en_US plugin - plug
in, plug-in, plugging
apache-rat-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs, Java-docs, Javanese
apache-rat-tasks.noarch: W: non-conffile-in-etc /etc/ant.d/apache-rat
6 packages and 0 specfiles checked; 0 errors, 17 warnings

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: ASL 2.0
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  All independent sub-packages have license of their own
[!]  Spec file is legible and written in American English.
Well..en_GB would be fine with me. Just that labour...
[?]  Sources used to build the package matches the upstream source, as provided
in the spec URL.

It would be good to have reasoning for use of snapshot. Plus giving svn export
with -r 990212 argument. 

[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
core/plugin/tasks all have requires in jpackage utils and also on main package.
You should probably respect dependencies so that when main package requires
jpackage-utils don't put it also in dependencies. Same thing for example plugin
requiring main package and also core. Core is enough because it pulls in main.
IMO the less lines of code the better...
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[!]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
Put that revision directly into svn export command I guess so it's not
scattered.
[-]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
building with 

[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #11 from Orion Poplawski or...@cora.nwra.com 2010-12-22 14:27:36 
EST ---
Created attachment 470290
  -- https://bugzilla.redhat.com/attachment.cgi?id=470290
:q

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

 Attachment #470290|:q  |surefire-reports/org.apache
description||.rat.mp.RatCheckMojoTest.tx
   ||t

--- Comment #12 from Orion Poplawski or...@cora.nwra.com 2010-12-22 14:30:50 
EST ---
Comment on attachment 470290
  -- https://bugzilla.redhat.com/attachment.cgi?id=470290
surefire-reports/org.apache.rat.mp.RatCheckMojoTest.txt

I tried -Dmaven.test.ignore.failure=true but the build still fails with:

---
 T E S T S
---
Running org.apache.rat.mp.RatCheckMojoTest
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.65 sec 
FAILURE!
Results :
Tests in error: 
  testIt1(org.apache.rat.mp.RatCheckMojoTest)
  testIt2(org.apache.rat.mp.RatCheckMojoTest)
  testIt3(org.apache.rat.mp.RatCheckMojoTest)
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] There are test failures.
Please refer to
/builddir/build/BUILD/apache-rat-0.8-20100827/apache-rat-plugin/target/surefire-reports
for the individual test results.

I've attached the surefire-reports output.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Bug 647885 depends on bug 647602, which changed state.

Bug 647602 Summary: Review Request: ant-antunit - Provide antunit ant task
https://bugzilla.redhat.com/show_bug.cgi?id=647602

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

 Blocks||652183(FE-JAVASIG)

--- Comment #7 from Orion Poplawski or...@cora.nwra.com 2010-12-09 13:34:39 
EST ---
http://www.cora.nwra.com/~orion/fedora/apache-rat.spec
http://www.cora.nwra.com/~orion/fedora/apache-rat-0.8-0.4.20100827.fc14.src.rpm

* Mon Nov 1 2010 Orion Poplawski or...@cora.nwra.com 0.8-0.4.20100827
- Change BR to ant-antunit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #8 from Orion Poplawski or...@cora.nwra.com 2010-12-09 13:39:01 
EST ---
Also:

- Drop versioned jar and javadoc
- Drop BuildRoot and %%clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-11-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

 Blocks||529441

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #4 from Orion Poplawski or...@cora.nwra.com 2010-11-01 11:43:19 
EDT ---
(In reply to comment #3)
 You are missing the /etc/ant.d file for the tasks package too.

What should the contents be?  I don't see any guidance in the wiki.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2010-11-01 
11:59:47 EDT ---
Hmm, you have done that in https://bugzilla.redhat.com/show_bug.cgi?id=647602
:)
It should contain the classpath for the given task in the way build-classpath
works. I.e. it should be apache-rat/rat-core apache-rat/rat-tasks in your
case.
I'll add it to the guidelines update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #6 from Orion Poplawski or...@cora.nwra.com 2010-11-01 12:09:14 
EDT ---
I just blindly copied from existing ant entries :-).  Thanks.

http://www.cora.nwra.com/~orion/fedora/apache-rat.spec
http://www.cora.nwra.com/~orion/fedora/apache-rat-0.8-0.3.20100827.fc14.src.rpm

* Mon Nov 1 2010 Orion Poplawski or...@cora.nwra.com 0.8-0.3.20100827
- Add /etc/ant.d/apache-rat

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-10-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Terje Røsten terje...@phys.ntnu.no changed:

   What|Removed |Added

 CC||terje...@phys.ntnu.no

--- Comment #1 from Terje Røsten terje...@phys.ntnu.no 2010-10-29 16:35:36 
EDT ---
You have incoherent version in changelog -1 vs 0.2.20100827 and
more req might be needed? The rest looks good!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-10-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #2 from Orion Poplawski or...@cora.nwra.com 2010-10-29 16:45:29 
EDT ---
I reloaded the images with updated changelog.  Not really sure how best to
determine the proper requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

2010-10-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 CC||akurt...@redhat.com

--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2010-10-30 
01:52:56 EDT ---
You are missing the /etc/ant.d file for the tasks package too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review