[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2014-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=648758

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

 CC||ke...@scrye.com
  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #8 from Kevin Fenzi ke...@scrye.com ---
Package Change Request
==
Package Name: supybot--notify
New Branches: epel7
Owners: kevin
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2014-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=648758



--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2014-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=648758

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||supybot-notify-0.2.1-1.fc14
 Resolution||ERRATA
Last Closed||2011-05-08 21:51:33

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-05-08 
21:51:27 EDT ---
supybot-notify-0.2.1-1.fc14 has been pushed to the Fedora 14 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-01-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-01-08 
16:26:36 EST ---
supybot-notify-0.2.1-1.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update supybot-notify'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/supybot-notify-0.2.1-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Ricky Zhou rz...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(rz...@redhat.com) |fedora-cvs?

--- Comment #3 from Ricky Zhou rz...@redhat.com 2011-01-07 21:29:53 EST ---
Will fix whitespace issue and add COPYING file in 0.2.1, which will be the
first version I'll import.

New Package SCM Request
===
Package Name: supybot-notify
Short Description: Notification plugin for Supybot
Owners: ricky
Branches: f14 el5 el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

--- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2011-01-07 21:47:28 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2011-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-01-07 
22:17:23 EST ---
supybot-notify-0.2.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/supybot-notify-0.2.1-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Ian Weller i...@ianweller.org changed:

   What|Removed |Added

   Flag||needinfo?(rz...@redhat.com)

--- Comment #2 from Ian Weller i...@ianweller.org 2010-11-17 21:48:36 EST ---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648758

Ian Weller i...@ianweller.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@ianweller.org
 AssignedTo|nob...@fedoraproject.org|i...@ianweller.org
   Flag||fedora-review+

--- Comment #1 from Ian Weller i...@ianweller.org 2010-11-01 23:10:36 EDT ---
[  OK  ] specfiles match.
[  OK  ] source files match upstream.
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[FAILED] license text included in package.

This is fine for initial approval though. Since you're upstream, I would 
consider including a LICENSE file in your repository and then adding that. This
doesn't block approval.

[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2570681
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent. 
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  N/A ] no headers.
[  N/A ] no pkgconfig files.
[  N/A ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

You still have a space problem in your macro at the top; there are two 
characters on line 2 that should be spaces but aren't due to copying and
pasting from the wiki. The package builds for F14 but failed on my F12 system
(not that it will matter in a while). This issue isn't blocking my approval
since it's a pretty simple fix that can go in git.


 This package is APPROVED by me (ianweller)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review