[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|hitori-0.2.6-3.fc14 |hitori-0.2.6-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2011-03-09 15:52:17 EST --- hitori-0.2.6-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|hitori-0.2.6-3.fc15 |hitori-0.2.6-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2011-03-05 22:40:21 EST --- hitori-0.2.6-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||hitori-0.2.6-3.fc15 Resolution||ERRATA Last Closed||2011-03-05 22:40:34 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2011-03-04 17:45:20 EST --- Package hitori-0.2.6-4.fc13: * should fix your issue, * was pushed to the Fedora 13 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing hitori-0.2.6-4.fc13' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/hitori-0.2.6-4.fc13 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2011-02-28 23:20:44 EST --- hitori-0.2.6-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update hitori'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/hitori-0.2.6-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2011-02-27 07:19:20 EST --- Package hitori-0.2.6-3.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing hitori-0.2.6-3.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/hitori-0.2.6-3.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2011-02-27 07:19:11 EST --- Package hitori-0.2.6-3.fc14: * should fix your issue, * was pushed to the Fedora 14 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing hitori-0.2.6-3.fc14' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/hitori-0.2.6-3.fc14 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #20 from Jason Tibbitts ti...@math.uh.edu 2011-02-24 13:27:39 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Mario Blättermann mari...@gnome.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Mario Blättermann mari...@gnome.org 2011-02-23 14:48:41 EST --- New Package SCM Request === Package Name: hitori Short Description:Logic puzzle game for GNOME Owners: mariobl Branches: f15 f14 f13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #16 from Mario Blättermann mari...@gnome.org 2011-02-18 07:19:22 EST --- I've changed the English and German descriptions a bit, and added the ChangeLog to %docs. New source rpm is here: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.6-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650667
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
Blocks|177841(FE-NEEDSPONSOR) |
Flag|fedora-review? |fedora-review+
--- Comment #17 from Martin Gieseking martin.giesek...@uos.de 2011-02-18
12:29:39 EST ---
The package looks good now. Just replace %docs with %%docs or simply docs
to make rpmlint happy.
The next step is to request a Git repository with the distro branches you're
planning to maintain. See the following wiki page for further information:
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
hitori.src:90: W: macro-in-%changelog %docs
hitori.x86_64: W: no-manual-page-for-binary hitori
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
application: GPLv3+
manual: CC-BY-SA
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum hitori-0.2.6.tar.bz2*
d83b81019837882175aaf97ee8d7 hitori-0.2.6.tar.bz2
d83b81019837882175aaf97ee8d7 hitori-0.2.6.tar.bz2.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
koji scratch build (f15):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2849510
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[+] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
EPEL = 5 only:
[+] MUST: The spec file must contain a valid BuildRoot field.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream,...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[+] SHOULD: If the package has file
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #18 from Mario Blättermann mari...@gnome.org 2011-02-18 15:27:13 EST --- OK, I've changed to %docs macro mentioned in %changelog to %%doc now. I will have a look at the Git repo procedure next days. Many thanks for your help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #15 from Martin Gieseking martin.giesek...@uos.de 2011-02-16 03:32:29 EST --- Yes, it's hard to find any documentation on how to add translated summaries and descriptions to the spec. Nonetheless, you did it correctly, so they should work properly. The guideline not to repeat the package name in the Summary does not apply to the %description. Thus, you may use Hitori-Puzzle (or the like) instead of Puzzle dieses Namens for example. Please also add the ChangeLog files to the package (with %doc). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com 2011-02-15 14:41:47 EST --- New package version available: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.6-2.fc14.src.rpm It is widely unused in Fedora, but I've added non-English (for the time being, German) summary and description. Works fine, gnome-packagekit shows the German text as expected. The behavior to handle such localized versions is less documented. I found an explanation in the Mandriva Wiki: http://wiki.mandriva.com/en/Policies/Charset#Why.3F -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #13 from Martin Gieseking martin.giesek...@uos.de 2011-01-31 03:55:17 EST --- OK, looks good. The package can be approved as soon as you're sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #12 from Mario Blättermann mari...@gnome.org 2011-01-30 14:04:03 EST --- The GNOME upstream bug has fixed: https://bugzilla.gnome.org/show_bug.cgi?id=640905 A new application version is released today, that's why I've build a new package immediately: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.6-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #8 from Martin Gieseking martin.giesek...@uos.de 2011-01-29 04:22:58 EST --- OK, great. Looking forward to it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #9 from Mario Blättermann mari...@gnome.org 2011-01-29 13:54:10 EST --- OK, here we go: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-3.fc14.src.rpm Note: The sources still include the old COPYING-DOCS from previous versions. The new Mallard-based manual is CC-licensed, as described in /help/C/license.page. That's why I've dropped the obsolete file from the docs list, too. Is this OK? I filed a bug for Hitori: https://bugzilla.gnome.org/show_bug.cgi?id=640905 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650667
--- Comment #10 from Martin Gieseking martin.giesek...@uos.de 2011-01-29
15:41:45 EST ---
(In reply to comment #9)
Note: The sources still include the old COPYING-DOCS from previous versions.
The new Mallard-based manual is CC-licensed, as described in
/help/C/license.page. That's why I've dropped the obsolete file from the docs
list, too. Is this OK?
Ah, good catch. Yes that's OK. Only license texts of actually involved licenses
must be added to the package.
The proper abbreviation for the Creative Commons license is CC-BY-SA (without
v3.0 postfix). See here for a list of accepted licenses and their short names
used in the License fields:
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses
Here are a couple of further notes:
- Don't mix spaces and tabs for indentation. Choose one of them and stick
with it.
- Add BR: gtk2-devel again. Only Requires: gtk2 was supposed to be removed.
- Please put the sections %post, %postun, and %posttrans between %clean and
%files. It's just the usual place for the scriptlets.
- Replace %{_datadir}/gnome/help/%{name}/* with
%{_datadir}/gnome/help/%{name}/
Otherwise, only the content of the directory is added but the directory
itself stays unowned and won't get removed when uninstalling the package.
- Add %dir %{_datadir}/%{name}/ to the %files section or (alternatively)
replace %{_datadir}/%{name}/%{name}.ui with %{_datadir}/%{name}/
for proper directory ownership.
BTW, if you don't have a sponsor yet, I can sponsor you if you're willing to do
some informal reviews of other packager's submissions in order to show an
understanding of the packaging guidelines. This is important because you will
be allowed to formally review and approve packages once you are sponsored. And
of course you shouldn't mess your own packages either. Thus, you should know
what you do. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #11 from Mario Blättermann mari...@gnome.org 2011-01-29 16:09:02 EST --- New version has arrived: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-4.fc14.src.rpm Regarding the sponsorship, I will contact you per E-Mail. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #7 from Mario Blättermann mari...@gnome.org 2011-01-28 14:41:28 EST --- The versions are now both available from Dropbox: 0.2.5-1 http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-1.fc14.src.rpm 0.2.5-2 http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-2.fc14.src.rpm Now I will update the package according to your hints. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #5 from mariobl mari...@gnome.org 2011-01-25 14:47:54 EST --- Thanks for your explanations. Here's the new version: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-1.fc14.src.rpm However, rpmlint gives me the following warnings: [mario@localhost i386]$ rpmlint hitori*.rpm hitori.i386: I: enchant-dictionary-not-found en_US hitori.i386: W: unstripped-binary-or-object /usr/bin/hitori hitori.i386: W: no-manual-page-for-binary hitori 1 packages and 0 specfiles checked; 0 errors, 2 warnings. I assume them as non-critical, because I didn't found anything in the appropriate sections of the packaging guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650667
--- Comment #6 from Martin Gieseking martin.giesek...@uos.de 2011-01-25
17:10:23 EST ---
The first rpmlint message comes from the spell checker that can't find the
en_US dictionary on your system.
The warning unstripped-binary-or-object would need some attention. However, I
can't reproduce it on my machine.
Please bump the Release number every time you provide a new revision of the
spec/srpm, and add a corresponding %changelog entry. Otherwise, it's hard to
distinguish between the various versions. So your latest release is 2, the next
one will be 3.
- Please update the License field to GPLv3+ and GFDL. The + refers to the
text or (at your option) any later version in the comments of the source
files. The documentation is licensed under GFDL (according to COPYING-DOCS).
Also add a short comment above the License field that the executable is
licensed under GPLv3+ and the docs under GFDL.
- Drop %{_datadir}/locale/* from the %files section.
- The directories below %{_datadir}/icons are still owned by the package
because
%{_datadir}/icons/* recursively adds all files and directories located in
%{_datadir}/icons/. You must ensure that only the files are added. Thus,
replace this line with %{_datadir}/icons/hicolor/*x*/apps/%{name}.png
- when placing files below %{_datadir}/icons, you must update the icon cache:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #3 from mariobl mari...@gnome.org 2011-01-24 15:14:56 EST --- Sorry for the delay. Now I have my Fedora machine back. The src.rpm is now available from here: http://dl.dropbox.com/u/19373040/Fedora/hitori-0.2.5-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #4 from Martin Gieseking martin.giesek...@uos.de 2011-01-24 17:55:37 EST --- Hi Mario, here are some initial comments on your package: - please choose a Summary that doesn't repeat the package name, e.g. something like Logical number puzzle game for Gnome - change the Group to Amusements/Games - according to the source file headers, the license is GPLv3+ - Source0 should contain a complete URL pointing to the upstream tarball - drop Requires: gtk because it's picked up automatically as a dependency - the package doesn't build in mock because of missing BuildRequires: intltool gnome-doc-utils - The %description lines should not exceed 80 characters per line. Just split them. - see here how to install the locales properly: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - see here how to install the desktop file properly: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop - Your package currently owns the directory /usr/share/icons/hicolor (and the folders below). These folders are already owned by package hicolor-icon-theme. Thus, add hicolor-icon-theme package as a dependency and only add the image files in %files. - add the release number to the version in the %changelog headers: 0.2.5-1 $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm hitori.src: W: name-repeated-in-summary C Hitori hitori.src: E: description-line-too-long C Hitori is a small application written to allow one to play the eponymous puzzle game, which is similar in theme to more popular puzzles such as Sudoku. hitori.src: E: description-line-too-long C It depends on GTK+ 2.13 and Cairo 1.4, and has full support for playing the game (i.e. it checks all three rules are satisfied). It has undo/redo support, can give hints, and allows for cells to be tagged with one of two different tags, to aid in solving the puzzle. It has support for anything from 5×5 to 10×10 grids. hitori.src: W: non-standard-group Games hitori.src: W: invalid-url Source0: hitori-0.2.5.tar.bz2 hitori.x86_64: W: name-repeated-in-summary C Hitori hitori.x86_64: E: description-line-too-long C Hitori is a small application written to allow one to play the eponymous puzzle game, which is similar in theme to more popular puzzles such as Sudoku. hitori.x86_64: E: description-line-too-long C It depends on GTK+ 2.13 and Cairo 1.4, and has full support for playing the game (i.e. it checks all three rules are satisfied). It has undo/redo support, can give hints, and allows for cells to be tagged with one of two different tags, to aid in solving the puzzle. It has support for anything from 5×5 to 10×10 grids. hitori.x86_64: W: non-standard-group Games hitori.x86_64: W: incoherent-version-in-changelog 0.2.5 ['0.2.5-1.fc14', '0.2.5-1'] hitori.x86_64: W: no-manual-page-for-binary hitori hitori.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/en_GB/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/id/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/pa/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/hitori.mo 3 packages and 0 specfiles checked; 4 errors, 23 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added CC||pa...@hubbitus.info --- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2010-11-20 11:23:46 EST --- Can you place files somewhere when do not ask my email to download? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650667] Review Request: hitori - Hitori game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added CC||martin.giesek...@uos.de Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Martin Gieseking martin.giesek...@uos.de 2010-11-08 03:27:55 EST --- Hi Mario, since this is your first Fedora package submission, you need a sponsor who approves you. Here are some more information on how to join the packager group: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored BTW, if you don't have access to a web server to upload your files, you can also use something like Dropbox for example. Downloading files from a filehoster is pretty annoying and might prevent reviewers from taking a look at your submission. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
