[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650744
Markus Mayer changed:
What|Removed |Added
CC||lotharl...@gmx.de
AssignedTo|nob...@fedoraproject.org|lotharl...@gmx.de
Flag||fedora-review+
--- Comment #3 from Markus Mayer 2010-12-20 15:03:42 EST ---
Hi Rafael,
I am doing a formal review...
Just one thing to change:
- Change 'Source0' to
'http://code.google.com/p/spor/downloads/detail?name=%{name}-%{version}.tar.bz2'.
This is just to get rid of an rpmlint warning.
The following review is done with the change from above.
OK: MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
OK: MUST: The package must be named according to the Package Naming Guidelines.
OK: MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: MUST: The package must meet the Packaging Guidelines.
OK: MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
OK: MUST: The License field in the package spec file must match the actual
license.
OK: MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
OK: MUST: The spec file must be written in American English.
OK: MUST: The spec file for the package MUST be legible.
OK: MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
OK: MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK: MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK: MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
OK: MUST: Packages must NOT bundle copies of system libraries.
OK: MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK: MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK: MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
OK: MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: MUST: Each package must consistently use macros.
OK: MUST: The package must contain code, or permissable content.
OK: MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
OK: MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
OK: MUST: Header files must be in a -devel package.
OK: MUST: Static libraries must be in a -static package.
OK: MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
OK: MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
OK: MUST: Packages must NOT contain any .la libtool archives, these mu
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #4 from Rafael Aquini 2010-12-20 18:40:33 EST --- Markus, Thanks a lot for your accurate observation and such detailed review! Here it goes an update, now fixing that rpmlint complaint on spor manpage. Spec URL: http://aquini.fedorapeople.org/spor/spor.spec SRPM URL: http://aquini.fedorapeople.org/spor/spor-1.0-2.fc14.src.rpm I'll be waiting you have a little look on this update, before I ask a new spor SCM branch Cheers! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650744
--- Comment #5 from Markus Mayer 2010-12-21 03:31:04 EST ---
Hi Rafael,
I will not be able to test this package complitly till 14:00 EST. But after a
quick look I have found that you have forgotten to change complitly 'Source0'
to
'http://code.google.com/p/spor/downloads/detail?name=%{name}-%{version}.tar.bz2'
as described in #3.
regards,
Markus
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #6 from Rafael Aquini 2010-12-21 05:28:29 EST --- Markus, I'm afraid that, unfortunately, can not be done! Your asking satisfy rpmlint complaint on .spec file, but it breaks rpmbuild. Besides, that is a nonsense rpmlint warning, since the package can easily be downloaded from the given Source URL Best regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650744
--- Comment #7 from Markus Mayer 2010-12-21 14:39:12 EST ---
Hi Rafael,
I am realy sorry! I did not test if rpmbuild is still working.
I can confirm that the man-page-fix is working.
rpmlint output:
spor.spec: W: invalid-url Source0:
http://spor.googlecode.com/files/spor-1.0.tar.bz2 HTTP Error 404: Not Found
spor.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
As you mentioned above the first warning can be ignored. The 2nd
('mixed-use-of-spaces-and-tabs') can be fixed by replacing the 'tab' in line 12
with spaces.
Best regards
Markus
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #8 from Rafael Aquini 2010-12-21 16:07:55 EST --- Markus, My bad... Fixed one thing and messed another... Now it's OK! Spec URL: http://aquini.fedorapeople.org/spor/spor.spec SRPM URL: http://aquini.fedorapeople.org/spor/spor-1.0-3.fc14.src.rpm Thanks for all your attention on reviewing this package! Best regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #9 from Markus Mayer 2010-12-27 05:58:43 EST --- Hi Rafael, I am totaly fine with this package. Feel free to request a new SCM branch. Regards Markus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Rafael Aquini changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Rafael Aquini 2010-12-27 06:13:54 EST --- New Package SCM Request === Package Name: spor Short Description: recursively walks into a given directory, storing all files modes and ownership information for future retrievals Owners: aquini Branches: f13 f14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #11 from Jason Tibbitts 2010-12-27 19:49:39 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #12 from Fedora Update System 2010-12-28 15:53:32 EST --- spor-1.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/spor-1.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #13 from Fedora Update System 2010-12-28 16:02:40 EST --- spor-1.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spor-1.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2010-12-29 16:51:46 EST --- spor-1.0-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spor'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/spor-1.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #16 from Fedora Update System 2011-01-06 14:27:38 EST --- spor-1.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Fedora Update System changed: What|Removed |Added Fixed In Version|spor-1.0-3.fc13 |spor-1.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||spor-1.0-3.fc13 Resolution||ERRATA Last Closed||2011-01-06 14:27:12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #15 from Fedora Update System 2011-01-06 14:27:07 EST --- spor-1.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 Brendan Jones changed: What|Removed |Added CC||brendan.jones...@gmail.com --- Comment #1 from Brendan Jones 2010-11-08 08:46:31 EST --- Hi Rafael, your release number should start from 1, not 0. http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version regards, Brendan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650744] Review Request: spor - Store file modes (permission/ownership) recursively
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650744 --- Comment #2 from Rafael Aquini 2010-11-08 18:53:25 EST --- Hello Brendan, Thanks a lot for your accurate observation! Here it goes the update, now following correctly that police. Spec URL: http://aquini.fedorapeople.org/spor/spor.spec SRPM URL: http://aquini.fedorapeople.org/spor/spor-1.0-1.fc14.src.rpm Cheers! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
