[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-04-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #28 from Ben Boeckel maths...@gmail.com 2012-04-10 19:46:34 EDT 
---
Open up a new RR bug (the name and summary are wrong for this bug and it'd be
better if whoever will be the maintainer is the one who opened the bug). I can
review it (I'm sure I'll have something to trade).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-04-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #29 from Joel j...@cryregarder.com 2012-04-10 20:19:42 EDT ---
Martin, will you be doing resubmitting this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #27 from Joel j...@cryregarder.com 2012-04-06 15:08:18 EDT ---
Created attachment 575816
  -- https://bugzilla.redhat.com/attachment.cgi?id=575816
Updated SPEC file

* Fri Apr 06 2012 Joel Young j...@cryregarder.com 0.1.0.1-3
- update to released version 0.1.0.1
- added requires for xorg-x11-server-Xvfb
- renamed package to xpra rather than partwm


Any progress on continuing the review for this project?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #26 from Martin Dengler mar...@martindengler.com 2012-02-23 
05:35:15 EST ---
(In reply to comment #25)
 seems Martin also lost interest in this :-(

Sorry, got distracted :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-02-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #25 from Karel Volný kvo...@redhat.com 2012-02-22 10:47:18 EST ---
(In reply to comment #23)
 I updated spec file to work for latest xpra version.  Haven't done rpm dev for
 10 years so probably a little rough.

time to start again :-)

would you be willing to maintain this package? - if yes, please file a new
review request ... seems Martin also lost interest in this :-(

two notes -

* the new upstream calls the bundle xpra, so you may want to rename the spec
file to xpra instead of partiwm

* each version/release increment needs a changelog entry

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-02-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Joel j...@cryregarder.com changed:

   What|Removed |Added

 CC||j...@cryregarder.com

--- Comment #22 from Joel j...@cryregarder.com 2012-02-15 17:14:26 EST ---
The new fork may provide packages for fedora, but they are really really badly
done.  AFAICT you have to be root to build them as they try to install stuff in
/usr during the build process.

creating build/scripts-2.7
copying and adjusting scripts/parti - build/scripts-2.7
copying and adjusting scripts/parti-repl - build/scripts-2.7
copying and adjusting scripts/xpra - build/scripts-2.7
changing mode of build/scripts-2.7/parti from 644 to 755
changing mode of build/scripts-2.7/parti-repl from 644 to 755
changing mode of build/scripts-2.7/xpra from 644 to 755
running install_lib
creating /usr/lib64/python2.7/site-packages/parti
error: could not create '/usr/lib64/python2.7/site-packages/parti': Permission
denied
error: Bad exit status from /var/tmp/rpm-tmp.nokf0R (%build)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-02-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #23 from Joel j...@cryregarder.com 2012-02-15 18:21:20 EST ---
Created attachment 562352
  -- https://bugzilla.redhat.com/attachment.cgi?id=562352
Updated spec file

I updated spec file to work for latest xpra version.  Haven't done rpm dev for
10 years so probably a little rough.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-02-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Joel j...@cryregarder.com changed:

   What|Removed |Added

 Attachment #562352|0   |1
is obsolete||

--- Comment #24 from Joel j...@cryregarder.com 2012-02-15 20:14:15 EST ---
Created attachment 562366
  -- https://bugzilla.redhat.com/attachment.cgi?id=562366
partiwm spec - added Xvfb requires

I realized that xorg-x11-server-Xvfb is required at runtime.  Tested this with
sharing firefox across two machines.  worked with no problems.

This works with xpra / partiwm 0.0.7.36

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #21 from Karel Volný kvo...@redhat.com 2012-01-26 07:10:14 EST ---
one more thing, I haven't noticed before - the new fork already provides
packages for Fedora (and it works ;-)), so maybe it'd be best to convince them
to maintain these oficially in Fedora repos, or at least offer to act as proxy
for them if none of the developers wants to become Fedora packager

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

   Flag||needinfo?(a...@redhat.com)

--- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2012-01-25 15:27:32 EST ---
I glad to hear it! I also interesting in it and ready to packaging from new
upstream.

Adam, do you willing continue, or I may take xpra and close this as duplicate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #20 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2012-01-25 15:27:53 EST ---
?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Karel Volný kvo...@redhat.com changed:

   What|Removed |Added

 CC||kvo...@redhat.com

--- Comment #18 from Karel Volný kvo...@redhat.com 2012-01-23 08:43:00 EST ---
I guess this one should be closed and a new review (possibly also a new spec)
started from scratch - the upstream is dead, and there is active fork at
http://xpra.org/

I'd like to give the new xpra a try, especially as the fork claims non-US
keyboard layout support which is a blocker for me with 0.0.6, but I do not
feel like becoming maintainer of this ... is there anyone interested enough? -
seems like I'm not the only one with such approach :-/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2012-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #17 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2012-01-14 03:29:27 EST ---
Is there any progress??

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-12-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2011-12-10 04:36:16 EST ---
Why?

If i right understand
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries it does not
mention it in exceptions.

At least there may be use case of usage it without other stuff of that big
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-12-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #16 from Ben Boeckel maths...@gmail.com 2011-12-10 09:37:30 EST 
---
Since the project is responsible for all of the libraries and executables in
the tarball, things are fine. With subpackages, users can use xpra without
parti or wimpiggy (assuming the code allows it). The problem arises when a
project includes code that it needs but is not the canonical source for that
code (say...this project shipping python-jsonpickle). That is not allowed since
the actual python-jsonpickle code could diverge and has security implications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2011-11-21 04:54:20 EST ---
If it the same external project how it may be bundled? It is violate our
guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #14 from Michal Schmidt mschm...@redhat.com 2011-11-21 07:03:34 
EST ---
parti + xpra + wimpiggy are one upstream project. The restriction on bundling
does not apply.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2011-11-20 15:30:45 EST ---
Sorry, but it is xpra included there is also it separate project
http://code.google.com/p/partiwm/wiki/xpra ? Or not?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #12 from Martin Dengler mar...@martindengler.com 2011-11-20 
23:20:24 EST ---
(In reply to comment #11)
 Sorry, but it is xpra included there is also it separate project
 http://code.google.com/p/partiwm/wiki/xpra ? Or not?

xpra is included, in the sense that when one builds rpms from partiwm.spec,
xpra rpms are built too: http://www.martindengler.com/proj/partiwm/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-06-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Ben Boeckel maths...@gmail.com changed:

   What|Removed |Added

   Flag||needinfo?(a...@redhat.com)

--- Comment #9 from Ben Boeckel maths...@gmail.com 2011-06-25 14:06:23 EDT ---
Ping?

@Martin:
If no response by next week, want to open another review (marking this as a
duplicate)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-06-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #10 from Martin Dengler mar...@martindengler.com 2011-06-25 
20:49:11 EDT ---
Sure

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-05-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Martin Dengler mar...@martindengler.com changed:

   What|Removed |Added

   Flag|needinfo?(a...@redhat.com)  |

--- Comment #8 from Martin Dengler mar...@martindengler.com 2011-05-05 
12:18:45 EDT ---
Clearing NEEDINFO

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #6 from Martin Dengler mar...@martindengler.com 2011-04-27 
14:31:59 EDT ---
I've updated the spec file per
https://bugzilla.redhat.com/show_bug.cgi?id=651591#c2 (I'm not an expert
though) and rebuilt the packages:

SPEC URL: http://www.martindengler.com/proj/partiwm/partiwm.spec
SRPM URL:
http://www.martindengler.com/proj/partiwm/partiwm-0.0.6-2.fc14.src.rpm
RPMS: http://www.martindengler.com/proj/partiwm/

Not an expert on koji but the scratch builds succeeded, so that's good:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3030582

I haven't actually tested the RPMs yet...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #7 from Martin Dengler mar...@martindengler.com 2011-04-27 
15:31:32 EDT ---
I found some later versions on winswitch.org and built them using ajax's spec
file with the aforementioned modifications, too:

http://www.martindengler.com/proj/partiwm/ 

which has had the side effect of invalidating the SPEC file link from before. 
The SRPMS are still available of course.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2011-04-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Chris Tyler ch...@tylers.info changed:

   What|Removed |Added

   Flag||needinfo?(a...@redhat.com)

--- Comment #5 from Chris Tyler ch...@tylers.info 2011-04-11 12:26:19 EDT ---
Any action on this? Would love to see this package ship.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2010-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #4 from Ben Boeckel maths...@gmail.com 2010-12-11 18:52:43 EST ---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2010-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Michal Schmidt mschm...@redhat.com changed:

   What|Removed |Added

 CC||mschm...@redhat.com

--- Comment #3 from Michal Schmidt mschm...@redhat.com 2010-11-11 04:52:39 
EST ---
*** Bug 514068 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2010-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

Ben Boeckel maths...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||maths...@gmail.com
 AssignedTo|nob...@fedoraproject.org|maths...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Ben Boeckel maths...@gmail.com 2010-11-09 21:01:43 EST ---
I'll take this (was working on it myself).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 651591] Review Request: partiwm - partitioning window manager and related tools

2010-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651591

--- Comment #2 from Ben Boeckel maths...@gmail.com 2010-11-09 21:47:29 EST ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Package is named according to the Package Naming Guidelines. [1]
[x]  Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x]  Spec file is legible and written in American English.
[x]  Spec file lacks Packager, Vendor, PreReq tags.
[x]  Spec uses macros instead of hard-coded directory names.
[x]  Package consistently uses macros.
[x]  Macros in Summary, %description expandable at SRPM build time.
[x]  PreReq is not used.
[x]  Requires correct, justified where necessary.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines. [2]
[x]  Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of
%install.
[-]  Package use %makeinstall only when ``make install DESTDIR=...'' doesn't
work.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[-]  The spec file handles locales properly.
[x]  Changelog in prescribed format.
[!]  Rpmlint output is silent.

% lintmock fedora-14-x86_64-bb
partiwm.src: W: spelling-error %description -l en_US Parti - Patti, Marti,
Parch
partiwm.src:54: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT build
install
partiwm.src: W: no-buildroot-tag
partiwm.src:16: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 4)
partiwm.src: W: invalid-url Source0: partiwm-20101109.tar.bz2
partiwm.x86_64: W: spelling-error %description -l en_US Parti - Patti, Marti,
Parch
partiwm.x86_64: W: incoherent-version-in-changelog 0.0.6-0.1.20101109
['0.0.6-1.20101109.fc14', '0.0.6-1.20101109']
partiwm.x86_64: E: no-binary
partiwm.x86_64: W: no-manual-page-for-binary parti-repl
partiwm.x86_64: W: no-manual-page-for-binary parti
wimpiggy.x86_64: W: spelling-error Summary(en_US) compositing - composting,
com positing, com-positing
wimpiggy.x86_64: W: spelling-error %description -l en_US compositing -
composting, com positing, com-positing
wimpiggy.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/wimpiggy/lowlevel/bindings.so
bindings.so()(64bit)
wimpiggy.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/wimpiggy/lowlevel/bindings.so 0775L
xpra.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/xpra/wait_for_x_server.so
wait_for_x_server.so()(64bit)
xpra.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/xpra/wait_for_x_server.so 0775L
5 packages and 0 specfiles checked; 3 errors, 13 warnings.

The tab/spaces should be cleaned up. The Release: needs to be pre-release
versioned (%changelog is correct). Not sure why the %build section is removing
the (non-existent) build and install directories.

[x]  License field in the package spec file matches the actual license.

Pedantry: GPLv2+.

[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  License file installed when any subpackage combination is installed.
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[3,4]
[x]  Sources contain only permissible code or content.
[!]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
 MD5SUM this package : 
 MD5SUM upstream package : 

What revision was the snapshot of? Please use %{hgdate}hg%{hgrev} for the
Release tag.

[x]  Compiler flags are appropriate.
[x]  %build honors applicable compiler flags or justifies otherwise.
[-]  ldconfig called in %post and %postun if required.
[x]  Package must own all directories that it creates.

I usually put a trailing '/' after directories to explicitly mark them as
directories for others' sake.

[!]  Package does not own files or directories owned by other packages.

Should %{python_sitearch} be owned by partiwm? Other arch-ed python packages
don't.

[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Each %files section contains %defattr.
[x]  No %config files under /usr.
[x]  %config files are marked noreplace or the reason is justified.
[x]  Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application. [5]

Waived as window managers don't really get started in this fashion. Does it get
added to gdm/kdm's menus?

[x]  Package contains a valid .desktop file.
[x]  Package contains code, or permissable