[Bug 651880] Review Request: rubygem-couchrest - Lean and RESTful interface for CouchDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651880 Vít Ondruch changed: What|Removed |Added Status|NEW |CLOSED CC||vondr...@redhat.com Resolution||DEFERRED Flag|needinfo?(jzigmund@redhat.c | |om) | Last Closed||2011-03-22 04:38:39 --- Comment #4 from Vít Ondruch 2011-03-22 04:38:39 EDT --- This is optional dependency for #641957, but not required ATM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651880] Review Request: rubygem-couchrest - Lean and RESTful interface for CouchDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651880 --- Comment #3 from Mamoru Tasaka 2010-11-27 11:22:47 EST --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651880] Review Request: rubygem-couchrest - Lean and RESTful interface for CouchDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651880 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(jzigm...@redhat.c ||om) --- Comment #2 from Mamoru Tasaka 2010-11-20 12:54:25 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651880] Review Request: rubygem-couchrest - Lean and RESTful interface for CouchDB
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651880
Mamoru Tasaka changed:
What|Removed |Added
CC||mtas...@ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka 2010-11-12
14:00:45 EST ---
Some notes
* Unused macro
- Defined macro %ruby_sitelib is used nowhere in the spec file
* License
-
Overall: ASL 2.0
MIT
./lib/couchrest/support/inheritable_attributes.rb
-
- The license tag should be "ASL 2.0 and MIT".
* Requires
- Currently "rubygem(json) >= 1.4.6" is only available on rawhide.
Would you check if version no less than 1.4.6 is really needed for
this rpm? If not, modify spec file, and gemspec / Rakefile
in the binary rpm.
( Again would you check if the binary rpm rebuilt from your
srpm can really be installed beforehand? It seems that
you are using F-13 system, however rubygem-json on F-13 is
still 1.1.9 )
- It is true that rubygem(mime-types) is required by
installed gemspec file, however would you check if this
dependency is really needed? None of the files in
rubygem-couchrest binary rpms seems to have "require 'mime/types'" or
so.
If this dependency is not really needed, please remove this from
spec file and included Rakefile/gemspec
* Documents
- I guess %geminstdir/utils should be moved to -doc
- Instead %{geminstdir}/THANKS.md should be moved to main package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
