[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Sven Lankes changed: What|Removed |Added Flag||needinfo?(f...@fcami.net) --- Comment #5 from Sven Lankes 2011-01-17 14:52:23 EST --- Ping. François - are you going to do the review? If not please -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 François Cami changed: What|Removed |Added AssignedTo|f...@fcami.net |nob...@fedoraproject.org Flag|needinfo?(f...@fcami.net)| --- Comment #6 from François Cami 2011-01-17 15:42:42 EST --- Releasing. Sorry, I haven't got enough time to do it properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #7 from Martin Gieseking 2011-01-21 07:31:35 EST --- Hi Sven, are you still interested in submitting this package? The URLs given in comment #3 seem to be dead (404). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #8 from Sven Lankes 2011-01-21 10:29:24 EST --- (In reply to comment #7) > are you still interested in submitting this package? The URLs given in comment > #3 seem to be dead (404). Sorry - I didn't notice that. I am still interested. New urls: Spec URL: http://yuio.de/Fedora/SPECS/since.spec SRPM URL: http://yuio.de/Fedora/SRPMS/since-1.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=654879
--- Comment #9 from Martin Gieseking 2011-01-21
11:28:01 EST ---
Here are some comments on your latest spec:
- I recommend not to adapt the Makefile but assign the proper CFLAGS in the
make
statement instead:
make CFLAGS='%{optflags} -DVERSION=\"%{version}\"' %{?_smp_mflags}
This is much safer since sed might silently fail if the pattern doesn't
match.
- use macro %{_prefix} in the %install section:
make install prefix=$RPM_BUILD_ROOT/%{_prefix} INSTALL='install -Dp'
- clear the exec perms of the manpage (in %install), e.g.:
chmod 644 $RPM_BUILD_ROOT/%{_mandir}/man1/since.1
- in %files, please use either the %{name} macro or "since". Don't mix them:
%{_bindir}/%{name}
%{_mandir}/man1/%{name}.1*
or
%{_bindir}/since
%{_mandir}/man1/since.1*
- replace %clean with %%clean in the %changelog to make rpmlint happy
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
since.src:35: W: macro-in-%changelog %clean
since.x86_64: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
since.x86_64: W: spurious-executable-perm /usr/share/man/man1/since.1.gz
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #10 from Sven Lankes 2011-01-31 13:10:58 EST --- Thanks for looking at the spec - I've fixed the issues you pointed out: Spec URL: http://yuio.de/Fedora/SPECS/since.spec SRPM URL: http://yuio.de/Fedora/SRPMS/since-1.1-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=654879
Martin Gieseking changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review+
--- Comment #11 from Martin Gieseking 2011-01-31
13:54:41 EST ---
The package looks good now. Just add a final dot to the %description text. :)
As you probably don't want to build the package for EPEL < 6, you can ignore
the [X]-marked items below.
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
since.x86_64: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
The spelling errors are false positive.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3+ according to README
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum since-1.1.tar.gz*
7a6cfe573d0d2ec7b6f53fe9432a486b since-1.1.tar.gz
7a6cfe573d0d2ec7b6f53fe9432a486b since-1.1.tar.gz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
koji scratch build (f15):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2753430
[+] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[.] SHOULD: If the source package does not include license text(s) as a
separate file ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[+] SHOULD: Your package should contain man pages for binaries/scripts.
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #12 from Martin Gieseking 2011-02-22 03:40:51 EST --- Sven, what's the status of this bug? Don't you want to request a Git repo for the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Sven Lankes changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Sven Lankes 2011-02-24 17:16:26 EST --- New Package SCM Request === Package Name: since Short Description: Stateful tail replacement Owners: slankes Branches: f15 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #14 from Jason Tibbitts 2011-02-24 22:11:44 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #15 from Fedora Update System 2011-02-27 13:09:30 EST --- Package since-1.1-3.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing since-1.1-3.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/since-1.1-3.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System 2011-03-01 01:45:37 EST --- since-1.1-3.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update since'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/since-1.1-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||since-1.1-3.fc15 Resolution||ERRATA Last Closed||2011-03-04 21:33:17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #17 from Fedora Update System 2011-03-04 21:33:08 EST --- since-1.1-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 François Cami changed: What|Removed |Added CC||f...@fcami.net AssignedTo|nob...@fedoraproject.org|f...@fcami.net --- Comment #1 from François Cami 2010-11-18 18:02:11 EST --- I'll do a full review shortly. In the meantime, could you fix the following errors: since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately since.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni since.src: W: no-buildroot-tag 1 packages and 0 specfiles checked; 0 errors, 3 warnings. At least the second and third error, the first is OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #2 from Jason Tibbitts 2010-11-18 18:22:36 EST --- no-buildroot-tag is not an error. Fedora hasn't required BuildRoot: since F10. It doesn't require %clean or the buildroot cleaning in %install, either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #3 from Sven Lankes 2010-11-18 18:27:14 EST --- Thanks for looking at since. New version: Spec URL: http://sven.lank.es/Fedora/SPECS/since.spec SRPM URL: http://sven.lank.es/Fedora/SRPMS/since-1.1-2.fc14.src.rpm I've changed unix to Unix. And removed %clean and the buildroot cleaning in %install as Jason noted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654879] Review Request: since - stateful tail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654879 --- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) 2010-11-20 10:08:35 EST --- (In reply to comment #2) > no-buildroot-tag is not an error. Fedora hasn't required BuildRoot: since > F10. > It doesn't require %clean or the buildroot cleaning in %install, either. Until it is not intended for EPEL5 too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
