[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX Last Closed||2011-10-23 06:39:29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=655184
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #12 from Volker Fröhlich volke...@gmx.at 2011-02-02 18:47:11 EST
---
[+] Good
[x] Needs work
[0] Does not apply
MUST:
=
[+] Naming according to the Package Naming Guidelines
[+] Spec file matches base package name
[+] Packaging guidelines met
[+] License approved for Fedora
[+] License field in spec matches
[+] License file included, if source package includes it
[+] Spec in American English
[+] Spec is legible
[+] rpmlint:
rpmlint ../SRPMS/drupal6-data-1.0-0.4.alpha14.fc13.src.rpm
../RPMS/noarch/drupal6-data-1.0-0.4.alpha14.fc13.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[+] Sources match upstream md5sum: ce3d19268ecf88ebbb23a4b9cd45052d
[+] Builds into binary RPMs on at least one primary architecture:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2758682
[0] ExcludeArch is specified and commented:
[0] All build dependencies listed
[0] The spec file handles locales properly
[0] Calls ldconfig for its shared libraries
[0] No bundled system libraries
[0] Stated as relocatable package
[+] Owns all its directories or requires packages that do
[+] No file listing duplicates
[+] File permissions correct
[+] Consistent use of macros
[+] Code or permissible content
[0] Large documentation in -doc subpackage
[+] No runtime dependency of files listed as %doc
[0] Header files in -devel subpackage
[0] Static files in -static subpackage
[0] Library files without suffix in -devel subpackage
[0] Devel-package requires base package
[0] No .la libtool archives
[0] GUI application includes properly installed %{name}.desktop file
[+] No files or directories owned, that other packages own
[+] Filenames in packages are UTF-8
SHOULD:
===
[0] Query upstream if no license text is included
[+] Package builds in mock: (epel-6-x86_64)
[0] Scriptlets are sane, if used
[0] Subpackages other than -devel should require base package (versioned)
[0] pkgconfig files in -devel subpackage
[0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider
requiring the package which provides the file instead of the file itself
[0] Contain man pages, where they make sense
I didn't try whether it works.
NOTE:
=
Use the prerelease and alpha macros in Source0.
Please remove the name from the summary.
Please beautify the description. Also consider shortening, especially:
You may want to
check out Feeds module for using Data
as a storage engine for RSS/Atom feed data.
know how Data relates to Table Wizard
know that Data module is the successor of Flatstore.
Descriptions should be no longer than 3 paragraphs.
Drop the require for drupal6, since the other packages already require it.
Looking closer, it doesn't necessarily NEED the two modules. If you regard the
module useless, without the others, leave the Requires.
The chmod is not necessary.
Files section can be simplified to:
...
%doc LICENSE.txt README.txt %{name}-fedora-README.txt CHANGELOG.txt
%{drupaldir}/modules/data
%exclude %{drupaldir}/modules/data/*.txt
%dir is only necessary in the other packages, because there are translations.
This package doesn't have any. Nevertheless, it is not wrong.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 --- Comment #8 from Peter Borsa peter.bo...@gmail.com 2011-01-26 05:40:37 EST --- http://asrob.net/fedora/drupal6-data.spec http://asrob.net/fedora/drupal6-data-1.0-0.3.alpha14.fc14.src.rpm This is an other build which contains several fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Eric Christensen e...@christensenplace.us changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|e...@christensenplace.us|nob...@fedoraproject.org Flag|fedora-review? | --- Comment #9 from Eric Christensen e...@christensenplace.us 2011-01-26 13:37:06 EST --- Sorry, I'm not going to be able to review this one right now. Perhaps someone else can take it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 --- Comment #10 from Peter Borsa peter.bo...@gmail.com 2011-01-26 13:42:10 EST --- Eric, no problem. I hope Volter will assign this, I'll write an email to him. Thanks all, Eric. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|volke...@gmx.at -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 --- Comment #7 from Peter Borsa peter.bo...@gmail.com 2011-01-19 12:02:42 EST --- http://asrob.net/fedora/drupal6-data.spec http://asrob.net/fedora/drupal6-data-1.0-0.2.alpha14.fc14.src.rpm Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #6 from Volker Fröhlich volke...@gmx.at 2011-01-18 09:04:50 EST --- Please correct the license to GPLv2+, as all modules hosted in Drupal's CVS must be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 --- Comment #5 from Peter Borsa peter.bo...@gmail.com 2010-12-01 11:54:57 EST --- Updated files: http://asrob.fedorapeople.org/SOURCES/drupal6-data.spec http://asrob.fedorapeople.org/SOURCES/drupal6-data-1.0-0.1.alpha14.fc14.src.rpm rpmlint output: [as...@alice SPECS]$ rpmlint drupal6-data.spec ../SRPMS/drupal6-data-1.0-0.1.alpha14.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2636690 Watching tasks (this may be safely interrupted)... 2636690 build (dist-f14, drupal6-data-1.0-0.1.alpha14.fc14.src.rpm): free 2636690 build (dist-f14, drupal6-data-1.0-0.1.alpha14.fc14.src.rpm): free - open (x86-15.phx2.fedoraproject.org) 2636691 buildArch (drupal6-data-1.0-0.1.alpha14.fc14.src.rpm, noarch): free 2636691 buildArch (drupal6-data-1.0-0.1.alpha14.fc14.src.rpm, noarch): free - open (x86-03.phx2.fedoraproject.org) 2636691 buildArch (drupal6-data-1.0-0.1.alpha14.fc14.src.rpm, noarch): open (x86-03.phx2.fedoraproject.org) - closed 0 free 1 open 1 done 0 failed 2636690 build (dist-f14, drupal6-data-1.0-0.1.alpha14.fc14.src.rpm): open (x86-15.phx2.fedoraproject.org) - closed 0 free 0 open 2 done 0 failed 2636690 build (dist-f14, drupal6-data-1.0-0.1.alpha14.fc14.src.rpm) completed successfully -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2010-11-22 09:07:35 EST --- I see no approval here, and the fedora-review flag is not set to '+'. Why are you making an SCM request now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 --- Comment #4 from Peter Borsa peter.bo...@gmail.com 2010-11-22 09:15:28 EST --- Sorry I didn't understand SCM request. I believed that I had a reviewed package then I could request a new package SCM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Eric Christensen e...@christensenplace.us changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|e...@christensenplace.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Peter Borsa peter.bo...@gmail.com 2010-11-21 15:39:23 EST --- New Package SCM Request === Package Name: drupal6-data Short Description: Data module helps you model, manage and query related sets of tables. Owners: asrob Branches: f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Nick Bebout n...@fedoraproject.org changed: What|Removed |Added CC||n...@fedoraproject.org Blocks|177841(FE-NEEDSPONSOR) | --- Comment #1 from Nick Bebout n...@fedoraproject.org 2010-11-21 14:01:31 EST --- I've sponsored asrob so I'm unblocking FE-NEEDSPONSOR -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655184] Review Request: drupal6-data - Data module helps you model, manage and query related sets of tables.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655184 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added CC||e...@christensenplace.us Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
