[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
https://bugzilla.redhat.com/show_bug.cgi?id=656010 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
https://bugzilla.redhat.com/show_bug.cgi?id=656010 Jeffrey C. Ollie changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Jeffrey C. Ollie --- Package Change Request == Package Name: libsrtp New Branches: epel7 Owners: jcollie InitialCC: For Asterisk SRTP support -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #13 from Jason Tibbitts 2011-01-24 16:46:43 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Jeffrey C. Ollie changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #12 from Jeffrey C. Ollie 2011-01-24 15:23:06 EST --- Package Change Request == Package Name: libsrtp New Branches: el6 Owners: jcollie InitialCC: Wanted for Asterisk SRTP support. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Fedora Update System changed: What|Removed |Added Fixed In Version|libsrtp-1.4.4-1.20101004cvs |libsrtp-1.4.4-1.20101004cvs |.fc13 |.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #11 from Fedora Update System 2010-12-17 03:43:31 EST --- libsrtp-1.4.4-1.20101004cvs.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libsrtp-1.4.4-1.20101004cvs ||.fc13 Resolution||ERRATA Last Closed||2010-12-17 03:23:43 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #10 from Fedora Update System 2010-12-17 03:23:36 EST --- libsrtp-1.4.4-1.20101004cvs.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2010-12-07 15:08:22 EST --- libsrtp-1.4.4-1.20101004cvs.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libsrtp'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #8 from Fedora Update System 2010-12-06 12:48:21 EST --- libsrtp-1.4.4-1.20101004cvs.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #7 from Fedora Update System 2010-12-06 12:48:13 EST --- libsrtp-1.4.4-1.20101004cvs.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #6 from Jason Tibbitts 2010-12-06 11:00:31 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Tom "spot" Callaway changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Tom "spot" Callaway 2010-12-06 10:02:51 EST --- New Package SCM Request === Package Name: libsrtp Short Description: An implementation of the Secure Real-time Transport Protocol (SRTP) Owners: spot jcollie Branches: f13 f14 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 Dmitrij S. Kryzhevich changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Dmitrij S. Kryzhevich 2010-12-04 04:41:51 EST --- >Unfortunately, it is not trivial to remove that exit() Ok. What about ping upstream? Not a blocker. >With CVS all you have is a date Yes, -D, found it. May be, just may be, it would be nice to be sure there is _this_ version that in the package. Not a blocker. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656010 --- Comment #3 from Jason Tibbitts 2010-12-03 11:06:55 EST --- With CVS all you have is a date, or a tag if upstream has made one. There is no concept analogous to SVN's revision number or git's commit hash. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656010
--- Comment #2 from Tom "spot" Callaway 2010-12-03
10:59:25 EST ---
Honestly, I'm not sure how to get any sort of sane revision for the tree from
cvs. If you know how, I'd be happy to add it.
The exit() call is in crypto_kernel_status (in crypto/kernel/crypto_kernel.c)
/* for each cipher type, describe and test */
while(ctype != NULL) {
printf("cipher: %s\n", ctype->cipher_type->description);
printf(" instance count: %d\n", ctype->cipher_type->ref_count);
printf(" self-test: ");
status = cipher_type_self_test(ctype->cipher_type);
if (status) {
printf("failed with error code %d\n", status);
exit(status);
}
printf("passed\n");
ctype = ctype->next;
}
Unfortunately, it is not trivial to remove that exit(), so I'm inclined to just
leave it in.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656010] Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656010
Dmitrij S. Kryzhevich changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||kr...@land.ru
AssignedTo|nob...@fedoraproject.org|kr...@land.ru
Flag||fedora-review?
--- Comment #1 from Dmitrij S. Kryzhevich 2010-12-03 02:20:20
EST ---
rpmlint is not silent.
libsrtp.src: W: no-cleaning-of-buildroot %clean
libsrtp.src: W: no-buildroot-tag
libsrtp.src: W: no-%clean-section
libsrtp.src: W: invalid-url Source0: srtp-1.4.4-20101004cvs.tar.bz2
libsrtp.x86_64: W: shared-lib-calls-exit /usr/lib64/libsrtp.so.0.0.0
e...@glibc_2.2.5
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Exit call is not good. Could you provide any reasons why it might be leaved as
is?
Is there any way to specify the revision for csv checkout in spec?
* The package named according to the Package Naming Guidelines.
* The spec file name match the base package %{name}.
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license.
* The License field in the package spec file matchs the actual license.
* File, containing the text of the license(s) for the package is included in
%doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package match the upstream source. MARK: md5sum
on provided .tar.bz2 and obtained .tar.bz2 are MISMATCHED, but the sources are
EQUAL.
* The package successfully compiles and builds into binary rpms on x86_64 F14.
* All build dependencies are listed in BuildRequires.
* There are no locales.
* Binary RPM package which stores shared library files calls ldconfig in %post
and %postun.
* Packages do not bundle copies of system libraries.
* A package owns all directories that it creates.
* There are no files, listed more than once in the spec file's %files listings.
* Permissions on files are set properly.
* The package contains code, or permissable content.
* There is no large documentation.
* Header files are in a -devel package.
* There are no static libraries.
* Library files that end in .so (without suffix) is in a -devel package.
* Devel packages requires the base package.
* Packages doed not contain any .la libtool archives.
* All filenames in rpm packages are valid UTF-8.
All is need are the answers on two above questions.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
